From nobody Tue Nov 30 22:55:35 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B258218B568C for ; Tue, 30 Nov 2021 22:55:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J3cxz2vKcz4jBP for ; Tue, 30 Nov 2021 22:55:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 432FB1E9A4 for ; Tue, 30 Nov 2021 22:55:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1AUMtZCe026722 for ; Tue, 30 Nov 2021 22:55:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1AUMtZAj026721 for bugs@FreeBSD.org; Tue, 30 Nov 2021 22:55:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260128] "make tags" fails with "gtags not found", src/Makefile undesirably rewrites PATH Date: Tue, 30 Nov 2021 22:55:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jfolker11@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638312935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RMurYDL4CGgHSTfChUvWkK+/yYWTVJSEuenr0ub3uKA=; b=lr3dzll5egBqCkWTIZR1VjrV8pXxlZdIQBYHPKRCGH977IDWYftUFnHkx9O5hszs1PdZ/i ePCL4HPveYRAcsfThpKjLq4fvxGwDfB2xqHU5zBg3AcF5WjL5PDC+qZYwW+aw7brSRSt04 Lhm/y/eBgSBvp4m3dYsDXkp0JbyuAOM3PDCOhwHRaHrf0vvptFeAuYYwTh3O9mXkrBpw/O 48LX/gl8IqGAdothFb4b6dqdg195y+S+q32S+Y9TJOnUuLmD6H3qENykXM52zVRk0E4azh FDfYxPdP8nOWDDksSr8x9dMlt5eDPY9yIEnRsajU6xa20EmA4wIJV3TkzSKASQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638312935; a=rsa-sha256; cv=none; b=I12McDjYdcK5O6UQMfffv6elhO52s+57WuBQxUxdTsSDhw6gEtiD2ikpbFCVO/ZsajvYIP 4G88/SNVfzm5qV4MszOkqAAm19c39+8pNwFxnvsq8jbsdR5TiWuPjdIYX4HCxltnF4f+sQ lg+tTKHstq9QeqfRLO1UkVM1P84qT8KIw5xG55qEV3uAk9Gi0EsL7ELIZZvt0SnevFarK9 /7H+sfIzrOvjX5VTTXkEgJqhL0Zh/QF59ZAWotpyVFzMjuN/oB+NYcfQaraszndxcrksK0 l4Xm0xzNa+lFbNqFPiTs2ssoGwrms9yAQD85sOy2D2U3hyAYIusGVTBjDKW6qw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260128 Jory Folker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jfolker11@gmail.com --- Comment #4 from Jory Folker --- For now, I propose setting /usr/local/bin/gtags in bsd.dep.mk, and here is = my diff: freebsd% cat bsd.dep.mk.diff --- bsd.dep.mk 2021-11-30 16:09:01.231877000 -0600 +++ bsd.dep.mk.new 2021-11-30 16:08:25.988490000 -0600 @@ -45,7 +45,7 @@ .error bsd.dep.mk cannot be included directly. .endif -CTAGS?=3D gtags +CTAGS?=3D /usr/local/bin/gtags CTAGSFLAGS?=3D GTAGSFLAGS?=3D -o HTAGSFLAGS?=3D freebsd%=20 If we could eliminate a dependency on an executable from outside the base system, then defaulting to ctags and allowing the user to change it by exporting CTAGS in their env is ideal. However, when I run 'make tags' with ctags, stderr is flooded with superflu= ous "Duplicate entry" warnings for redefined macros, functions defined using macros, etc, like this: Duplicate entry in file /usr/home/jfolker/freebsd/src/contrib/ntp/ntpdc/ntpdc.c, line 1910: __attribute__ Second entry ignored Duplicate entry in file /usr/home/jfolker/freebsd/src/contrib/ntp/ntpdc/ntpdc.c, line 1926: __attribute__ Second entry ignored This isn't itself bad, but it gives reasonable suspicion that we will lose other functionality switching from gtags to ctags. But I found something else worth noting: unless the install dest for GNU gl= obal was changed in the ports tree Makefile, 'make tags' has been broken for ove= r 18 years. freebsd% git blame src/Makefile d672a60908a4 (Ruslan Ermilov 2002-04-29 15:22:01 +0000 214)=20 76499f153979 (Ruslan Ermilov 2003-01-29 10:00:42 +0000 215) PATH=3D=20 /sbin:/bin:/usr/sbin:/usr/bin 2e84ab947d9c (Ruslan Ermilov 2002-12-02 14:31:21 +0000 216) MAKEOBJDIRPREFIX?=3D /usr/obj freebsd% freebsd% git blame src/share/mk/bsd.dep.mk 5ffdf3618ef7 (Ruslan Ermilov 2002-04-22 10:04:41 +0000 44) .if !target(____) 5ffdf3618ef7 (Ruslan Ermilov 2002-04-22 10:04:41 +0000 45) .error bsd.dep.mk cannot be included directly. 5ffdf3618ef7 (Ruslan Ermilov 2002-04-22 10:04:41 +0000 46) .endif b16495e786c9 (Wolfram Schneider 1996-04-01 18:58:28 +0000 47)=20 ccc4bab1047d (Ruslan Ermilov 2002-10-17 13:48:13 +0000 48) CTAGS?=3D= =20=20=20=20=20=20=20 gtags ccc4bab1047d (Ruslan Ermilov 2002-10-17 13:48:13 +0000 49) CTAGSFLAGS= ?=3D ccc4bab1047d (Ruslan Ermilov 2002-10-17 13:48:13 +0000 50) GTAGSFLAGS= ?=3D=20=20 -o ccc4bab1047d (Ruslan Ermilov 2002-10-17 13:48:13 +0000 51) HTAGSFLAGS= ?=3D ccc4bab1047d (Ruslan Ermilov 2002-10-17 13:48:13 +0000 52) --=20 You are receiving this mail because: You are the assignee for the bug.=