From nobody Fri Jul 30 16:32:21 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4785412BEC85 for ; Fri, 30 Jul 2021 16:32:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GbtGY1McMz3Ghp for ; Fri, 30 Jul 2021 16:32:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 174604A5 for ; Fri, 30 Jul 2021 16:32:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 16UGWLtS052758 for ; Fri, 30 Jul 2021 16:32:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 16UGWLqL052757 for bugs@FreeBSD.org; Fri, 30 Jul 2021 16:32:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 257510] unstr does not produce a valid fortune file Date: Fri, 30 Jul 2021 16:32:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: hubert.tournier@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257510 Bug ID: 257510 Summary: unstr does not produce a valid fortune file Product: Base System Version: 13.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: hubert.tournier@gmail.com Created attachment 226804 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D226804&action= =3Dedit Patch file to correct the issue Overview: While reimplementing the unstr command, I noticed that the original command, when displaying a fortune file in the order specified in its datafile, does= not print the final '%' delimiter, which should end any fortune and any fortune file. Steps to Reproduce: # cd /usr/share/games/fortune # tail -1 freebsd-tips % # strfile -Co freebsd-tips "freebsd-tips.dat" created There were 134 strings Longest string: 746 bytes Shortest string: 39 bytes # unstr freebsd-tips | tail -4 % sh (the default Bourne shell in FreeBSD) supports command-line editing. Ju= st ``set -o emacs'' or ``set -o vi'' to enable it. Use "" key to complete paths. Build Date & Hardware:=20 Additional Builds and Platforms: Any BSD version since 4.4. This is a 28 years old bug! Correction: Here's a patchfile to correct this in /usr/src/usr.bin/fortune/unstr/unstr.c --=20 You are receiving this mail because: You are the assignee for the bug.=