From nobody Mon Dec 27 10:46:03 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 06E3C190E8F0 for ; Mon, 27 Dec 2021 10:46:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JMvTn5zHZz3Klb for ; Mon, 27 Dec 2021 10:46:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A067A1C452 for ; Mon, 27 Dec 2021 10:46:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1BRAk5kL071119 for ; Mon, 27 Dec 2021 10:46:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1BRAk5qV071118 for bugs@FreeBSD.org; Mon, 27 Dec 2021 10:46:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 169620] [ng] [pf] ng_l2tp incoming packet bypass pf firewall Date: Mon, 27 Dec 2021 10:46:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 8.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: longwitz@incore.de X-Bugzilla-Status: Closed X-Bugzilla-Resolution: DUPLICATE X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640601965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zAYqPo2NVxQeje4vOrXZWgZ1lOYjtfs72nm5P9gN3c=; b=IuowOcmqkNiz1+5SQ9mkHM73qeIZQ1nSuVarJvgHsBReJOWX1z4KmHxViplxVFLDLUUFJ9 F8Enr1vBzRbOkwEtNOre+hPfCWRf/v5dOxSUcfKiAeGcx7xxbTt/LH+akUjN+/kUZjAfVV tEjtTw2pvryl8xorycWspXh1boOVsMrASIk01zPf7tdBxWIQEO9VFWB+tXUBJlx8sFK/Us ihQyHPG89io+vUEZnYPNNLGaBAQLCHn54VWnA9AmOuo6g9FQ6+X4WvkHdOxEtLa8jgzjAe lk2Jqz9ZqOyV7FTt4o/euqR0XHvW7AU7JkA4vleokNY7IfWdaZCPX59SCthW6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640601965; a=rsa-sha256; cv=none; b=ZpZTx2KL8AGCPvziTUdVamPLmBB5rAm+2uMuEffBQuhf0P8+eAZBqk96WxMe9sbsi2axMF OTK4JcSuAs5h2Es044q817e3bjkDJOLYcMoho93FPV0PDSt8GEFoiKV4jx0Tvy9YAWTyRB T3eLx/GKLkoGqnX3ILdvMrTb5pWCcRdGxbpogPKZtR0h4wtV7IU9CARiKsMf97WBm/XyCa eLTvFK7xcxeJehb3IFizLCaFXeRHgc2TCr+Gf8Ae3vsVFUOFk60VZqssmIiUsXbpMe5Q2/ sGDS/2sHa3qLNNgUJkurRoF4cLOKLi6fLg4PHnGGMQlIdod6xA1+vqg2xAFK1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D169620 longwitz@incore.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |longwitz@incore.de --- Comment #8 from longwitz@incore.de --- The patch given in bug 187566 has solved an other problem than the one discussed in this bug report. We still need the patch --- ng_l2tp.c.1st 2021-12-19 19:31:10.693840000 +0100 +++ ng_l2tp.c 2021-12-23 14:50:47.334147000 +0100 @@ -755,6 +755,7 @@ hookpriv_p hpriv =3D NULL; hook_p hook =3D NULL; struct mbuf *m; + struct m_tag *mtag; u_int16_t tid, sid; u_int16_t hdr; u_int16_t ns, nr; @@ -997,6 +998,11 @@ NG_FREE_M(m); ERROUT(0); } + + /* Delete an existing ipsec tag */ + mtag =3D m_tag_find(m, PACKET_TAG_IPSEC_IN_DONE, NULL); + if (mtag !=3D NULL) + m_tag_delete(m, mtag); /* Deliver data */ NG_FWD_NEW_DATA(error, item, hook, m); The same issue for if_epair.c is solved in FreeBSD V12.3 calling a new statc function called epair_clear_mbuf(). commit ae23f081... Andreas --=20 You are receiving this mail because: You are the assignee for the bug.=