From nobody Wed Feb 15 15:44:24 2023 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH2S16jwWz3qSkQ for ; Wed, 15 Feb 2023 15:44:01 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (www.zefox.net [50.1.20.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "www.zefox.com", Issuer "www.zefox.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH2Rz5sZJz3R1s for ; Wed, 15 Feb 2023 15:43:59 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of fbsd@www.zefox.net has no SPF policy when checking 50.1.20.27) smtp.mailfrom=fbsd@www.zefox.net; dmarc=none Received: from www.zefox.net (localhost [127.0.0.1]) by www.zefox.net (8.16.1/8.15.2) with ESMTPS id 31FFiPih034396 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Wed, 15 Feb 2023 07:44:25 -0800 (PST) (envelope-from fbsd@www.zefox.net) Received: (from fbsd@localhost) by www.zefox.net (8.16.1/8.15.2/Submit) id 31FFiPIH034395 for freebsd-arm@freebsd.org; Wed, 15 Feb 2023 07:44:25 -0800 (PST) (envelope-from fbsd) Date: Wed, 15 Feb 2023 07:44:24 -0800 From: bob prohaska To: freebsd-arm@freebsd.org Subject: Re: fsck segfaults on rpi3 running 13-stable (and on 14-CURRENT analyzing the same file system that resulted from the 13-STABLE crash) Message-ID: <20230215154424.GA34278@www.zefox.net> References: <20230212191308.GA21535@www.zefox.net> <20230212195324.GB21535@www.zefox.net> <03840D0B-13D4-4F22-BDAF-2887A4D78BED@yahoo.com> <20230213232519.GD95670@funkthat.com> <20230214161415.GA28276@www.zefox.net> <20230214183827.GG95670@funkthat.com> <20230214210601.GA28959@www.zefox.net> <20230214232746.GI95670@funkthat.com> List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230214232746.GI95670@funkthat.com> X-Spamd-Result: default: False [-1.10 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_WWW(0.50)[]; WWW_DOT_DOMAIN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-arm@freebsd.org]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:7065, ipnet:50.1.16.0/20, country:US]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[zefox.net]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arm@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4PH2Rz5sZJz3R1s X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N On Tue, Feb 14, 2023 at 03:27:46PM -0800, John-Mark Gurney wrote: > > In this case, an inode's mtime is wildly incorrect. Here is a simple > patch that will let it get farther, BUT, it doesn't necessarily mean > that the kernel can properly handle the mtime: > diff --git a/sbin/fsck_ffs/inode.c b/sbin/fsck_ffs/inode.c > index 82338f4f8c08..d0892a822dc5 100644 > --- a/sbin/fsck_ffs/inode.c > +++ b/sbin/fsck_ffs/inode.c > @@ -1311,7 +1311,10 @@ prtinode(struct inode *ip) > printf("SIZE=%ju ", (uintmax_t)DIP(dp, di_size)); > t = DIP(dp, di_mtime); > p = ctime(&t); > - printf("MTIME=%12.12s %4.4s ", &p[4], &p[20]); > + if (p == NULL) > + printf("MTIME=invalid "); > + else > + printf("MTIME=%12.12s %4.4s ", &p[4], &p[20]); > } > > void I tried to apply the patch with root@www:/usr/src # patch -p1 < fsck.patch Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |index 82338f4f8c08..d0892a822dc5 100644 |--- a/sbin/fsck_ffs/inode.c |+++ b/sbin/fsck_ffs/inode.c -------------------------- Patching file sbin/fsck_ffs/inode.c using Plan A... Hunk #1 failed at 1311. 1 out of 1 hunks failed--saving rejects to sbin/fsck_ffs/inode.c.rej Hmm... Ignoring the trailing garbage. done Obviously I'm doing something dumb.....any hints? Thanks for writing, bob prohaska