From nobody Tue Aug 29 08:50:59 2023 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RZh3h3vCzz4rYH4 for ; Tue, 29 Aug 2023 08:51:12 +0000 (UTC) (envelope-from titus@edc.ro) Received: from eatlas.ro (eatlas.ro [86.126.82.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "eatlas.ro", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RZh3g3D9Kz4VcS for ; Tue, 29 Aug 2023 08:51:11 +0000 (UTC) (envelope-from titus@edc.ro) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=edc.ro header.s=mail header.b=oHgJ1iP5; spf=pass (mx1.freebsd.org: domain of titus@edc.ro designates 86.126.82.18 as permitted sender) smtp.mailfrom=titus@edc.ro; dmarc=none Received: from mail.edc.ro ([10.1.4.58]) by eatlas.ro (8.16.1/8.16.1) with ESMTPS id 37T8p0HU091232 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 11:51:01 +0300 (EEST) (envelope-from titus@edc.ro) Received: from tituss-imac.eatlas.local (eatlas.ro [86.126.82.18]) (authenticated bits=0) by mail.edc.ro (8.16.1/8.16.1) with ESMTPSA id 37T8oxpv000266 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 11:50:59 +0300 (EEST) (envelope-from titus@edc.ro) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=edc.ro; s=mail; t=1693299060; bh=SuqDIh5PKOWQZuRPVAi4uFKAvaN3Nhy7RNAyBeW3Duo=; h=From:Subject:Date:Cc:To; b=oHgJ1iP5Kt2eIh7uCGsL/9661cJ3TU/pVc9RIhysrIstgqoX5efO9cGxaETfn15UK KRIPWmXXisFcSwy3LjEwGr4PrXZ0jO4SDOSQwHuuhCfvwoEiGPX4MOzqs9Wob46TZN NMcjnV8NlHgVLPrG2bEne3BWAYU5dLLmxuxMG2IM= From: titus Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: nvmem_get_cell_len Message-Id: <66F75D3F-B8DE-4756-AA65-D403F1BA58E0@edc.ro> Date: Tue, 29 Aug 2023 11:50:59 +0300 Cc: freebsd-arm To: Emmanuel Vadot X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on ns.edc.ro X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.93 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.93)[-0.930]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:86.126.82.18/32]; R_DKIM_ALLOW(-0.20)[edc.ro:s=mail]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:8708, ipnet:86.120.0.0/13, country:RO]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-arm@freebsd.org]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[edc.ro:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[edc.ro]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4RZh3g3D9Kz4VcS Hello, in /sys/dev/extres/nvmem/nvmem.c nvmem_get_cell_len can=E2=80=99t properly return an error or a valid = size probably the size should be returned via a pointer to size_t arg and = return 0 on success the function does not seem to be used anywhere (13.2) so it should be = easy to change also why is it an error in nvmem_read_cell_by_idx if the buflen arg is = larger than the actual cell size ? (the same is in aw_sid too)