From nobody Wed Mar 23 18:24:46 2022 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 054231A312C1 for ; Wed, 23 Mar 2022 18:24:50 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (www.zefox.net [50.1.20.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "www.zefox.com", Issuer "www.zefox.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KNxbN2X65z3mJH; Wed, 23 Mar 2022 18:24:48 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (localhost [127.0.0.1]) by www.zefox.net (8.16.1/8.15.2) with ESMTPS id 22NIOkSe022836 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 23 Mar 2022 11:24:46 -0700 (PDT) (envelope-from fbsd@www.zefox.net) Received: (from fbsd@localhost) by www.zefox.net (8.16.1/8.15.2/Submit) id 22NIOkMQ022835; Wed, 23 Mar 2022 11:24:46 -0700 (PDT) (envelope-from fbsd) Date: Wed, 23 Mar 2022 11:24:46 -0700 From: bob prohaska To: Kristof Provost Cc: Mark Millard , grembo@freebsd.org, Free BSD , bob prohaska Subject: Re: /usr/src/sys/net/if_epair.c:181:6: error: ... Message-ID: <20220323182446.GA22818@www.zefox.net> References: <20220323155947.GA96051@www.zefox.net> <22389953-442F-4915-8797-32D1FF577F44@freebsd.org> List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22389953-442F-4915-8797-32D1FF577F44@freebsd.org> X-Rspamd-Queue-Id: 4KNxbN2X65z3mJH X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of fbsd@www.zefox.net has no SPF policy when checking 50.1.20.27) smtp.mailfrom=fbsd@www.zefox.net X-Spamd-Result: default: False [-0.99 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; WWW_DOT_DOMAIN(0.50)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-0.89)[-0.894]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[zefox.net]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MLMMJ_DEST(0.00)[freebsd-arm]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7065, ipnet:50.1.16.0/20, country:US]; FREEMAIL_CC(0.00)[yahoo.com,freebsd.org,www.zefox.net]; MID_RHS_WWW(0.50)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Wed, Mar 23, 2022 at 05:51:18PM +0100, Kristof Provost wrote: > > > > On 23 Mar 2022, at 16:59, bob prohaska wrote: > > > > ???On Wed, Mar 23, 2022 at 11:51:17AM +0100, Kristof Provost wrote: > >> > >> Can you try the attached patch? I???m not going to argue with the MI code about the atomic_testandclear_int, but instead revert the new if_epair code (in stable/12 only, of course). > >> > > > > Trying it now. > > > > Patch reported: > > Patching file sys/net/if_epair.c using Plan A... > > Hunk #1 succeeded at 2. > > Hunk #2 failed at 37. > > Hunk #3 succeeded at 61. > > Hunk #4 succeeded at 78. > > Hunk #5 succeeded at 201. > > Hunk #6 succeeded at 517. > > Hunk #7 succeeded at 540. > > Hunk #8 succeeded at 701. > > Hunk #9 succeeded at 791. > > Hunk #10 succeeded at 809. > > Hunk #11 succeeded at 862. > > Hunk #12 succeeded at 876. > > Hunk #13 succeeded at 904. > > Hunk #14 succeeded at 932. > > Hunk #15 succeeded at 947. > > Hunk #16 succeeded at 975. > > Hunk #17 succeeded at 999. > > Hunk #18 succeeded at 1010. > > Hunk #19 succeeded at 1061. > > 1 out of 19 hunks failed--saving rejects to sys/net/if_epair.c.rej > > > > Running make buildkernel -DWITH_META_MODE anyway to see if anything > > else goes wrong. Half an hour in so far and no errors. If it fails > > I'll delete the altered files, run svnlite up again and try over. > > > > Thanks to all for the speedy replies! > > I???m a little confused by that failed hunk. What version are you patching? The patch should apply cleanly on stable/12. svnlite info reports Path: /usr/src Working Copy Root Path: /usr/src URL: svn://svn.freebsd.org/base/stable/12 Relative URL: ^/stable/12 Repository Root: svn://svn.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 371773 Node Kind: directory Schedule: normal Last Changed Author: royger Last Changed Rev: 371773 Last Changed Date: 2022-03-23 06:53:19 -0700 (Wed, 23 Mar 2022) The kernel compiled and installed without error. After sending this email I'll attempt to reboot. Thanks for your help! bob prohaska