From nobody Wed Mar 23 03:23:09 2022 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4DE2A1A2725F for ; Wed, 23 Mar 2022 03:23:25 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KNYbJ22llz4tpY for ; Wed, 23 Mar 2022 03:23:24 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648005797; bh=rGPXguB//fkmLXJyT9QJ1WO9eQmmhRopLVu3KEu4VB4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=LqKSYwHTwRNbHuwZ90TVBzQPjt+HMUHCSOR5A1O5vOLegOqCmMuC5h9ckl1tkcGZEfc/YOhiJzQUJg1aR8KiGCrSWY/g3czCtdaKVttBEAtIqRluLF3MbF9S6hnfDOi3Fg08l5nGWfiUkQbb5y2POt3WzM4ZhUkkBpmWGApWPMoKzP1eZG1/RZnSmcbjflp6cgLVwPri1ji4XvQrBy0yIzoiKy9H3pZ9hruoLfDZp8LIaRQAMsZeahAyjr/79V6qEprRbri+sAFs0mHvc1KKqW7eVp0joXiLZZxZJy3GHkLO8/x1ZQZ5W4+0caAmEvOK83rSH6h7BZDo0YmzLJHWwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648005797; bh=a5jMcdAVTz9NbaHXUeS+Mt49d4U40tHeKsjfyJbu5kk=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=RSF0BvQ7c+gpFPIdz0dwb64y9lsxxdn7onRLrx6N/kZ/M/MOiGNzi1x/R5V3+1VJyntw44Yp4EBsWhtYcSphY1HY8yCasm5uMRaCcqfBpq2StfM0TNGlfBh8eyRn2WfaLhmd1/c17r21Sc9a73bQSrh0swoEOceVbRodh9fCcQ7pdJdFPrVMXdbrBhtWJAfIlS6NPvO5XfdA4jvC7Bxma19j/UaTSdePn7gz1r1RzoQptRKkMUUNSfoNEqSWr5jWNZCcczgtnP9Ng30/la+D/Hcx38xhfTb5CfkD4Q7Y5kPqy/W9+3tPZGgyRYgi+xntHRucq58HH3oFZ9fiv3ZP/A== X-YMail-OSG: yFbjOAYVM1nsuVIPU5_Il19neK1PhNP03tBt141ksWdkWTr4EOc85jktKvd1RK2 Jl6Bmo4FJEWHldUXmAoHksMvJ_TxsqGJ0QBmetD1WcGTWZV.z8z6x96GkVMVFBDBa187gUxG0YwS sTs63kLkngKK8NWvdvvazJEi0yRAvCNSlzzYMDokbZ8a3z10Ymqd7ofr.Cumb6lSPdAidtt9yGU1 wcMulOC0DjWqO3ugEjrUC11rMIKQG1ZSnH44bszNu4HEEvi_rd.b6gxu9pmxn9ospCqKQziWMSnJ jKNUax4anMCyXp9nUTrequz30yl5kpkoMRppe_YleCJZcueBEUjOMMTu3JRaNRQLwDee2hBHlEW3 UVaMYXvyU8zUcuahdNX78FSTDLF3kqW7Ra4htU_nKLr0Rw3O1gOVUydB6RWc5z87gxz4TBPBcCQk sxG0Ghh3kCLlQHJ0NldhQ8ZrkQmyDonN79rk2I7_.UD5lqYGkVa6MQH5Bi7u6eTAN1TUBXMpd3cq 0kFB4fm.JE4x86Qbgx2GXlPitDcCQ3ZDLqc93e6aUqX63jefacl7mmi5_ZN6M9NCNZ1Q0DEaDQsj 3_ZkPduRW_iEN99bZyRV.5agHoVJ5AkCWD.2UUHQ9._yy041qpQ_4ZMd1w0cLJQZ_oKF4NFjkD20 Yh0iM23gnO7q1QDsvM7wTj_XrrH5t8vf6aAE1vqSQ1Xpo2wrOmuQaamuw8vfbeuYQHwhAawjDB9. srA5bfq9pNFdQKDMDHBNkVjTTuYUZV6N5WuTueZ.wf6r_MK3J_4Fc0B7KFfrtPO_bdOPf5K6ZKN9 Zahpqv5p6xDsKZbIFkZEuQJY6BVikZyR4_dkOT9OnFyY3NAKyzUW5qTrTswtqa8uFwrj.oU9_GAU M6kmdbpp_zZdtTYWUFdg5nAhaE0zMXor0c9JHCRRpZufcQW.16mCdd_a5Kj6WJlPKbpytUkdRaCB 569VqKDkahlbQcXx1RlODmGE9lkrqKAOmCRAUkd5ZpdGu9NQKVnZuu7C4cSNmPMGZhM43q3DHY69 FGzbbFG6DbJqRdIdI7ckMhMqaxiBBgWDzMS8uK.rmWFw.DLQoYIoHAISfHCmGRGUvLaoG3kLrzRK JiN8i_es.rsJaWrc3Mp7UJccI8y_kNEzSW2NaBgYViXd3JvLzuPvisoQVHCAfbDhD4FePEfX.q50 VDFhVGJu7RKvYdiy2MZjL.j2VWM7WJfzNT7XqyyA6BcxfBCV94A8MFLgpmVNt_DgFvtNsdzuIgh5 eeKdChmJoGZYQz9IPS_Mhzbj253z4fmd1M7STDb79yQ6R288SKEeo0159x97s5IxJrViB23dK28A tQr76GdAPRdTVZf6mOPfN8HJ2CHNfLMZTO7prwznEtrqRAh3xKowM3wkEQ.D6EEc7ry8eUDkuB3g mC.Qc5SBKZOMCrRekjR4Zb6_PLwmihpqsJlqWNbkbbIVa3Gs8LMGEFewns38WAYcrxWvM54g3oj1 jP9pEQ1BXWQGFlpRlBolsybzmSOy7_nkMZaqNdRJ2kRj0CSAVnI5jXxfy6qM5b1S2X7iMI8ctEEP Hm693IxXaCvCWM0K8Zn1vBlSfggo1gTKv_iLL27bV.q6EjLEx0i8rCvq83pHSmbYwA1ci1zIkS5d 8lVLUDh.GRnV6FAvHFCZ5XxVHK0lGI017Ovb.j3zZeA9Rwkj0BvUk9E4XoClinzCT7hToL7wbEII KUxTePExfuf_iZGuzs6VFcE_3hRKWO_Jx7MXmTWLWPCII.iOMJAuAmnBXUhG7SKN2MEoc3u3HxnS E9HaJ6c4k8bT4jnLIhtn3foXlpkv3aDdj1bNyl_matYKl2sNfQrvTwot3qSfLU8ft9970RIb2xNl Tqna.AdSlBgFf6tPVpV.U8ky3Su8IzC8UMIM_Up5AOkTVv2ffpiCw01xSGr3Y2rMXq6uR1JyagE2 ytpVQjdHW9DobPceuxWYmA3nEfsyRb4zv6GiwRiWeollaSberECpFyohvgyUxf98heBJx09gFPO4 AFqFW0n0Iq0n8F7J148iBMA4QrTSSKWNH9jP19HleOxlZS.cfzlbuEjSuFi1_gXHFZeVeHntXxry GwAYecSzjgDdW05hRiGeUI.pmme_FToZYD_DDE8kA53gM9VIyM.0hbkfyKx2Zy1e2UiDc0f5zxXZ PEIGxPp0F61OMrtUL.o_AJ0MVg6h0noEIjCkwW6bzcpRzGVt5iYwffegmdy0T8slgsk2khxAJY87 bv8icT_lmn6yHVwMVJYG70bpz_A0.1pZsUUpT.sb2ZpzE81dNLRCwBsr0HJZJSBy7ne3qJUL0e5I bPhJHrX8IG8pimh0NQPUMn443GeBdCrsc_J28GePtxiZsBgQdHTxU0oA9Ju8- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Wed, 23 Mar 2022 03:23:17 +0000 Received: by hermes--canary-production-bf1-665cdb9985-6p9bt (VZM Hermes SMTP Server) with ESMTPA ID 502e8a778bd1892701a24b248ab8bc2c; Wed, 23 Mar 2022 03:23:11 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: /usr/src/sys/net/if_epair.c:181:6: error: ... From: Mark Millard In-Reply-To: <43A846B1-4AD4-48C7-ADAB-82D1CAFF6DDB@yahoo.com> Date: Tue, 22 Mar 2022 20:23:09 -0700 Cc: Free BSD Content-Transfer-Encoding: quoted-printable Message-Id: <3049B57B-CDEC-4EE8-A33D-97B833BB4A78@yahoo.com> References: <20220323012657.GA82109@www.zefox.net> <43A846B1-4AD4-48C7-ADAB-82D1CAFF6DDB@yahoo.com> To: bob prohaska , "kp@freebsd.org" , "grembo@freebsd.org" X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4KNYbJ22llz4tpY X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=LqKSYwHT; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.65.84 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-3.47 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-0.97)[-0.970]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.84:from]; MLMMJ_DEST(0.00)[freebsd-arm]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.84:from]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On 2022-Mar-22, at 20:16, Mark Millard wrote: > [Trying again after getting material from the wrong > commit the first time.] >=20 > On 2022-Mar-22, at 18:26, bob prohaska wrote: >=20 >> A Pi2 running=20 >> FreeBSD www.zefox.net 12.3-STABLE FreeBSD 12.3-STABLE r371495 GENERIC = arm >>=20 >> stops buildkernel with: >> --- if_epair.o --- >> /usr/src/sys/net/if_epair.c:181:6: error: implicit declaration of = function 'atomic_testandclear_long' is invalid in C99 = [-Werror,-Wimplicit-function-declaration] >> if (atomic_testandclear_long(&q->state, BIT_MBUF_QUEUED)) >> ^ >>=20 >> Not sure if this is specific to the Raspberry Pi 2, it didn't show up = on a pair of Pi3's >> and a single Pi4. The system is still using svnlite, info reports >> root@www:/usr/src # svnlite info >> Path: . >> Working Copy Root Path: /usr/src >> URL: svn://svn.freebsd.org/base/stable/12 >> Relative URL: ^/stable/12 >> Repository Root: svn://svn.freebsd.org/base >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> Revision: 371771 >> Node Kind: directory >> Schedule: normal >> Last Changed Author: 0mp >> Last Changed Rev: 371771 >> Last Changed Date: 2022-03-22 15:28:40 -0700 (Tue, 22 Mar 2022) >>=20 >>=20 >> Didn't see anything similar on bugs.freebsd.org, if it's worth a bug = report or >> there's a workaround please post. It was built using WITH_META_MODE = if that=20 >> matters.=20 >=20 > QUOTE > author Kristof Provost 2022-03-17 = 02:35:13 +0000 > committer Kristof Provost 2022-03-20 = 00:25:06 +0000 > commit b1a3f8dccb6203036b7ee81201fd5b5a8de36f0d (patch) > . . . > if_epair: build fix > 66acf7685b failed to build on riscv (and mips). This is because the > atomic_testandset_int() (and friends) functions do not exist there. > Happily those platforms do have the long variant, so switch to that. > END QUOTE >=20 > broke things for stable/12 by adding the atomic_testandclear_long > usage without defining it as well. >=20 > It goes like this: >=20 > path: root/sys/arm/include/atomic.h > Commit message (Expand) Author Age Files Lines > * MFC r341787 by hselasky: Implement atomic_swap_xxx() for all = platforms. Andriy Gapon 2019-10-24 1 -0/+7 > * Remove arm-specific implementations of atomic_load/store_xxx() = now that Ian Lepore 2017-12-20 1 -27/+0 > . . . >=20 > So not updated in a long time. But for armv7 and the like, it = includes: >=20 > path: root/sys/arm/include/atomic-v6.h > Commit message (Expand) Author Age Files Lines > * MFC r352938: Ian Lepore 2019-12-07 1 = -100/+256 > * MFC r341679: Michal Meloun 2018-12-14 1 -1/+1 > . . . >=20 > Also not updated in a long time. >=20 > sys/arm/include/atomic-v6.h has various "atomic_testand" > examples ( sys/arm/include/atomic.h does not ): >=20 > atomic_testandset_32 > atomic_testandset_int > atomic_testandset_long > atomic_testandset_64 >=20 > But no examples of "atomic_testandclear" >=20 >=20 The slightly older commit: QUOTE author Michael Gmelin 2022-03-16 22:08:55 = +0000 committer Kristof Provost 2022-03-20 = 00:24:51 +0000 commit fb3644ab2afe777fdd2539bc996a390443f052f1 (patch) . . . if_epair: fix race condition on multi-core systems END QUOTE has a use of "atomic_testandclear_int" as well. =3D=3D=3D Mark Millard marklmi at yahoo.com