From nobody Wed Mar 23 03:16:42 2022 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0AAD11A25D16 for ; Wed, 23 Mar 2022 03:16:57 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic317-21.consmr.mail.gq1.yahoo.com (sonic317-21.consmr.mail.gq1.yahoo.com [98.137.66.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KNYRr0j3cz4snV for ; Wed, 23 Mar 2022 03:16:56 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648005409; bh=UdL+wrZPaQ+mPJCcLVdOeC/ZoES5RwbIs5kFsKCDgak=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=JBhosGJo4YlycGzL85IkLns/yYSKdCnl18CHxyBFH+F06xGAZTtjJ+atvD5XygfmkqBzC5Hzo8IaPPO4jIAzfss4S5MudmorqUn8OnMZsyI9LJv8wMg7njTIj3+Ge3AZe45vB5ixd/HEAz8G442/55ekSf/VYzp6FaGqciLSZqZlTH1ofm66XSWx33QNJm96AqXXO7LdDXZnhw8InDZccBmGGuLZib+KWT7uI7iXQTE7hDlXExFRBf0A+kxAcrU07Z+OJH//e0A60DjMQmUxCgX+cFnwZeYHMZ588VOVuacKUcYbaSmh1mWaFTNV7U0tq629A9BZQF1Mxdclw9P90g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648005409; bh=SOGV3bFY7o+uU6JWcYotIIpaAPJIabscUySbcBVEI7v=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=n0mTvn6FKlqCT8qT7hOS+jRZfeYscZzNH8xH8xwUv07n8S9X1D3Qvhdms3iVpcR/CR7lXrutYZJuooubP4jjYZMI5LrBH0rkuxqgmTZ4TRGQ+396pVQFS075X8922XURn+iUUGkf2WGq3f1MTLAStqYkBhBSSzqoWSdrd/X+lTScyyVWCAosPyGGafbs0ngl59z1QFuRbFT/ITE03u/qBT39WHSCC/TaJVLFgIt4XBRdH+5rxwzdN3scFKR3tAtqmchlgKJEhswHfSwPsSVly7mtF8p1saK6kTIpJE9hu1xJnk32fJSRtPhXIAyOE+2ksZ58moNHeDp3n/sxa4mf/Q== X-YMail-OSG: xwlqqVUVM1nPIWhvCrgXHy.QBBV3nmrFp8JAjkibLhXwMEyLDKO4wqomVRb2CfA nsbhjZ9rNK0YurQc2H7WCN9ywgfTjKVFNLw31jxZEbwnFq7_Jul7Li.rOA1FGu0wDFo6mKiwYatA zlCXNM2Cv4HBiB8M5j8XjiXv_oRZGXElzspPFRrBlCyT.597wvZjzmNhR2tWyCtV__VyeVed0Q8_ yWIAyCtAIfJhPfgosgGU.tfbSHHZsoWW5eknf9UAp4WAjD9u85NpPO6SPW_JB4Nn5ywVowc58Igd o7a7OAB0h8wZHEy1j4jvdaOw_CrB0AAcAIU16UN0gL1En_QKHXZGmj0WJ8t.ka09hhJFL9C6nQjv DQwzH2h1mZ5yjtbW82tUmSH9ItLao_QIBn0XuqF69KNpDXQ9t2yPfJI2YTQnnNfTrEv86ZOfDNKR hwEIXK4RQJo3waoJQlgFXNBas4QarGn.ZOXxw4R9212Oo7qgw4QJlzCTaqFWwQVSOoo_byuDIRCv Iub50b7eu0LVpj.WdfRY3zhnvOVhwmw.tbebXGSZ3TpVXcVF7.lvLQbcRtXj1nXM_u3XHH5dkXU9 GJ9M9hCqNtvhK9xBZJ37ZCxI.6j3rdZfkpZZEOSr729e_intBbdsoJzugvQbHt4.buYUQhb5J7U5 A8hn4bgDXmYOP7TxLMm9V0kOhzxQOPouVeFCBdlqMtCvsRw8_4lzz98a3XUw5vLNNnwVpNU9Ar7r zLVcn9LSkZeQMKbycVaoEm4TR.JVjj2PxxH8FUxhv41ugGPjh0o58z8RAkEMHPep6.A.OVp388pF TraLzuLe0B0tD0FoSkuF5ShoPdzoopCggnOfv.9sCAx0WAOHlja0zsmePrJ_3M2s_iTsDaKnmdYC OXNVW.keuXylZdUpuMacmGUfs7A995LQnXIwPMB6I_y2Offg.ALLp542NOf5CNPN4X05vsjDi7jn QOdPJDsW4gtYv2GeCb5aCgmQkgSAuvAQ1MgBK5bdYKkGtw.vw01Agcj2Ly8UPTvDza5Sips_Vcef wdeR_EkF2lPxfJ9OZG16V0HJhBzXSVuxqY1jkhaR_MFaZKEbAWSjVkCP8AwSldcL.Vk3scImUnyp 90L8ry8JsiB8Pjxz_zjqqicGAJJfM4P3qBeCC5Gh_J1YbLXRDBXdbFmlOoBanxmdKcsf82EeyD8e mOKMFq4p8YECFOoiuUGgYFlYP7gRAGUr8RAXclXr2Jrw22dz48qRhQBLQLERoKLSDlHoLoz2k9Jo NzquObrzw4uxjPqY7A3LcnUJmwycjFUTNZ.20dvz0ODH9A2wDipdYh9icoBnnLDG0SHcCOKu8W_R SC8dHM5rxIUFEP06fZe6fceaCYenb_DRdVXUdieUwAQQBgMGJ56kWU6iha9binrihzfZwXyzi1Hu 5SeM9IS0y1XL_sxe4zD9OqSTovkkop9n7NE2KeikDa7iKUgbXYG1q0Y3ef.JQL0XXEUCU2HWtb5T 0NbebBAp23Fl1o4EPBZ3B000uzdLqcK1O4k20Xfah2JdHXYBig28NENAWieNUJCg2YUAuTgEfD3r RCyFPBhkE2NmVAAa9Hgnrpsne4ant3NYoQ1AVMuzF1F_v60IrCa_PSQY_LnRhZemU.ohkeM7SNJl 4foXwOXCvpM6yi_brqkE1fflmB2wssPaXc_IuuFHocayCa9dXo.dbfbvthyd.yq7sAY98TkFk4Rs uLOt3dJRay51qbUxhfWCCLfxOBhql2K59I9TMyhTQd9nTxlVI2X3b3dppfkhQ4zW0dwQbdoC96.r zZCyq0qUtbkbjfn.2vsYdM9FKGafRDRQQTxW8miQcaZmAoI8uFVOrE5pNdHT_16ilHffdjQg6IpO G3ul35_0icggI6vNc5rJVCn7hkD9_27XegRacYHiMNqCSEBaz6oi8cahv.8246rTuJCmkocEZOB4 FmFAA4isA6cUKb3va0epYxyZutZCn3dA83AZ79u6vlNgsVQE0tbY_OZC5og6FfeKFvxx8jF9TOGV 0dDkAkJdFCfPz2m7DG1s4.3n1JVclJEk6HA8h.LPJw_qv4biWI_cF.ILWpPiEnuC.6OCxKifqQ2D pQRoV8p_rSI_cT4LE12o_4.VgfdaLBnsVIwzbmuTQDSN0SQO.bIgMatSaDQwTJ5nP23oewvlj2lm 4HZNKGn9gElLuiIanXQ7IYnkq3n1mOU8sa1W5v9GJeTuMuK_zX9NFne.oGOtvkt0j8nh4dTj6mYZ HPYfZ4Cajmg5WyVUJUq342QXWzzx9BLmW9ye.Voku.E0RRpbx5yjGIbx1VxfCAjhZHfdfSiVlfPs 4q4OoNbGymi6hP1vwZW_OTXecIhz_UclDxIZXuz7_Le21ZbLOjIPG6VS6 X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Wed, 23 Mar 2022 03:16:49 +0000 Received: by hermes--canary-production-bf1-665cdb9985-zm65g (VZM Hermes SMTP Server) with ESMTPA ID 30d29adc6ff11769a47b75a2425bfcf3; Wed, 23 Mar 2022 03:16:44 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: /usr/src/sys/net/if_epair.c:181:6: error: ... From: Mark Millard In-Reply-To: <20220323012657.GA82109@www.zefox.net> Date: Tue, 22 Mar 2022 20:16:42 -0700 Cc: freebsd-arm@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <43A846B1-4AD4-48C7-ADAB-82D1CAFF6DDB@yahoo.com> References: <20220323012657.GA82109@www.zefox.net> To: bob prohaska , "kp@freebsd.org" X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4KNYRr0j3cz4snV X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=JBhosGJo; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.66.147 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-3.47 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-0.97)[-0.974]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.66.147:from]; MLMMJ_DEST(0.00)[freebsd-arm]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.66.147:from]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N [Trying again after getting material from the wrong commit the first time.] On 2022-Mar-22, at 18:26, bob prohaska wrote: > A Pi2 running=20 > FreeBSD www.zefox.net 12.3-STABLE FreeBSD 12.3-STABLE r371495 GENERIC = arm >=20 > stops buildkernel with: > --- if_epair.o --- > /usr/src/sys/net/if_epair.c:181:6: error: implicit declaration of = function 'atomic_testandclear_long' is invalid in C99 = [-Werror,-Wimplicit-function-declaration] > if (atomic_testandclear_long(&q->state, BIT_MBUF_QUEUED)) > ^ >=20 > Not sure if this is specific to the Raspberry Pi 2, it didn't show up = on a pair of Pi3's > and a single Pi4. The system is still using svnlite, info reports > root@www:/usr/src # svnlite info > Path: . > Working Copy Root Path: /usr/src > URL: svn://svn.freebsd.org/base/stable/12 > Relative URL: ^/stable/12 > Repository Root: svn://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 371771 > Node Kind: directory > Schedule: normal > Last Changed Author: 0mp > Last Changed Rev: 371771 > Last Changed Date: 2022-03-22 15:28:40 -0700 (Tue, 22 Mar 2022) >=20 >=20 > Didn't see anything similar on bugs.freebsd.org, if it's worth a bug = report or > there's a workaround please post. It was built using WITH_META_MODE if = that=20 > matters.=20 QUOTE author Kristof Provost 2022-03-17 02:35:13 = +0000 committer Kristof Provost 2022-03-20 = 00:25:06 +0000 commit b1a3f8dccb6203036b7ee81201fd5b5a8de36f0d (patch) . . . if_epair: build fix 66acf7685b failed to build on riscv (and mips). This is because the atomic_testandset_int() (and friends) functions do not exist there. Happily those platforms do have the long variant, so switch to that. END QUOTE broke things for stable/12 by adding the atomic_testandclear_long usage without defining it as well. It goes like this: path: root/sys/arm/include/atomic.h Commit message (Expand) Author Age Files Lines * MFC r341787 by hselasky: Implement atomic_swap_xxx() for all = platforms. Andriy Gapon 2019-10-24 1 -0/+7 * Remove arm-specific implementations of atomic_load/store_xxx() = now that Ian Lepore 2017-12-20 1 -27/+0 . . . So not updated in a long time. But for armv7 and the like, it includes: path: root/sys/arm/include/atomic-v6.h Commit message (Expand) Author Age Files Lines * MFC r352938: Ian Lepore 2019-12-07 1 = -100/+256 * MFC r341679: Michal Meloun 2018-12-14 1 -1/+1 . . . Also not updated in a long time. sys/arm/include/atomic-v6.h has various "atomic_testand" examples ( sys/arm/include/atomic.h does not ): atomic_testandset_32 atomic_testandset_int atomic_testandset_long atomic_testandset_64 But no examples of "atomic_testandclear" =3D=3D=3D Mark Millard marklmi at yahoo.com