From nobody Mon Jul 26 21:43:25 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 634B612DE28E for ; Mon, 26 Jul 2021 21:43:34 +0000 (UTC) (envelope-from soren.schmidt@gmail.com) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GYYMV1x53z4q58 for ; Mon, 26 Jul 2021 21:43:34 +0000 (UTC) (envelope-from soren.schmidt@gmail.com) Received: by mail-wm1-x330.google.com with SMTP id l11-20020a7bc34b0000b029021f84fcaf75so414178wmj.1 for ; Mon, 26 Jul 2021 14:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=5jTS4an9/Pe4tUC+utQfSyMd23yu56Bfoz6k60obbgM=; b=F7jOxrY0iCqJSwDXx9RvXoVwMTlDxw534orNPUf/VgEbmLePAxtZKa0EZbcM/7yJjk 09/FGoi26VCs3GPpywIzr8cyr0ZqD7ybraUt6Vfbte7UosyawlJP1Olxa7TpogD0RqDY VrE6vA1jeRro88+YjCkRDAxqbLOjgLChUPN4H2c56Ra1jVxaktbVadzPjOWJVDhhBftH bYt0mu4nEH3vZUsfAriYbKS/QB6mj36hcJoobVBOz9b+ew3tuqRtZf7mm84DH9uuaZC4 IEE8bpBlQaVH3ldaf2swb8Kdvx11jB7M8ECHB5+4A51TxHq0wHRj1AlSLpk+Q+2+Avvz As5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=5jTS4an9/Pe4tUC+utQfSyMd23yu56Bfoz6k60obbgM=; b=GvUhQK8T5vhc4OZ7a4ToBua3B/+K6k6VjN/M4dCp05LOXRA0Po1UWmR6P10Gg+sL/J TUluXBrWYZMIjYj1vIBNRpvp/SaV3y3uXBSlG0QokWR2fstOUkSGvX8Hw8GikFlbX9wF Yiok0mMQpjvqsSzQUxxf/gb4r0tnD7uJUxi4FPI1TLSr4tX0cKRDXONojMQXPKzuaPK0 ATGarbwPlS4B3SBpMY6Q9MK9ubnHYoXwfaLMrKXY9JQHjJK4iWsN3G9IO/OD6L5UUW5K /6VGoLJKorbULYm63iKeDzb8ciXNeaIc5IV7xIARotIOyUxZGJSkekRb3FWEzlB7xBsX XX4g== X-Gm-Message-State: AOAM530b5gOJF2lGL8ZHWLxdB47RUFnSi0fyvmD0amTEdtjTrHP0/CoZ wNMq+WaKw8Gcj+ZSdxwAmIyKBNrHI8w= X-Google-Smtp-Source: ABdhPJxgTibg0kKxqdYyoRsOnq5FykulWvha+LBWhHhDAuQTm1DxDw7NEocZl05+XVP5x9tGJDXoTg== X-Received: by 2002:a1c:4409:: with SMTP id r9mr2773467wma.150.1627335807013; Mon, 26 Jul 2021 14:43:27 -0700 (PDT) Received: from smtpclient.apple ([85.27.186.9]) by smtp.gmail.com with ESMTPSA id d5sm947691wre.77.2021.07.26.14.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 14:43:26 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?S=C3=B8ren_Schmidt?= List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org Mime-Version: 1.0 (1.0) Subject: Re: Quartz64 (RK3566) clock driver and patches. Date: Mon, 26 Jul 2021 23:43:25 +0200 Message-Id: <1C01DBB7-778C-431C-A980-AAF56F0DEA4A@gmail.com> References: <20210726195037.59165880a49ef24d1cb89833@bidouilliste.com> Cc: Free BSD In-Reply-To: <20210726195037.59165880a49ef24d1cb89833@bidouilliste.com> To: Emmanuel Vadot X-Mailer: iPhone Mail (18F72) X-Rspamd-Queue-Id: 4GYYMV1x53z4q58 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Permissions fixed all have access now. What do you mean by more context exactly? It is just a new driver for the pmucru and cru parts of the rk3568, nothing f= ancy=E2=80=A6 Btw I need to add Schmitt trigger support to pincontrol any suggestions ? -S=C3=B8ren > On 26 Jul 2021, at 19.50, Emmanuel Vadot wrote: >=20 > =EF=BB=BFOn Sat, 24 Jul 2021 22:17:06 +0200 > Emmanuel Vadot wrote: >=20 >>> On Sat, 24 Jul 2021 19:46:20 +0200 >>> S=C3=B8ren Schmidt wrote: >>>=20 >>>> On 24 Jul 2021, at 13.56, Emmanuel Vadot > wrote: >>>=20 >>>>>=20 >>>>> On Sat, 24 Jul 2021 13:26:07 +0200 >>>>> S=C3=B8ren Schmidt > wrote: >>>>>=20 >>>>>> Hi=20 >>>>>>=20 >>>>>> As promised, the clk driver I did for the RK3566 used on the Pine Qua= rtz64 board: >>>>>>=20 >>>>>> https://people.freebsd.org/~sos/Q64/ > >>>>>>=20 >>>>>> Included the buld script, kernel config and u-boot I have used to get= there. >>>>>=20 >>>>> That will be much easier to review on phab, or even github PR or git >>>>> send-email, basically anything else that this raw diff. >>>>>=20 >>>=20 >>> So for your entertainment I just uploaded the patch to fabricator, howev= er I dont see how that changes anything but the colors :) >>=20 >> That will make me look more closely to the patches :) >>=20 >> Thanks, >>=20 >>>=20 >>> -- >>> S=C3=B8ren Schmidt >>> sos@deepcore.dk / sos@freebsd.org >>> "So much code to hack, so little time" >>>=20 >>>=20 >>>=20 >>=20 >>=20 >> --=20 >> Emmanuel Vadot >>=20 >=20 > I cannot add comment to the review : > You Shall Not Pass: D31299 > You do not have permission to edit this object. >=20 > Looks like you added a custom policy : "sos created this object with > edit policy "sos (S=C3=B8ren Schmidt)"." >=20 > Please remove it and also if you could upload diff with more context > too. >=20 > --=20 > Emmanuel Vadot