From nobody Tue Jul 23 21:46:01 2024 X-Original-To: arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WT9h73Ryqz5R0QF for ; Tue, 23 Jul 2024 21:46:15 +0000 (UTC) (envelope-from tomek@cedro.info) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WT9h669W9z4VhY for ; Tue, 23 Jul 2024 21:46:14 +0000 (UTC) (envelope-from tomek@cedro.info) Authentication-Results: mx1.freebsd.org; none Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-e05ed8a5526so5840224276.3 for ; Tue, 23 Jul 2024 14:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cedro.info; s=google; t=1721771174; x=1722375974; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dUJpEyV2M1CksJFPT3rpRgH8Ohd2yO/5F9xO9zqTybo=; b=e2k4cxGr3vY7fmXynhCXroHNCBKjt81O+w/b4Nrlu/sIHRJvKFgaVo1SScV4GxcBS/ 2VJ6O8gyuRnhU1qhx4DNBlZMY3ZDizpdJCFFEgCS5IjrdM7RkZQ6gzDHhxFP3oKaV94e 3IU6e5sVnxnh1aLOZPMsDCOhX/DVA/Jfd0t2+cXFgRYQaodPK2IK1Mo4aQEiAvwaEJLD qz3kLUGfypK5KmeNsa8CXohVrHN/19L68lLDOr08M22e8rtUoulpmoVIE3D1yXrPWtEN gJpvD6HbriSFk5acjsDaUsUtXYzem6hDQ2QPCZhPvpJl4wuZtu/lgv+h7y85wv+n9r+J R2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721771174; x=1722375974; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dUJpEyV2M1CksJFPT3rpRgH8Ohd2yO/5F9xO9zqTybo=; b=pNa5OUzIZzTqDueJq0bZMQB3MYv8FKTORVxAhxjg1jLQLKNXx6mQB34Cb/gGoqveIi sThvZtsjdYGKCQ6JKdasHEKq3e9HikWdQg3DgedXdbVh3wP0mEbBJZlCDvAYsauhjOKf IO7C3V2y3w0OKkbjohCleqzkjCDt+XpZoDaDnf9x2biN0btD75TW/5MIExU0u7Wo7fAE myH9S8sfmVqyj7s3CZD9vO8//zKYEpycVgPFXxhc+PhssNN10HRc1hd3MZbfpmLniC85 XOt/IdTeujelz1y8OLZE5HvgWKDiAG7LcqztlbF/u4aZiRJlCBpHBoTCBOl43K7gMJSY xkCA== X-Gm-Message-State: AOJu0YyhUxWwVQYzGnWCE0mbh164odfIYZjpVaWr8Ltqi3CLwuMsPhbO WmfUWrs9I2dO8LmI5bAeOfXOwMWEc2q7qQxg2Z/IKeFrIcT91xgMVQ1Yl8b8sQ== X-Google-Smtp-Source: AGHT+IEUaSkhyER7T9xIrDVBGAovtO1u4tLwp3MyPalc3iinoAbY/j6PEDS699mNZEOalRwksbSHGg== X-Received: by 2002:a05:6902:1202:b0:e02:b5cf:97ac with SMTP id 3f1490d57ef6-e0b0e37e16amr459227276.3.1721771173793; Tue, 23 Jul 2024 14:46:13 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e0b0eb32552sm43182276.44.2024.07.23.14.46.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 14:46:13 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-65fdfd7b3deso60356657b3.0; Tue, 23 Jul 2024 14:46:13 -0700 (PDT) X-Received: by 2002:a05:690c:2e0d:b0:65f:86a2:b4c5 with SMTP id 00721157ae682-6727ce1e0dcmr2634477b3.31.1721771172605; Tue, 23 Jul 2024 14:46:12 -0700 (PDT) List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@FreeBSD.org MIME-Version: 1.0 References: <9bbb12ee-d5e0-4e9c-a832-bbfe5eea0ba6@FreeBSD.org> In-Reply-To: <9bbb12ee-d5e0-4e9c-a832-bbfe5eea0ba6@FreeBSD.org> From: Tomek CEDRO Date: Tue, 23 Jul 2024 23:46:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Default NO_CLEAN=yes in 15+ To: John Baldwin Cc: arch@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WT9h669W9z4VhY On Tue, Jul 23, 2024 at 9:58=E2=80=AFPM John Baldwin wrot= e: > > The buildworld and buildkernel targets include a "clean" step before buil= ding > objects dating back before my time to 'make world' (I haven't looked to s= ee > how far back it goes). To permit incremental builds, this step can be sk= ipped > via NO_CLEAN=3Dyes. This step is a bit unusual in build systems however.= Most > build systems have separate commands for building vs cleaning (e.g. 'make= all' > vs 'make clean') and over time FreeBSD's build system has gained dedicate= d > clean targets as well (cleanworld and cleankernel). For myself, I always > use NO_CLEAN=3Dyes when building worlds and kernels. If I need a clean b= uild > I use the dedicated clean targets (e.g. cleanworld) first. In particular= , > cleanworld/cleankernel are far more efficient since they use a single > recursive 'rm' whereas the "clean" step involves a full tree walk with > nested make invocations of the 'cleandir' target. > > A few years ago, Ed Maste added a MK_CLEAN option to src.opts.mk to as a > WITH/WITHOUT knob for the "clean" step similar to NO_CLEAN=3Dyes. To pre= serve > existing behavior this knob currently defaults to on, but I know Ed's goa= l > was to eventually flip the default so that NO_CLEAN builds would be the > default. I would like us to do that starting in 15. > > Further off, I would suggest that we remove the "clean" step outright, > perhaps in 16.x. Regardless, we will need to update documentation to > prefer the clean targets over WITH_CLEAN=3Dyes if our docs do not do this > already. > > -- > John Baldwin +1 :-) --=20 CeDeROM, SQ7MHZ, http://www.tomek.cedro.info