From nobody Sun May 21 21:24:51 2023 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPYWm4hqVz4CVXZ for ; Sun, 21 May 2023 21:25:08 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPYWk4D59z4HfM for ; Sun, 21 May 2023 21:25:06 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=nKwmG+9g; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.31 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684704304; bh=dLqtATxCciFG/1CIlFk7MWORQ8kwv3qW5ac7RXuJ7Ig=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=nKwmG+9gDrHfBV+KZPYhZUX8sZSNYWvwI6A6/sPEXmuFkP/CzvHLUp8pkVs7r+tM0AP5tw3052oYrmkF+SGegmbMIK0rlMql6kwUfWuVM1YB4q33waheHaL+RG4Cz5jXZ/ZGeNWpiZ+ogx1+KfgKkVNrB8G64MBAuBwMscerbnuWPWcbajzARYSK/SGlSHiQq3qn+DjDKI5ed7PEJB485mcIFCfzOAMRrhIjaryVuPHPAe+F5dQHS2nmnl1WCxAW2I43N1If6JuMxXeSVrxjKIOXOvBKVbfNMYU+C+ZhaDOyYZtPO6LjXEHwHNPbml3I4R2PO3z7vYdHTj7sfSoguA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684704304; bh=BizKS6c6Uzn4ttULb+5d6bQcMpAHyJELVjay1TuzdOn=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=P+u5elo/rvtzph1ibjZhfFhokQUmGcwTjshcV/hSZLS2QYZpz5QLRApZ2jwfg13F5R6z01AyXZZxyaA5HIXLL0bWHErxTMv8IuWJYMgJT7fpQeoUo7zryXVzzxdt37kN+Bm5t15Hk/z5ZXn9xHDoV36j3sD60LdRq30nLXHLM3lNMvnsJVSANKmgxD7V7X9agd/djhCauTlKY7ZQuEZf89GBCkbxD6iZ7IsC1Twd8SAksyKc1Ol3gISv7ivR34ymML08teeD2JPJIMKJgX5aLWG95Wb35c+r6VWMLPyr6MuN+7Sv6ud1TjH2tpKyQEkEOXQFCABbUUrm4RsYT1/6fA== X-YMail-OSG: P4yPtowVM1nPiVF8Xa3gZZcrKQ7xqsu5OyNNUSJYmgguVvh_z4qG0t3Y9xw5eTH ctd6TQyx9yki5zgoUI2jxvHWRiI5Kqsiec.A2CUBFHG_PL1uqOUcoBBVid4wOF7AjjfabA6oBp9f XfByfrD5XO9xOhe5gfOYgJ7ogTuifMrNQtHe5NDcXk3AjNVnZY215rvKO6PO_UnVg5L7q5Q5Lzc7 l_fJ6shL7PmXWaETVpkEjeg.gWlo0nkD6K91dySd0kKCpUGUUhVYeecWpdg.Q7xqXA23B.d8NWiu IbSstYbLDkOo1T4vt_BopqEeQp.Cg59XREbZ_mLyaNDtSRHnXeHEllBxkqYzdDNcfLN4bnuCpoyk fEJqKh3svrlOv9COPKRPIEul28p2c0dkAELEDzTytzKDvtK54.rjpIpd5K_UFxJfhk1HTOzmtRLu yw98CcYJzlviqY6iF4W2GSi21ou6d1pcpS250Y9vb25u9UNSQfj9NhNsBy7wDEaBdeHiBAV5ZW8N _1fxCAedm.q82_rdkR6FcxYBbXvMN4avuecIpgLT1NmoKANtKTR2e1sct0rXegmD72uJBbn4MXLw cn5YqI.RBsh9iJy3B1TFLN5a1Sw6zCAfh1ZoJuUKsLP8RMYFXwi18dlxZ3EiVYaQlZAlsXyxi6eG DkXvIGyE_sbtIzdyuofG0E0ZBNp4Mhl9naQCH94mRQEFao3UaO80giGEQTA0KjM3zmsVFvCUzmcM feAUx8FqlweLNc3l6rP1m3SdQbDf7JhRKIXLkMBS6zHEemWthW8qVgPQ4b7omJ9OgnAaq7KhvBu0 nWlan9tyVaT5vC_jpAHObrlKl1T4xPz7t6p6uFwBVsjALeY3Bhb7PXfFCWtIObDU.A4e1ymxTinE yLPw6kbHgewfeCRlkwwNUWGZwvX9vXFAU3_u5Wj0XorKcBXFGVQPB598yiNttAWzPmjCnF7XqShK UDlw7H62a6IuZNsQ0wHzwIi0AcxykZcG_P1n8c68UADVM2karItMGtOUHRFAJ7AXeTnl2ULnQ1cW sYUQzW..6_bCf7QPbj7TNNwQ_8dv6xJqOyTY6MRI7d2x6X9mb524qStgEFzM51vpC4EA48dYzt0r RtC6LOb6Rwd2yi5eTTscH24KIoIbIaOM7jFm8WlZA2AekQBU275pBzUoHfkpEFwKMZz68vuSx.9R oRgrsfcXQg9d3K3ri.xUFY.VckHY.pA_BC4ibsrlDlYNRR9YDIEY3C_ZDb84ATtNDeD9TnDbhXBf rPP2mJYluCwSAlIau2trmmzPAkPUZrh3WvXfDzNctAa07r1YVeJV3GiLiZj5Pa28dDocBCT.Yvqj xBeKQb_d93yzsy2aw2aOIqbhzCdH0tyjDPTvcEXiGeLaTw59FVBy2mKWxxK2NuXKDdrWwCeR7Efb z.5KAoiDqJ9XLIIZOrVPM96lOTdl.3SugMl6uAL1y6wq.uLlRDfZK..X8zZ73.Tc3LPyDuanQm7b 2WTrD6Xc5l2gAwy9JO2K8GSaDlVgRsnBMr3eNLI.Ppcbp4iTSZy9ZElajHsFQEjLXm.3d98Gw8bZ jyMJedTPLELeTmPHjUDeEIPgqBlSQFLqEE9Jp.P4sjUpcZKT.sFZAjnwIRK_adXqhAEP1ySAieA7 y1mzrCj9nNB3kdQvtY.iTwDl0Lb.qmMIONxDmM8rftWTbtqrG8awYULaL9Y8rZNdWYNyKDx7wZzu 6PXowuA_9EZNmZcwHgK0EvkVik.S8U4zKGTHa6d13u5DczIDa9rf8d8sXJv1cTGmkX0etbP8nnOk WV7aeuVUSolzVuc4AZ.06CtSyWQ7YONomilJGmN1Sc2XOlLUedsK9narQTS0Hp3gzLUA.9kYDt.0 peQKUEf..NrzL0Ecm0wJwqladadStFJmWCDKTmYUxQTwx6z8yV7Yjyk1X_CF6rWKO8O4yeGn2744 8JPRC5q_UnoNPX5w7_j5kRIsdgzWB23ddBMvbU6lB0SRRmO20R5Pv4GVphGWSOFBXVf8zf.WqSum r55HouoKzbH9ff4G3yznFRpHLQLq2D8qmzT7uRTmazleQC2hXqMxQhvm3XTiIzW2_Bj2Gk0Hxo3g fkdjmB1iuGT9XPrjgMKjykboP382kZpCc1SG_96IUtMWfStiWXjzc_GaNNFdnVo.TjLdHNiM_UlT kGcBzT_s5leucbiNYfkWb1T8exaiO4PSS9sqyOM7k_AwPXcFXDW38pFJyyXWSiyc2G6bVdM7Mzu3 BK5aPhEZfqWp25rJuOWX4AFsuBOzqn.grrd4KpkPII1VK3T3_bO1098XZLxXiPvOFNmZYNiaes5N jBtD6 X-Sonic-MF: X-Sonic-ID: 652ff345-4215-4d83-b55a-7fe7fe5cc514 Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Sun, 21 May 2023 21:25:04 +0000 Received: by hermes--production-ne1-574d4b7954-hz4nw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 578a8dc8379a2228ccca16183fcd67c1; Sun, 21 May 2023 21:25:03 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: RE: [RFC] An idea for general kernel post-processing automation in FreeBSD Message-Id: <2EDDC5DC-81C2-4EB8-B729-66F03A8854E4@yahoo.com> Date: Sun, 21 May 2023 14:24:51 -0700 To: Hans Petter Selasky , freebsd-arch X-Mailer: Apple Mail (2.3731.400.51.1.1) References: <2EDDC5DC-81C2-4EB8-B729-66F03A8854E4.ref@yahoo.com> X-Spamd-Result: default: False [-3.45 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.946]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.31:from]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MLMMJ_DEST(0.00)[freebsd-arch@freebsd.org]; TO_DN_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.31:from] X-Rspamd-Queue-Id: 4QPYWk4D59z4HfM X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hans Petter Selasky wrote on Date: Sun, 21 May 2023 20:13:20 UTC : > . . . > I've put up a review for FreeBSD-14-main for discussion at: >=20 > https://reviews.freebsd.org/D40193 >=20 > Depending patches are: >=20 > = https://cgit.freebsd.org/src/commit/?id=3D805d759338a2be939fffc8bf3f25cfaa= b981a9be That commit changes an example usage of the linuxkpi DEFINE_MUTEX in dev/mlx4/mlx4_core/mlx4_main.c . The RFC note does not seem to address a related Linux vs. FreeBSD issue involved (uniqueness of global symbols vs. not related and moving static's in a function to instead be global). The relationship with and handling of the linuxkpi may need to be part of the "arch" discussion or the reviews. For reference: DEFINE_MUTEX is defined in: # grep -r "define.*DEFINE_MUTEX" /usr/main-src/sys/ | more /usr/main-src/sys/compat/linuxkpi/common/include/linux/mutex.h:#define = DEFINE_MUTEX(lock) The commit (white space details may not be preserved): diff --git a/sys/dev/mlx4/mlx4_core/mlx4_main.c = b/sys/dev/mlx4/mlx4_core/mlx4_main.c index ca63d1d12ba6..a37b900a2ed0 100644 --- a/sys/dev/mlx4/mlx4_core/mlx4_main.c +++ b/sys/dev/mlx4/mlx4_core/mlx4_main.c @@ -1164,6 +1164,8 @@ err_sup: return err; } =20 +static DEFINE_MUTEX(set_port_type_mutex); + static ssize_t set_port_type(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -1172,7 +1174,6 @@ static ssize_t set_port_type(struct device *dev, port_attr); struct mlx4_dev *mdev =3D info->dev; enum mlx4_port_type port_type; - static DEFINE_MUTEX(set_port_type_mutex); int err; =20 mutex_lock(&set_port_type_mutex); > https://reviews.freebsd.org/D40190 > https://reviews.freebsd.org/D40191 > https://reviews.freebsd.org/D40192 =3D=3D=3D Mark Millard marklmi at yahoo.com