maintainer-approval requested: [Bug 269857] devel/apr1: update to 1.7.3 : [Attachment 241267] [patch] devel/apr1 update for bdb support (allow no bdb, add correct AGPLv3 license if bdb18)

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 02 Apr 2023 16:27:08 UTC 
John Hein <jcfyecrayz@liamekaens.com> has asked freebsd-apache (Nobody)
<apache@FreeBSD.org> for maintainer-approval:
Bug 269857: devel/apr1: update to 1.7.3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269857

Attachment 241267: [patch] devel/apr1 update for bdb support (allow no bdb, add
correct AGPLv3 license if bdb18)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=241267&action=edit



--- Comment #5 from John Hein <jcfyecrayz@liamekaens.com> ---
Created attachment 241267
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=241267&action=edit
[patch] devel/apr1 update for bdb support (allow no bdb, add correct AGPLv3
license if bdb18)

(In reply to John Hein from comment #4)
Here's an update to reflect the correct license requirements if using
databases/db18 and also allow the user to select no BDB if desired - as it was
option before
https://cgit.FreeBSD.org/ports/commit/?id=f473a726dba249ec936d340b8b1167ce5996b
d30

Also this fixes the case of neither BDB option (BDB_VARS_OFF no longer works as
it was intended since there are two BDB* options now).	That was broken with
the commit.

While here also fix spelling for 'BERKELEYDB'.

Tested with all three combinations (WITH=BDB WITHOUT=BDB5, WITH=BDB5
WITHOUT=BDB, WITHOUT="BDB BDB5").

I will open a new bug if it is preferred (or if I don't get anyone responding
to this).