From nobody Fri Apr 29 12:15:16 2022 X-Original-To: apache@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 382E2199B905 for ; Fri, 29 Apr 2022 12:15:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqWdw74LXz3L4j for ; Fri, 29 Apr 2022 12:15:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D38484950 for ; Fri, 29 Apr 2022 12:15:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23TCFGEp092254 for ; Fri, 29 Apr 2022 12:15:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23TCFGPi092253 for apache@FreeBSD.org; Fri, 29 Apr 2022 12:15:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: apache@FreeBSD.org Subject: [Bug 263655] www/apache24: Remove automatic mpm fallback configuration Date: Fri, 29 Apr 2022 12:15:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ports@skyforge.at X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: apache@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Support of apache-related ports List-Archive: https://lists.freebsd.org/archives/freebsd-apache List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-apache@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651234517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YltEJiP1yMO21KZlpTWFr1xWQI3uweuPrEN0TAC6soA=; b=TBgFS1cqAdJuROU9XUFy7viATzmVOI89OR/rofBJL8COYP0l+iNJD75yw3EVmzZbHYtFYE XdW0/+3uI67ocoq2efnUUHmu/21GeHzcEPSrhGzdpHXMcHD+2QFkTTw/p74Xa5Id9X1K5g BHTrqahixC6YxHDY66iJceXWsiw/zyXOGyNMK+wIawsvzK+Y/dTfM9RqbHKEahq5V8n13F 43dOmxOP/9H4iXebvmkos7PnuojTkkj3j0hVvv/THvGPC6qxIKp95C6cWaOA0AIY08o+4n LFy4cyuoKjDnXooWaFA0XpcpArBUdIEWZ5IKvn6c4TiLIovAQcDwAfy220iRhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651234517; a=rsa-sha256; cv=none; b=XMOn7GI5aE2He82TXWxec9pShM1eAGQPcLI5iZFLS4ytsM1XWUyt7Zgc+vj+sH6P6SgECI 0CNRKxXRgwK8h9EwBZZH6EUmLpPI2cPpuhU4uMoCFPUn4CmZp0iOINb2vaXvCIHUezIUjn euaDV1TTkMGMmYvp71lFi31Y+DsFOLP+XBW1gSwJKPOVKog8zPS1OEYjqk3ny1P+tW4PDr SxXlP9W1+z6mOBwucYRq5wC6XlvE4MP8IyR37gu3C/5/Ppq+yTe1Sd9af53F9VpH+U7RVE E7XnEUUhTtKmtw8ZKes+z+tHL6E6GAjF9KE+70UfuwQLPiNI6OXNp5KRnPVD9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263655 Bug ID: 263655 Summary: www/apache24: Remove automatic mpm fallback configuration Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: apache@FreeBSD.org Reporter: ports@skyforge.at Assignee: apache@FreeBSD.org Flags: maintainer-feedback?(apache@FreeBSD.org) Created attachment 233582 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D233582&action= =3Dedit www/apache24: Remove automatic mpm fallback configuration I'd like to propose a patch to remove the automatic fallback generation with mpm_prefork for www/apache24. Currently the apache24 package greps for a present MPM configuration in http.conf and creates a fallback configuration= in modules.d, which is included by default. I feel that this is problematic fo= r a variety of reasons: * It doesn't account for modular configurations: If the loading of an MPM module takes place in an included configuration (as would be the case for m= ost modularized configuration schemes, which are increadibly useful and common), the script generates a fallback configuration that may cause apache to eith= er load the wrong mpm module on restart, or cause it to fail starting alltoget= her. * It doesn't preserve changes to the file: Even if I keep the 000_mpm_prefork_fallback.conf configuration but uncomment the LoadModule statement, the configuration is simply overwritten on the next update/reinstallation of the package. * From a philosophical perspective, it feels like it's overstepping boundar= ies: We nowadays ship with a sample configuration that includes a well-intended default LoadModule statement for mpm_prefork. Whichever way the user decide= s to modify and diverge from that default configuration should be up to them. Creating non-sample configurations in places that would be sourced by defau= lt feels like it's taking things a step too far. Judging from the commit history, I think there was once a point for this ki= nd of behaviour to help with the migration from a static to a dynamic MPM back= end. But this was in 2015, so I think it's time to reevaluate this and, perhaps, move on. As a minor note: I think the configuration as it stands right now doesn't e= ven work properly anymore. At least my apache complains with the following: Syntax error on line 21 of /usr/local/etc/apache24/modules.d/000_mpm_prefork_fallback.conf: Cannot load libexec/apache24/mod_mpm_prefork.so into server: Cannot open "/usr/local/etc/apache24/libexec/apache24/mod_mpm_prefork.so" I've attached a patch that (I think?) removes this functionality in its entirety, as it really shouldn't be necessary anymore. All configurations h= ad ample time migrating and new installations come with a sane default anyway.= We could still preserve a warning on install, but I'm really not sure that's necessary anymore. In any case it would make my own personal use case a bit nicer to deal with= , as I have split the individual modules and their configurations in seperate fi= les in modules.d and currently need to pay attention to this everytime I update apache24, but I'd love to hear feedback and different opinions on this. :) Cheers, Sascha --=20 You are receiving this mail because: You are the assignee for the bug.=