From nobody Fri Apr 29 12:15:16 2022 X-Original-To: apache@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0E83D199B65B for ; Fri, 29 Apr 2022 12:15:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqWdw5Jqwz3LHm for ; Fri, 29 Apr 2022 12:15:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 96C074C2C for ; Fri, 29 Apr 2022 12:15:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23TCFGns092242 for ; Fri, 29 Apr 2022 12:15:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23TCFGTS092241 for apache@FreeBSD.org; Fri, 29 Apr 2022 12:15:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: apache@FreeBSD.org Subject: maintainer-feedback requested: [Bug 263655] www/apache24: Remove automatic mpm fallback configuration Date: Fri, 29 Apr 2022 12:15:16 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: apache@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Support of apache-related ports List-Archive: https://lists.freebsd.org/archives/freebsd-apache List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-apache@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651234516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXWDuZNZ+3HsmheqAYmYI0jvI7a+vMboUxSFaeKPJ8c=; b=dvWCOIjrhbDiPHrGFFgv4a5UN1ilK6Qz4QhFFyNsXIxBULupeqlZLT5HiB3tfkZn7inpJp OV1LyZ2wZHhYzhgXu5Na0Yh4IfNItQpdufoXGO6AW5tSLz3DWimN1jEjjLTk5VI+94/8/w wxoYCxMMP64eNvfWKL9iO3nHWlOxTzyklOONVpxZqRQK6LBFJUKUKKXY3xmM142D7lFlL/ +/uMWX0grjhDUMJWWf2El+0ZeyKASe9R5wD8UPc9IEC2UOmUwCCFq1sVDeCIyaBTUrg/jR d1JnCZcMRu9eZoS1pdKkQVZPQJ/8nYPczbSAEx5A5eTx9uXD4N3DQd+AfhWrBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651234516; a=rsa-sha256; cv=none; b=XOLk+u76ptUPcA0HFHwqcyNS5dnMEZ6NOi5Q5cyaCD6OnlNQoCIlhlFKvBNhPFWXKTNco0 7YFMacNi/YFv41VEFVyQPE9k9UOYGFtq2uCb+dQ/bWWig60fMTtPcR0KZjDhEWmr6bGY0+ nR8twu7BAvsZuR3oKP1fUuVaJ2M6oMe2x8C6tSO73Z9ALR52YNWmjzLgRs2m6s+5/Segwc B40oq0EJWUIRmRV+IgVwxPjI1uPMhaPqTvuX6AdpcvOA3/AlwgEAtffCRWBTdeN7/q+r/4 mDez89KbJo0p5bwgT+t32QvoANkyZdo62N1oBXBAZFiSN7tj0UGSyFNApT8JAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-apache (Nobody) for maintainer-feedback: Bug 263655: www/apache24: Remove automatic mpm fallback configuration https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263655 --- Description --- I'd like to propose a patch to remove the automatic fallback generation with mpm_prefork for www/apache24. Currently the apache24 package greps for a present MPM configuration in http.conf and creates a fallback configuration= in modules.d, which is included by default. I feel that this is problematic fo= r a variety of reasons: * It doesn't account for modular configurations: If the loading of an MPM module takes place in an included configuration (as would be the case for m= ost modularized configuration schemes, which are increadibly useful and common), the script generates a fallback configuration that may cause apache to eith= er load the wrong mpm module on restart, or cause it to fail starting alltoget= her. * It doesn't preserve changes to the file: Even if I keep the 000_mpm_prefork_fallback.conf configuration but uncomment the LoadModule statement, the configuration is simply overwritten on the next update/reinstallation of the package. * From a philosophical perspective, it feels like it's overstepping boundar= ies: We nowadays ship with a sample configuration that includes a well-intended default LoadModule statement for mpm_prefork. Whichever way the user decide= s to modify and diverge from that default configuration should be up to them. Creating non-sample configurations in places that would be sourced by defau= lt feels like it's taking things a step too far. Judging from the commit history, I think there was once a point for this ki= nd of behaviour to help with the migration from a static to a dynamic MPM back= end. But this was in 2015, so I think it's time to reevaluate this and, perhaps, move on. As a minor note: I think the configuration as it stands right now doesn't e= ven work properly anymore. At least my apache complains with the following: Syntax error on line 21 of /usr/local/etc/apache24/modules.d/000_mpm_prefork_fallback.conf: Cannot load libexec/apache24/mod_mpm_prefork.so into server: Cannot open "/usr/local/etc/apache24/libexec/apache24/mod_mpm_prefork.so" I've attached a patch that (I think?) removes this functionality in its entirety, as it really shouldn't be necessary anymore. All configurations h= ad ample time migrating and new installations come with a sane default anyway.= We could still preserve a warning on install, but I'm really not sure that's necessary anymore. In any case it would make my own personal use case a bit nicer to deal with= , as I have split the individual modules and their configurations in seperate fi= les in modules.d and currently need to pay attention to this everytime I update apache24, but I'd love to hear feedback and different opinions on this. :) Cheers, Sascha