Re: git: cd8c2e012761 - main - linuxkpi: Add <linux/cpufeature.h>

On 20 Mar 2025, at 19:53, Jean-SébastienPédron <dumbbell@FreeBSD.org> wrote:
> 
> The branch main has been updated by dumbbell:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=cd8c2e012761bf672074798be64d5ce16af7aff8
> 
> commit cd8c2e012761bf672074798be64d5ce16af7aff8
> Author:     Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
> AuthorDate: 2025-03-03 19:32:20 +0000
> Commit:     Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
> CommitDate: 2025-03-20 19:43:44 +0000
> 
>    linuxkpi: Add <linux/cpufeature.h>
> 
>    Reviewed by:    emaste
>    Sponsored by:   The FreeBSD Foundation
>    Differential Revision: https://reviews.freebsd.org/D49385
> ---
> .../linuxkpi/common/include/linux/cpufeature.h     | 37 ++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> 
> diff --git a/sys/compat/linuxkpi/common/include/linux/cpufeature.h b/sys/compat/linuxkpi/common/include/linux/cpufeature.h
> new file mode 100644
> index 000000000000..046fab53d521
> --- /dev/null
> +++ b/sys/compat/linuxkpi/common/include/linux/cpufeature.h
> @@ -0,0 +1,37 @@
> +/*-
> + * Copyright (c) 2025 The FreeBSD Foundation
> + * Copyright (c) 2025 Jean-Sébastien Pédron
> + *
> + * This software was developed by Jean-Sébastien Pédron under sponsorship
> + * from the FreeBSD Foundation.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> + * SUCH DAMAGE.
> + */
> +
> +#ifndef _LINUXKPI_LINUX_CPUFEATURE_H_
> +#define _LINUXKPI_LINUX_CPUFEATURE_H_
> +
> +// #include <linux/init.h>

What’s up with this? Is this a header that should be included but can’t
yet be (if so, why?), one that should be included and was left
commented locally for some reason, or one that shouldn’t be included
but was left over from something? If it needs to stay, please document
why it’s not uncommented, and also conform to style(9) as this is a
C++-style comment.

Jess

> +#include <linux/mod_devicetable.h>
> +#include <asm/cpufeature.h>
> +
> +#endif /* _LINUXKPI_LINUX_CPUFEATURE_H_ */