Re: git: 9d0eea9422d0 - main - Make newly POSIX functions visible

On 2025-03-20 03:11, Stephen Hurd wrote:
> On 2025-03-20 02:16, Colin Percival wrote:
>> On 3/19/25 16:45, Stephen Hurd wrote:
>>> commit 9d0eea9422d075c8a6924b33161d2d5abfb4072a
>>> Author:     Stephen Hurd <shurd@FreeBSD.org>
>>> AuthorDate: 2025-03-19 23:45:06 +0000
>>> Commit:     Stephen Hurd <shurd@FreeBSD.org>
>>> CommitDate: 2025-03-19 23:45:06 +0000
>>>
>>>      Make newly POSIX functions visible
>>>           Some of the POSIX 202405L functions are already in the 
>>> system, make
>>>      them visible when appropriate.
>>>           Reviewed by:    imp
>>>      MFC after:      1 week
>>>      Differential Revision: https://reviews.freebsd.org/D47859
>>
>> This broke lang/python311:
>>> --- Modules/posixmodule.o ---
>>> ./Modules/posixmodule.c:12907:9: error: call to undeclared function 
>>> 'setresuid'; ISO C99 and later do not support implicit function decla
>>> rations [-Werror,-Wimplicit-function-declaration]
>>>  12907 |     if (setresuid(ruid, euid, suid) < 0)
>>>        |         ^
>> I realize this is almost certainly a bug in Python (assuming that these
>> functions are available without setting the right POSIX level) but if
>> Python has this bug I'm sure other ports will also be affected. Please
>> back out this commit and talk to portmgr@ about doing an exp-run to find
>> out what needs to be fixed in the ports tree before re-committing this.
>
> I could also make it #if __POSIX_VISIBLE >= 202405 || __BSD_VISIBLE
>
> Should fix the problem, but still make them visible for POSIX.

https://reviews.freebsd.org/D49421