git: 93e70e3a9442 - main - mlx5en: explain why interface needs to be reopened on hw lro change

From: Konstantin Belousov <kib_at_FreeBSD.org>
Date: Thu, 13 Mar 2025 16:03:14 UTC
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=93e70e3a9442dca31533f0773ede667fd5379b01

commit 93e70e3a9442dca31533f0773ede667fd5379b01
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2025-02-05 02:27:02 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2025-03-13 15:59:12 +0000

    mlx5en: explain why interface needs to be reopened on hw lro change
    
    Reviewed by:    Ariel Ehrenberg <aehrenberg@nvidia.com>, Slava Shwartsman <slavash@nvidia.com>
    Sponsored by:   NVidia networking
    MFC after:      1 week
---
 sys/dev/mlx5/mlx5_en/mlx5_en_ethtool.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_ethtool.c b/sys/dev/mlx5/mlx5_en/mlx5_en_ethtool.c
index b0b7a175a1b6..28401048a427 100644
--- a/sys/dev/mlx5/mlx5_en/mlx5_en_ethtool.c
+++ b/sys/dev/mlx5/mlx5_en/mlx5_en_ethtool.c
@@ -1136,7 +1136,10 @@ mlx5e_ethtool_handler(SYSCTL_HANDLER_ARGS)
 
 		error = mlx5e_hw_lro_update_tirs(priv);
 
-		/* restart network interface, if any */
+		/*
+		 * Restart network interface, if any.  This
+		 * re-populates rx wqes with proper segment sizes.
+		 */
 		if (was_opened)
 			mlx5e_open_locked(priv->ifp);
 		break;