Re: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK
- In reply to: John Baldwin : "Re: git: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 10 Mar 2025 20:02:32 UTC
Ah, I see. <mutters something about non- sortable commit IDs making "earlier" difficult to ascertain; sighs in futility> Thanks, Ravi (rpokala@) -----Original Message----- From: John Baldwin <jhb@FreeBSD.org <mailto:jhb@FreeBSD.org>> Date: Monday, March 10, 2025 at 11:15 To: Ravi Pokala <rpokala@freebsd.org <mailto:rpokala@freebsd.org>>, <src-committers@FreeBSD.org <mailto:src-committers@FreeBSD.org>>, <dev-commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org>> Subject: Re: git: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK On 3/10/25 13:41, Ravi Pokala wrote: > Hi John, > >> This reverts commit 234683726708cf5212d672d676d30056d4133859. > > The commit message for that change says that this allocation might be done while holding a lock, and so M_WAITOK is not valid. So then why is this change okay? > > Thanks, Because the earlier commit to sdhci in this same push fixed it to create devices in a sleepable context. -- John Baldwin