Re: git: 5c7087c349fc - main - ixgbe: Fix a logic error in ixgbe_read_mailbox_vf() Reviewed by: kbowling Differential Revision: https://reviews.freebsd.org/D49156

From: Kevin Lo <kevlo_at_freebsd.org>
Date: Sat, 01 Mar 2025 02:34:35 UTC 
On Fri, Feb 28, 2025 at 01:54:08AM -0700, Kevin Bowling wrote:
>
> MFC?

Done.  Thanks for reminding me.

> On Fri, Feb 28, 2025 at 1:13???AM Kevin Lo <kevlo@freebsd.org> wrote:
> >
> > The branch main has been updated by kevlo:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=5c7087c349fc1d826807aa1a11912c9e774e3321
> >
> > commit 5c7087c349fc1d826807aa1a11912c9e774e3321
> > Author:     Kevin Lo <kevlo@FreeBSD.org>
> > AuthorDate: 2025-02-28 08:12:00 +0000
> > Commit:     Kevin Lo <kevlo@FreeBSD.org>
> > CommitDate: 2025-02-28 08:12:00 +0000
> >
> >     ixgbe: Fix a logic error in ixgbe_read_mailbox_vf()
> >     Reviewed by:    kbowling
> >     Differential Revision:  https://reviews.freebsd.org/D49156
> > ---
> >  sys/dev/ixgbe/ixgbe_mbx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sys/dev/ixgbe/ixgbe_mbx.c b/sys/dev/ixgbe/ixgbe_mbx.c
> > index 5f1f64e02b82..0b866e7a39af 100644
> > --- a/sys/dev/ixgbe/ixgbe_mbx.c
> > +++ b/sys/dev/ixgbe/ixgbe_mbx.c
> > @@ -297,7 +297,7 @@ static u32 ixgbe_read_mailbox_vf(struct ixgbe_hw *hw)
> >         u32 vf_mailbox = IXGBE_READ_REG(hw, IXGBE_VFMAILBOX);
> >
> >         vf_mailbox |= hw->mbx.vf_mailbox;
> > -       hw->mbx.vf_mailbox |= vf_mailbox % IXGBE_VFMAILBOX_R2C_BITS;
> > +       hw->mbx.vf_mailbox |= vf_mailbox & IXGBE_VFMAILBOX_R2C_BITS;
> >
> >         return vf_mailbox;
> >  }