git: ca363716fc49 - main - checkstyle9.pl: Remove unneeded checks
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 24 Jan 2025 20:27:46 UTC
The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=ca363716fc492146978c8650b97862f94daab6bf commit ca363716fc492146978c8650b97862f94daab6bf Author: Ahmad Khalifa <ahmadkhalifa570@gmail.com> AuthorDate: 2025-01-06 01:52:06 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2025-01-24 20:27:20 +0000 checkstyle9.pl: Remove unneeded checks Both the bad email check and the signoff check are handled in the "checklist" github workflow now. Reviewed by: emaste, imp Pull request: https://github.com/freebsd/freebsd-src/pull/1570 Signed-off-by: Ahmad Khalifa <ahmadkhalifa570@gmail.com> --- tools/build/checkstyle9.pl | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index 5854cf613e01..b40c9810bc93 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1253,8 +1253,6 @@ sub process { my $in_header_lines = $file ? 0 : 1; my $in_commit_log = 0; #Scanning lines before patch - my $has_sob = 0; - my $author_is_committer = 0; my $non_utf8_charset = 0; our @report = (); @@ -1450,33 +1448,6 @@ sub process { $is_patch = 1; } -# Filter out bad email addresses. - if ($line =~ /^(Author|From): .*noreply.*/) { - ERROR("Real email adress is needed\n" . $herecurr); - } - - if ($line =~ /^Author: .*[a-z-0-9]\@freebsd\.org/i) { - $author_is_committer = 1 - } - -#check the patch for a signoff: - if ($line =~ /^\s*signed-off-by:/i) { - # This is a signoff, if ugly, so do not double report. - $in_commit_log = 0; - $has_sob = 1; - - if (!($line =~ /^\s*Signed-off-by:/)) { - ERROR("The correct form is \"Signed-off-by\"\n" . - $herecurr); - $has_sob = 0; - } - if ($line =~ /^\s*signed-off-by:\S/i) { - ERROR("space required after Signed-off-by:\n" . - $herecurr); - $has_sob = 0; - } - } - # Check for wrappage within a valid hunk of the file if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("patch seems to be corrupt (line wrapped?)\n" . @@ -2659,10 +2630,6 @@ sub process { } - if ($has_sob == 0 && $author_is_committer == 0) { - WARN("Missing Signed-off-by: line"); - } - # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines == -1) {