From nobody Fri Jan 10 16:59:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YV7DS0SZwz5kf6Y for ; Fri, 10 Jan 2025 16:59:36 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YV7DR2fMlz44ls for ; Fri, 10 Jan 2025 16:59:35 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso17267005e9.2 for ; Fri, 10 Jan 2025 08:59:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736528374; x=1737133174; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KRyl85M9FkfoawdC7yx7Lq1AHvf3pfx/7LI1a3TEM8w=; b=CQhogdiKNvCkSHGM3SrtjC+pbpGu4BV9XbK2o7AwTuIB7HeU55LSDklUKuaZakqNLT aQMPvXj+E6vM1jT+IEBL5IZ4gJYj4dtMVElTembWLNfXhNWvieY6cdRfBeSI5q4UePeU NJgbJ29qojILnE+eQihItyPEnV8xT4gRCsAXfIgNPxXEhJrazHDJ+gTbbHJ/BwfZpSJy egy9tD9Ebc8o+OZsTMNds3AySY0B/J1KgvjUGyTNgGwFADvbjDvUjLUKeBUoaoAwRgpU RdQvElRWeg3T9aklaiKXBkmZiTpetrNds5OqRO6wEx/UflBavY5QZ4880mvnR7HRjK1Y ON/w== X-Forwarded-Encrypted: i=1; AJvYcCW5rcEMWasdPzbivu0paM4ZRWCjKZI5ru5HiQLLlBiBCtzaLvBp7lLx55Wyh20pXUZ9oxN/+mBprqRDZQiWrIvOf0a+JA==@freebsd.org X-Gm-Message-State: AOJu0YwqtrG8214FD4hGYuvMgHqxl8HuMaOqlQ0g+ExWlTpRJrYJpy8V jtW0I1oUobnVrQydnp/C0rO9mCtyBZNgV8WHXLtIYUzgmK9OIRaEjhOfMs6sIDL++gkf8v6bM1M m X-Gm-Gg: ASbGncvdvznSzfpU/HEdhlhFT0MB4s6XVdOlBrJFDZjmo7tIzbBdu3erLUDwU2i400X ZcIKoZR8YdiIUHvX+xfVGJBhAVlvTskvd4Yr2sxvLc9wOvr06puKTlmyEjKziKXc0rJlTltH1nA 19tyut14Wqbto+NIr5uPND9yX+bUte7NR34wL76YFEfO44dBPG01jiMFYH53rPH0AZn8Oveiqqg 2dKW4rvaGz+R/snPyAqTQIqxO0p3nUiTGosy5tZyD1bpXj8MioEou/P1je05wboDGbnWcc= X-Google-Smtp-Source: AGHT+IFK26t0830qlHh9mLyicfpIJ3WWtbzDrhkiMlDm+LyelkihZKXA5Qp2Ry+FJwKkqv6vDZqBVw== X-Received: by 2002:a05:600c:1e0b:b0:431:5044:e388 with SMTP id 5b1f17b1804b1-436e26e4c61mr93628075e9.22.1736528373750; Fri, 10 Jan 2025 08:59:33 -0800 (PST) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e62133sm57459525e9.33.2025.01.10.08.59.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jan 2025 08:59:32 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: git: 6b82130e6c9a - main - clock: Add a long ticks variable, ticksl From: Jessica Clarke In-Reply-To: <20250110164742.B31513AF@slippy.cwsent.com> Date: Fri, 10 Jan 2025 16:59:21 +0000 Cc: Mark Johnston , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202501101600.50AG0jk6062308@gitrepo.freebsd.org> <20250110164742.B31513AF@slippy.cwsent.com> To: Cy Schubert X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Rspamd-Queue-Id: 4YV7DR2fMlz44ls X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 10 Jan 2025, at 16:47, Cy Schubert wrote: >=20 > In message <202501101600.50AG0jk6062308@gitrepo.freebsd.org>, Mark = Johnston=20 > wri > tes: >> The branch main has been updated by markj: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6b82130e6c9add4a8892ca897df5a0ec= >> 04663ea2 >>=20 >> commit 6b82130e6c9add4a8892ca897df5a0ec04663ea2 >> Author: Mark Johnston >> AuthorDate: 2025-01-10 15:37:07 +0000 >> Commit: Mark Johnston >> CommitDate: 2025-01-10 15:42:59 +0000 >>=20 >> clock: Add a long ticks variable, ticksl >>=20 >> For compatibility with Linux, it's useful to have a tick counter = of >> width sizeof(long), but our tick counter is an int. Currently the >> linuxkpi tries paper over this difference, but this cannot really = be >> done reliably, so it's desirable to have a wider tick counter. = This >> change introduces ticksl, keeping the existing ticks variable. >>=20 >> Follow a suggestion from kib to avoid having to maintain two = separate >> counters and to avoid converting existing code to use ticksl: = change >> hardclock() to update ticksl instead of ticks, and then use = assembler >> directives to make ticks and ticksl overlap such that loading = ticks >> gives the bottom 32 bits. This makes it possible to use ticksl in = the >> linuxkpi without having to convert any native code, and without = making >> hardclock() more complicated or expensive. Then, the linuxkpi can = be >> modified to use ticksl instead of ticks. >>=20 >> Reviewed by: olce, kib, emaste >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D48383 >> --- >> sys/conf/files | 1 + >> sys/kern/kern_clock.c | 26 ++++++++++++++------------ >> sys/kern/kern_tc.c | 4 ++-- >> sys/kern/subr_param.c | 2 +- >> sys/kern/subr_ticks.s | 44 = ++++++++++++++++++++++++++++++++++++++++++++ >> sys/sys/kernel.h | 9 +++++++++ >> sys/sys/timetc.h | 2 +- >> 7 files changed, 72 insertions(+), 16 deletions(-) >>=20 >=20 > See last paragraph. >=20 > --- kernel.full --- > linking kernel.full > ld: error: undefined symbol: ticks >>>> referenced by cam_iosched.c:1426 = (/opt/src/git-src/sys/cam/cam_iosched.c > :1426) >>>> cam_iosched.o:(cam_iosched_put_back_trim) >>>> referenced by cam_iosched.c:1452 = (/opt/src/git-src/sys/cam/cam_iosched.c > :1452) >>>> cam_iosched.o:(cam_iosched_next_trim) >>>> referenced by cam_iosched.c:823 = (/opt/src/git-src/sys/cam/cam_iosched.c: > 823) >>>> cam_iosched.o:(cam_iosched_get_trim) >>>> referenced 240 more times >>>> did you mean: tick >>>> defined in: subr_param.o >=20 > ld: error: undefined symbol: ticksl >>>> referenced by subr_param.c:200 = (/opt/src/git-src/sys/kern/subr_param.c:2 > 00) >>>> subr_param.o:(init_param1) >>>> referenced by kern_clock.c:489 = (/opt/src/git-src/sys/kern/kern_clock.c:4 > 89) >>>> kern_clock.o:(hardclock) >>>> referenced by atomic.h:184 = (/opt/src/git-src/sys/amd64/include/atomic.h: > 184) >>>> kern_clock.o:(hardclock) >>>> referenced 1 more times > *** [kernel.full] Error code 1 >=20 > make[2]: stopped making "all" in = /export/obj/opt/src/git-src/amd64.amd64/sys > /BREAK > make[2]: 1 error >=20 > make[2]: stopped making "all" in = /export/obj/opt/src/git-src/amd64.amd64/sys > /BREAK > 652.14 real 4727.77 user 227.08 sys >=20 > make[1]: stopped making "buildkernel" in /opt/src/git-src >=20 > make: stopped making "buildkernel" in /opt/src/git-src >=20 >=20 > This (failing to link) only occurs with an incremental build; a clean=20= > rebuild (of /usr/obj/sys/KERNELNAME) circumvents this error. Should = this be=20 > noted in UPDATING? Are you building with KERNFAST / NO_KERNELCONFIG? If so, yeah, that=E2=80=99= s to be expected any time new files are added that are needed by existing ones. If not, I have no idea how that could possibly happen, this = isn=E2=80=99t the kind of change that depend-cleanup.sh has to care about, and this kind of change happens all the time. Jess