From nobody Thu Jan 09 15:47:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTTgg2ZkKz5l1MW; Thu, 09 Jan 2025 15:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTTgg1qPGz4JcY; Thu, 9 Jan 2025 15:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736437647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o/2iDfXYqn6a1yYLfej1hnGUYTNHi7CTC0aS1ZPlo3M=; b=eqotYBrdXtv53kenQ5uP7tv+r0/S/pzNeGshzhPp7gPQ+YL1JsY8RYbz8d2T/xljRlwj1C L68na7Ypbv2OC0ON+5zS0J3xIe8zg5GfTq0nVnEii6G9NYsai3+8WEYSGop3/PwdD3RN11 SO08M3rTFVwJkI9k34bmybpI736+8tsPEn8FJ+i9uManHBPtk/4Bba6BWgDNBmkFvyepiF wLnSYrr8tFE9/iK2QRKR3iUyE97dW3KCeaAMN6DcwIfzbeSvNawZ18RNn9EDLrpghx1jKV FW6p7r7PlkYghuZgMoU+kavXFxNSycO1l6m1w+hCw44fDAyrIiUxN5srSbmKjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736437647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o/2iDfXYqn6a1yYLfej1hnGUYTNHi7CTC0aS1ZPlo3M=; b=AL/TDCo/r/nVzF2jluMwYwhPv2Pt9m9ljXo5c472o6Z2XKFBU4yeO+kCvONbXBLM6p0PQJ xjgFUpNBKh2uDl3cVczo58OXT7lubi9O53DTTsm5E5Wa1wVnd+CC/VUmG4lJf8WF3ecn1i 8xfzykW/YC81eAbOjcWMuBTQMIubotUGMW3Cf4Kqm8vw26mZNPOgTuEZD61Vp5m9c/uFfp H1PRHnyY7qFIr7OXoUbfQ+KylMkG/hu7Ivd5KyfcPS0P/J5epaETNJAgShgN8Z6mgVqBEg LK67HjLye8KsU11+SIOvMlsVHB/GNIMHb5VS19JvbACXnMwhHegAKz99DOs7Kw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736437647; a=rsa-sha256; cv=none; b=NBcrFVU6qlCNb3r/DqUE/cYOfkltbnKaFJfcP9Om/0x4ERWIdvb5e2SVyNoAvj9Tagy7wt lZ5l6EZw35J9o7RaJoJ3bR3HMoJSM9qyqiGaRvDdP5sXlORC1ZV1z6jtxIBiqrsZuQqU1R Lo+9N+Ha8wqOKiBdrfpKPzGMr3rnUdQH1cYfCcCbDMn+YJ9aULW4oeGxRnVPuP2eGEsWK7 YTIrDI6yuterh2+SlTl3CydNLCFDeFHTRxXJNGXW3waDYGa22EWh/tf8o7j4L5z15F+9zY LAKgRySvamasxcIXDj36xB2+yID102PdYEffsTrmtoUX2SNQDE2PxfXr+03NeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YTTgg1PcHzXSH; Thu, 09 Jan 2025 15:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 509FlRk3042143; Thu, 9 Jan 2025 15:47:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 509FlRui042140; Thu, 9 Jan 2025 15:47:27 GMT (envelope-from git) Date: Thu, 9 Jan 2025 15:47:27 GMT Message-Id: <202501091547.509FlRui042140@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Renato Botelho Subject: git: fb98fc4755de - main - fwget: Simplify logic List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: garga X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fb98fc4755def2cb8ca145751b0e54485d5e2f4a Auto-Submitted: auto-generated The branch main has been updated by garga: URL: https://cgit.FreeBSD.org/src/commit/?id=fb98fc4755def2cb8ca145751b0e54485d5e2f4a commit fb98fc4755def2cb8ca145751b0e54485d5e2f4a Author: Renato Botelho AuthorDate: 2025-01-09 14:24:18 +0000 Commit: Renato Botelho CommitDate: 2025-01-09 15:47:22 +0000 fwget: Simplify logic Summary: Use log() to print messages that should be supressed when -q is in use. No functional changes intended. Differential Revision: https://reviews.freebsd.org/D48393 Reviewed By: manu Sponsored by: Rubicon Communications, LLC ("Netgate") --- usr.sbin/fwget/fwget.sh | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh index d87cd03aa139..138a2a26bfb1 100755 --- a/usr.sbin/fwget/fwget.sh +++ b/usr.sbin/fwget/fwget.sh @@ -120,16 +120,12 @@ done case "${packages}" in ""|^[[:space:]]*$) - if [ "${QUIET}" != "y" ]; then - echo "No firmware packages to install." - fi + log "No firmware packages to install." exit 0 ;; esac -if [ "${QUIET}" != "y" ]; then - echo "Needed firmware packages: '${packages}'" -fi +log "Needed firmware packages: '${packages}'" if [ "${DRY_RUN}" = "y" ]; then if [ "${QUIET}" = "y" ]; then for pkg in ${packages}; do