From nobody Wed Jan 08 22:18:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YT2PX3nZ4z5k5Pn; Wed, 08 Jan 2025 22:18:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YT2PX3HWzz4fg4; Wed, 8 Jan 2025 22:18:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736374720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QnDtFH3AK7TPv8JG5I45otJP+YX4xqwRyHgeYl/++oY=; b=q7pb7lWa0vVCf11sVjGzL9Wg92l3X32c02mlI+K1rpCy2W72pXgQ+x6awfpdt+0caRWz/q +OBsLqYd641z3ekHKJba7FDiiTgnhNciv8JkeOCgtBVqU51YQ3VFXSL2g5OJ0gIVQBlfur Gsg8W9YSoxbObZGzYOPXr13USX9pKqdZS0CGGoA97a3NqCGrighnajzfIHWwMShOYtcn38 l0zOiI+IVy2N47e1VxGdyi5L6bFpmg1LtB4zC1v5l2MBKU1b4XUEtThvaWCRhKTztmhjlK xHQmx4Mc95UJa0wJPEGWO4rd4+xtGBSlYHLUv2S6epSGLPk8gUvHNRwFanakdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736374720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QnDtFH3AK7TPv8JG5I45otJP+YX4xqwRyHgeYl/++oY=; b=UAogbKMmQnK445EWfpUwT4QCJa1izxzNKSYefFSxcHU4DG5FtggNXyOZpBI4HDDI6C3dXl jjPkTyv/PCQyoJDateNqrQu5LN8gyKjK7CyKtrL/XGEUpD67Fv7G1mjvD8LypH5OlI2bv/ LD2BUej0maF+S5V7adtur+0uxXN4qwdjMOedQ1kvxgaAIsuVPo/ezXfUKf1YRZHNyIKbbX v8EDtzf3b8jn0XShyo+bRmOax+cYafvJRvfL1uRG84r9pIjc0eVhm+3kdF6dLW62//TQTl 2Sd/X1V2igx5YRKW2Mz0wDrXUxNHNZ/YHOYJe5BQV4WFVhsKUkCbAhJqghHQoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736374720; a=rsa-sha256; cv=none; b=WrAX+rFO2wBObO9+gyEMJhBvxSwfZgzsmEroeUWuG0m8jB2Dox14XJHwbqWiGNoozjqHqy XIAEWiDQSoBRfNDxzP81DZCQWu5p0SISyRRaAmc8LyF0Zs2tR7B8zYKzhlKrtN6aogtAlL W6pOj2rOcKsJKRlTRBFk8nwWNyRCEne7jfHU44NxR6O81/r8yKWZba03c0GinsVP/mQ94c v+K9/D/sgiLfP8yVI4U7pJcq6/PuYTm21S7xn1BSVSEFPMQDX/pwdPGQFUtdLjnt87lEET FptZqZfSS1J+XW01POYfmovax8vtmDW2LZgpgtFFe1DmG/EnRMw8+7nHd1ZIvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YT2PX2lrmz1DBl; Wed, 08 Jan 2025 22:18:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 508MIe8a076562; Wed, 8 Jan 2025 22:18:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 508MIe7c076559; Wed, 8 Jan 2025 22:18:40 GMT (envelope-from git) Date: Wed, 8 Jan 2025 22:18:40 GMT Message-Id: <202501082218.508MIe7c076559@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 4c89d59e0cda - main - TCP RACK: don't log an uninitialized value List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4c89d59e0cdac4d83fb5841aefae9214545b2273 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=4c89d59e0cdac4d83fb5841aefae9214545b2273 commit 4c89d59e0cdac4d83fb5841aefae9214545b2273 Author: Michael Tuexen AuthorDate: 2025-01-08 22:15:54 +0000 Commit: Michael Tuexen CommitDate: 2025-01-08 22:15:54 +0000 TCP RACK: don't log an uninitialized value reduce is uninitialized, if the code path for logging is reached via goto old_method;. Reviewed by: rrs, Peter Lei CID: 1557359 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48346 --- sys/netinet/tcp_stacks/rack.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index f590edd71d9d..902845ad34f6 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17474,7 +17474,7 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str * the peer to have a gap in data sending. */ uint64_t cwnd, tr_perms = 0; - int32_t reduce = 0; + int32_t reduce; old_method: /* @@ -17511,7 +17511,8 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str slot -= reduce; } else slot = 0; - } + } else + reduce = 0; slot *= HPTS_USEC_IN_MSEC; if (rack->rc_pace_to_cwnd) { uint64_t rate_wanted = 0;