From nobody Mon Jan 06 19:43:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YRl2y5P7Dz5k6Gq; Mon, 06 Jan 2025 19:43:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YRl2y4c3Lz4Sct; Mon, 6 Jan 2025 19:43:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736192586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aAxDJDuDIYYxr91AfGz6E3utjaQx7VWXwMYpjTE2P4I=; b=WCt4d/fQ9TAhsmrzmgTZZVOJ+BFmWSLWoSbOnCZCbV/HZdIRiHZYPd9bUz1aH8esF7hJ/E lmdfWUkYodbpIFBzVk6Pel8dKeCne3tuj55XKyaFa3fXVbOOYdY1jnfrXZoWM0BXGjk4x6 pS/ZWe0UTYMDEx32W2vKveHumHBYCFYDKOML20prIDnoIaYr9Ca5C6J8jlluwSYbQRL3Vq rF5+40EfRWoMX1GzsCfCUridulPDZtrBlQaFBIE69K4RKzIDSVs9+BOZA9U1jeqq5RyqM1 KnsRtuIGCSOFsiQQGjeHFFPzHzvCdc8/+HbHT5lHQ09C6Uv3CTY1FqSHPgSu3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736192586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aAxDJDuDIYYxr91AfGz6E3utjaQx7VWXwMYpjTE2P4I=; b=YuJkppLxPVfJxG8ZroqBXXOEgXJCOu3yeev/8svHcnTZb89yUs8EbZaPgPy2k+92dmMzBs iNGZmHn7kIQ1VGzVAyyVsRuYw9nMEukMg31oar0PNCNIkzQ8h/wsFo0x0/7b5yQFXkxuJQ uxkm+JiEjcBmenInALOB4DCosCKCBtE9+x8ovCTYNyehYj733ey14zi3Ca6zTmyZZi/AfU CQkfHGmHZiCS5ms1U9xPXtBPFYev51R8J0Rmz72Dft9o9iT0YNb75U0+nzORpHe3RzHSZU DH5c+T5r3Xo8rUmj4lpbjx95c8Oa2MqfiCKXM/QB3SS98t562qhOIXkTURDBOg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736192586; a=rsa-sha256; cv=none; b=HWPgICEK9euxFYOoPVGSkuU+dSTbt786Knmvdpiy0yoFfYFXvcm7VcydkfpnxxFCZVnf5p sbZQnCCTRe3hnL1/XYmrNgFIYKtMIaSM83G1bkZpNTw1xXE2A7b0o6sScqkV6aQ5L21szp +zsHs+7aXz2TSMle4qN20qQL046bB0OgX1R5RfrYJYnOZWvp7OYWrlYcA8O9VQjVKthbBz +u2M5roAyS4HLGtNiMxgJdcC+uTRiXTYFzqMftLfcpaJpdKMANTsyi1vD6YYspTATm/6dc ziqPCGiKM4ZXTKpHblsw5iWEmdB4pURgN3Q3Ujr7TqsMq6FLKVQWCAQGvZ0WCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YRl2y47SzzfBy; Mon, 06 Jan 2025 19:43:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 506Jh6jn093989; Mon, 6 Jan 2025 19:43:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 506Jh6Pm093986; Mon, 6 Jan 2025 19:43:06 GMT (envelope-from git) Date: Mon, 6 Jan 2025 19:43:06 GMT Message-Id: <202501061943.506Jh6Pm093986@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: c28fefe1dc44 - main - TCP BBR: remove dead code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c28fefe1dc44b69743dd18d038440da38a2867a7 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=c28fefe1dc44b69743dd18d038440da38a2867a7 commit c28fefe1dc44b69743dd18d038440da38a2867a7 Author: Michael Tuexen AuthorDate: 2025-01-06 19:40:33 +0000 Commit: Michael Tuexen CommitDate: 2025-01-06 19:40:33 +0000 TCP BBR: remove dead code bw is unsigned and not zero. So it cannot be smaller than 1. No functional change intended. Reviewed by: rrs, cc CID: 1523791 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48323 --- sys/netinet/tcp_stacks/bbr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index 535766a0a1b0..97ff46f0b96b 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -2993,9 +2993,6 @@ use_initial_window: /* We should not be at 0, go to the initial window then */ goto use_initial_window; } - if (bw < 1) - /* Probably should panic */ - bw = 1; if (bw < min_bw) bw = min_bw; return (bw);