From nobody Sat Jan 04 20:14:02 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YQWqb0sTTz5jlMJ; Sat, 04 Jan 2025 20:14:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YQWqb0MlFz4HQv; Sat, 4 Jan 2025 20:14:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736021643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jJUz8ilVGppy7IiMn9JH2Er46o3ALk9r4kSJhpn5OGI=; b=um/ygEcOxLL+ly0LJh9VWArCck2jSJV+ZR/HhcbIIFmC4n+vmJ5md1D5YdNEenfqejJvU6 5oCkcSSVEZPowT5YnNd0CB45+eM1rMRBLUPtOLS3zghdEYsCUNt6kSs5ixHPnQL5vf9GnB BwLnVwlkyuaxjxBd3w23B3rLlJ7k48KHgFG7gCxSBqo8GlGRMA2+kgFH76JfvdvVe8dQy6 EtHihWl9PmHDz2DA4iHTKwcjCkyb43NrF1VioILaSL/QIgDoLhG2e0LnSQ1bwm4+RPfDXB EK2wi0Ulbssh2So2I18l3WL5u4883aFuKW3iMpNM+AVNVbAN/gh/7/cUbUQ3ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736021643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jJUz8ilVGppy7IiMn9JH2Er46o3ALk9r4kSJhpn5OGI=; b=jSpTVf9BZ/RP6aQsegK0W/5nbG2qRdn8Kbn1FKKuaVAgeiM65SqOKG0WzPib48p+Ez7qYK f3yOrsNlUWKwardqDIieA4y+uiyX4NOo9+TXLAtAJHly3quMvY1fYgHz27Y7KS3jvlnYjE s0R8UKxOSSnZRt7m6vZVfdk2cACNy9wkiDLnkWRFP0FAVhlInHnEwaK0Y47r9JECial2ta eS2qIvqGw235rGuGPrb8OMIraGiS6JNZAS6S+cX9dB0d3z06knkPlb16ek6QXeg3RMxlxu y65NgJC1dc3801sPpDEywW5hnqACmuNJ00cD2Y7KKpeTgDJZPpmyQ4SmUmCqUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736021643; a=rsa-sha256; cv=none; b=Hr9mxC6CmCcrIoULaB7qXuA/XwFOZkoaE1fuGVMhXhGZaXZrueUqHr/9P6Vtx8K5+h9Rr9 bV0j5zIEPSZWNk+pLTpoTSbHcz1xlKdaeAt1+4oz86oq6+AVJKfFOv6mwOUnFPFRedMZ6M +u0bKF3AuStuzR13mougWGSBRzfu1f8i4dWmMgGrX+togl8t94ye0wNjzwX2Vb3RC1J+vf VX+IX7I+UoAzgg9mw/QsTCXSCZwA9SQlECJjrh4v9C9uKDSAM+sBr2OmjyiPtfLMn5Hsig 65J4+QzGL1zBWvm32PsQVqAI9Ig+J1swHGl7dE2tevQNr1AwvyEV4CaidUh/MA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YQWqZ734pz168y; Sat, 04 Jan 2025 20:14:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 504KE2ND062585; Sat, 4 Jan 2025 20:14:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 504KE21Z062582; Sat, 4 Jan 2025 20:14:02 GMT (envelope-from git) Date: Sat, 4 Jan 2025 20:14:02 GMT Message-Id: <202501042014.504KE21Z062582@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 84e894ce1309 - main - TCP RACK: remove variable with is only initialized and not changed List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 84e894ce1309b426aa5d1a20ec194401f35dc478 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=84e894ce1309b426aa5d1a20ec194401f35dc478 commit 84e894ce1309b426aa5d1a20ec194401f35dc478 Author: Michael Tuexen AuthorDate: 2025-01-04 20:11:26 +0000 Commit: Michael Tuexen CommitDate: 2025-01-04 20:11:26 +0000 TCP RACK: remove variable with is only initialized and not changed minslot is initialized to 0 and never changed. It is not clear to me under which condition minslot should be set to which value. Therefore, remove it and the code checking that it is not zero. No functional change intended. Reviewed by: rrs CID: 1523812 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48321 --- sys/netinet/tcp_stacks/rack.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 6774acb9d5e6..cc0725324760 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17456,7 +17456,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str { uint64_t srtt; int32_t slot = 0; - int32_t minslot = 0; int can_start_hw_pacing = 1; int err; int pace_one; @@ -17788,11 +17787,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str } } } - if (minslot && (minslot > slot)) { - rack_log_pacing_delay_calc(rack, minslot, slot, rack->r_ctl.crte->rate, bw_est, lentim, - 98, __LINE__, NULL, 0); - slot = minslot; - } done_w_hdwr: if (rack_limit_time_with_srtt && (rack->use_fixed_rate == 0) &&