From nobody Thu Jan 02 16:54:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YPCVq5MJKz5jS8x; Thu, 02 Jan 2025 16:54:59 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YPCVq4Dyqz4lKV; Thu, 2 Jan 2025 16:54:59 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTPS id TNG4txljaIx4rTOTLtsJyF; Thu, 02 Jan 2025 16:54:59 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id TOTJtEOVbGvSVTOTKtwlhD; Thu, 02 Jan 2025 16:54:59 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=FpSm/Hrq c=1 sm=1 tr=0 ts=6776c4e3 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=VdSt8ZQiCzkA:10 a=6I5d2MoRAAAA:8 a=NEAV23lmAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=nB-UjOu4FE0favolvpEA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id D41431E0; Thu, 02 Jan 2025 08:54:56 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 9B0E538D; Thu, 02 Jan 2025 08:54:56 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Kyle Evans cc: Cy Schubert , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: f68ee0e7a1e8 - main - shar: add a deprecation notice In-reply-to: References: <202501020215.5022FeQP042716@gitrepo.freebsd.org> <20250102025400.0235658A@slippy.cwsent.com> <20250102031452.A7E2B455@slippy.cwsent.com> <9156305a-c929-48cf-9619-e23bec6f6897@FreeBSD.org> <20250102162950.514AA288@slippy.cwsent.com> Comments: In-reply-to Kyle Evans message dated "Thu, 02 Jan 2025 10:48:08 -0600." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 02 Jan 2025 08:54:56 -0800 Message-Id: <20250102165456.9B0E538D@slippy.cwsent.com> X-CMAE-Envelope: MS4xfPOIkRc10i6+nQwASvVHz6og4WSl5azhAmBgN5ZZnseoe+Vwrqq/WHrJJLgPsFGfyUsOLcWUIprqSltam/eHj6/wb473AtJhVq6YZfZJ8j4tE5qjXlcS WNHAChrag9zp5E0Dj2xRTb6UF6Mqg8E5BkZ+HkENfqwr57Rn5mFtaY96LPekupSMXUZYx/cCXhlGv7ecbgOafjTkzjyz91TZxgi/XvbqoCYOeok8eQ/FT9PU AUSUpsj71hMDOLVvNPsZq3a6zqdrZ0VCWM36dkjP8X0eQi390HCNWa1PEtoe7e7TCLd+Pgz4PiBdrBFyqPzh33VW8PL0ZLCcmEKSxXs0R3A= X-Rspamd-Queue-Id: 4YPCVq4Dyqz4lKV X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message , Kyle Evans write s: > On 1/2/25 10:29, Cy Schubert wrote: > > In message <9156305a-c929-48cf-9619-e23bec6f6897@FreeBSD.org>, Kyle Evans > > write > > s: > >> On 1/1/25 21:14, Cy Schubert wrote: > >>> In message , Kyle Evans > >>> write > >>> s: > >>>> On 1/1/25 20:53, Cy Schubert wrote: > >>>>> In message <202501020215.5022FeQP042716@gitrepo.freebsd.org>, Kyle Evan > s > >>>>> writes > >>>>> : > >>>>>> The branch main has been updated by kevans: > >>>>>> > >>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=f68ee0e7a1e8732f725cad4ac > 70 > >> 8e > >>>> c49 > >>>>>> 093782d4 > >>>>>> > >>>>>> commit f68ee0e7a1e8732f725cad4ac708ec49093782d4 > >>>>>> Author: Kyle Evans > >>>>>> AuthorDate: 2025-01-02 02:15:36 +0000 > >>>>>> Commit: Kyle Evans > >>>>>> CommitDate: 2025-01-02 02:15:36 +0000 > >>>>>> > >>>>>> shar: add a deprecation notice > >>>>>> > >>>>>> The shar(1) program is simple, but the fundamental idea of a sh > ar > >> chi > >>>> ve > >>>>>> is risky at best and one that we probably shouldn't be promotin > g a > >> s > >>>>>> prominently as a program in $PATH and a manpage. Let's depreca > te > >> and > >>>>>> remove it, since the same functionality can easily be found in > >>>>>> tar(1) instead. > >>>>>> > >>>>>> Reviewed by: emaste, philip > >>>>>> Reviewed by: allanjude, brooks, delphij, des, imp, rpokala ( > pre > >> vio > >>>> us) > >>>>>> MFC after: 3 days > >>>>>> Differential Revision: https://reviews.freebsd.org/D48130 > >>>>>> --- > >>>>>> usr.bin/shar/shar.1 | 14 +++++++++++++- > >>>>>> 1 file changed, 13 insertions(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 > >>>>>> index 903f937491dc..df97021b1bba 100644 > >>>>>> --- a/usr.bin/shar/shar.1 > >>>>>> +++ b/usr.bin/shar/shar.1 > >>>>>> @@ -25,12 +25,24 @@ > >>>>>> .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIB > ILI > >> TY > >>>> OF > >>>>>> .\" SUCH DAMAGE. > >>>>>> .\" > >>>>>> -.Dd January 31, 2019 > >>>>>> +.Dd January 1, 2025 > >>>>>> .Dt SHAR 1 > >>>>>> .Os > >>>>>> .Sh NAME > >>>>>> .Nm shar > >>>>>> .Nd create a shell archive of files > >>>>>> +.Sh DEPRECATION NOTICE > >>>>>> +.Nm > >>>>>> +is obsolete and may not be present in > >>>>>> +.Fx 15 > >>>>>> +and later. > >>>>>> +Because shell archives are simultaneously data and code and are typic > al > >> ly > >>>>>> +interpreted by > >>>>>> +.Xr sh 1 , > >>>>>> +they can easily be trojan-horsed and pose a significant security risk > t > >> o > >>>> use > >>>>>> rs. > >>>>>> +The > >>>>>> +.Xr tar 1 > >>>>>> +utility can still produce shar encodings of files if needed. > >>>>>> .Sh SYNOPSIS > >>>>>> .Nm > >>>>>> .Ar > >>>>>> > >>>>> > >>>>> We should probably point to the new port or the GNU variant in ports. > >>>>> > >>>> > >>>> Oh, sorry, I didn't realize you had gone ahead with the port. I > >>>> wouldn't normally recommend a GNU variant, would you be OK with > >>>> something like: > >>>> > >>>> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 > >>>> index df97021b1bba..6beb1e84ceab 100644 > >>>> --- a/usr.bin/shar/shar.1 > >>>> +++ b/usr.bin/shar/shar.1 > >>>> @@ -43,6 +43,11 @@ they can easily be trojan-horsed and pose a > >>>> significant security risk to users. > >>>> The > >>>> .Xr tar 1 > >>>> utility can still produce shar encodings of files if needed. > >>>> +The > >>>> +.Pa sysutils/freebsd-shar > >>>> +port has been created to maintain this version of > >>>> +.Nm > >>>> +past its deprecation in base. > >>>> .Sh SYNOPSIS > >>>> .Nm > >>>> .Ar > >>>> > >>>> ? > >>> > >>> Yeah, that should do it. > >>> > >> > >> Pushed as 2832af7b4ea256b18ef4dbf2ff97a50765f0609a, thanks. I'll drop > >> another pointer to the port in UPDATING when it comes time to remove it. > >> > >> Thanks, > >> > >> Kyle Evans > > > > As an FYI, I'll patch shar with a couple of patches from NetBSD. They will > > also be applied to the upstream (my github) repo for the port as well. I'll > > probably push these sometime next week. > > > > Sounds good, thanks. I don't have immediate plans for a timeline on > removal beyond "probably before 15", but it would certainly be after > packages are published for a version of the port that you're happy with > to provide a smooth transition. I'll keep both in sync and MFC changes as needed. The proposed changes are in the testing branch of https://github.com/cschube r/freebsd-shar.git. I don't plan to make any other changes after this, unless NetBSD fixes something. I can't simply use their shar because we have improvements they don't and they have improvements we don't. > > Thanks, > > Kyle Evans -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0