From nobody Thu Jan 02 16:48:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YPCLx5GJLz5jRfl; Thu, 02 Jan 2025 16:48:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YPCLx4HtQz4l13; Thu, 2 Jan 2025 16:48:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735836489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfTPqK/lMYA9EoOnRD5B5gOp/QdcpdR0k/59o2l5Ps4=; b=jGPUnzEqEldxpuWquRfiBoFg2ZbBTgpYtIZ+VbQb0AmSl4G8dLISijfAQPxjO9k1OIXBOU pus4R+4amGV9zSy8hO13hzaryLEjELbSAXkcaoPig4fWVkZmfxpcMYFzQ8MZHfngohGVv4 oRGFU1ODQVlVYstxkWQJM+U0eAwmq/GFtFKq9qWOBlU7wDbB1peaB3NSG/6ZDJK2gnxh48 YKhr5+mgEjiYYql4P0NPYhBGVCGM4NM19qHvTTXn1Hkjk5P8DRaX2Y9nO8nylZ6GitG9ET NYLdBgfJIyCU72fkBJZ98JFAEzhkslGDK7YlbftU2526Ns0w6fgrJ6XetiVdnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735836489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfTPqK/lMYA9EoOnRD5B5gOp/QdcpdR0k/59o2l5Ps4=; b=cI65JOcpe5z6YjVtErPTwjzIscMZ5Q7MKfgYPgrCV+i0uXNyoGB1upRcMHzX4HG849Nt84 Fgi2FimZhAHVqjhhfJd09xpsisC65NTOT+OXHvXBl5wlqUi2dadgISoZQQqmyP/8dfcZIt 4NMd49I1X8+9UBI/7xZqYjq3fKz9ZTssq7yh42xrjq9qELmjyUeAvNy+FW78oMtInZYk9D /eDUF/AxVFT7qe0yTcepDpd9GJAcH9HwGqLvCIjMjdk3s57Zo0mp5EwSFNocj2nsdXpTr/ dWu/42/USxriyIzy9TSnovQW0XqgqbWiZXTxI1bALMo0WHLLdbu02tc/pKDC7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735836489; a=rsa-sha256; cv=none; b=H2A0arGY6tmIlBpqEUxoMrfpVdaqpAKiRqXLK1TUgKebnHHiieJIi60dM5sJuzGgscf3DT iGVXaOfFKXEhxz3+trQHhGlL3C3gTWU7hfw9v9syOGLxs5h9UlWKx7yTeJhGgQQOcAT1HL sd/032N6ffpLSXvk6Xo1rVbHfDnaLsDfZNV3+VTpx9OJwIs4XNUSSSFG4XuJztVoZkIwNf puYhv4aRx29GmzAdclhWzdwKMkS6FQ2h9+Ta0nzQt4aU0m+o4cISdQEokUY/3epjjjDIs3 mwm6t4ez9D7CCsdLn9gwBWFovDf5YdO66OmnMWW547ywGVvkup5oHakgsfGAcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YPCLx0kkWzrsb; Thu, 02 Jan 2025 16:48:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Thu, 2 Jan 2025 10:48:08 -0600 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f68ee0e7a1e8 - main - shar: add a deprecation notice To: Cy Schubert Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202501020215.5022FeQP042716@gitrepo.freebsd.org> <20250102025400.0235658A@slippy.cwsent.com> <20250102031452.A7E2B455@slippy.cwsent.com> <9156305a-c929-48cf-9619-e23bec6f6897@FreeBSD.org> <20250102162950.514AA288@slippy.cwsent.com> Content-Language: en-US From: Kyle Evans In-Reply-To: <20250102162950.514AA288@slippy.cwsent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/2/25 10:29, Cy Schubert wrote: > In message <9156305a-c929-48cf-9619-e23bec6f6897@FreeBSD.org>, Kyle Evans > write > s: >> On 1/1/25 21:14, Cy Schubert wrote: >>> In message , Kyle Evans >>> write >>> s: >>>> On 1/1/25 20:53, Cy Schubert wrote: >>>>> In message <202501020215.5022FeQP042716@gitrepo.freebsd.org>, Kyle Evans >>>>> writes >>>>> : >>>>>> The branch main has been updated by kevans: >>>>>> >>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=f68ee0e7a1e8732f725cad4ac70 >> 8e >>>> c49 >>>>>> 093782d4 >>>>>> >>>>>> commit f68ee0e7a1e8732f725cad4ac708ec49093782d4 >>>>>> Author: Kyle Evans >>>>>> AuthorDate: 2025-01-02 02:15:36 +0000 >>>>>> Commit: Kyle Evans >>>>>> CommitDate: 2025-01-02 02:15:36 +0000 >>>>>> >>>>>> shar: add a deprecation notice >>>>>> >>>>>> The shar(1) program is simple, but the fundamental idea of a sh ar >> chi >>>> ve >>>>>> is risky at best and one that we probably shouldn't be promoting a >> s >>>>>> prominently as a program in $PATH and a manpage. Let's deprecate >> and >>>>>> remove it, since the same functionality can easily be found in >>>>>> tar(1) instead. >>>>>> >>>>>> Reviewed by: emaste, philip >>>>>> Reviewed by: allanjude, brooks, delphij, des, imp, rpokala (pre >> vio >>>> us) >>>>>> MFC after: 3 days >>>>>> Differential Revision: https://reviews.freebsd.org/D48130 >>>>>> --- >>>>>> usr.bin/shar/shar.1 | 14 +++++++++++++- >>>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 >>>>>> index 903f937491dc..df97021b1bba 100644 >>>>>> --- a/usr.bin/shar/shar.1 >>>>>> +++ b/usr.bin/shar/shar.1 >>>>>> @@ -25,12 +25,24 @@ >>>>>> .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILI >> TY >>>> OF >>>>>> .\" SUCH DAMAGE. >>>>>> .\" >>>>>> -.Dd January 31, 2019 >>>>>> +.Dd January 1, 2025 >>>>>> .Dt SHAR 1 >>>>>> .Os >>>>>> .Sh NAME >>>>>> .Nm shar >>>>>> .Nd create a shell archive of files >>>>>> +.Sh DEPRECATION NOTICE >>>>>> +.Nm >>>>>> +is obsolete and may not be present in >>>>>> +.Fx 15 >>>>>> +and later. >>>>>> +Because shell archives are simultaneously data and code and are typical >> ly >>>>>> +interpreted by >>>>>> +.Xr sh 1 , >>>>>> +they can easily be trojan-horsed and pose a significant security risk t >> o >>>> use >>>>>> rs. >>>>>> +The >>>>>> +.Xr tar 1 >>>>>> +utility can still produce shar encodings of files if needed. >>>>>> .Sh SYNOPSIS >>>>>> .Nm >>>>>> .Ar >>>>>> >>>>> >>>>> We should probably point to the new port or the GNU variant in ports. >>>>> >>>> >>>> Oh, sorry, I didn't realize you had gone ahead with the port. I >>>> wouldn't normally recommend a GNU variant, would you be OK with >>>> something like: >>>> >>>> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 >>>> index df97021b1bba..6beb1e84ceab 100644 >>>> --- a/usr.bin/shar/shar.1 >>>> +++ b/usr.bin/shar/shar.1 >>>> @@ -43,6 +43,11 @@ they can easily be trojan-horsed and pose a >>>> significant security risk to users. >>>> The >>>> .Xr tar 1 >>>> utility can still produce shar encodings of files if needed. >>>> +The >>>> +.Pa sysutils/freebsd-shar >>>> +port has been created to maintain this version of >>>> +.Nm >>>> +past its deprecation in base. >>>> .Sh SYNOPSIS >>>> .Nm >>>> .Ar >>>> >>>> ? >>> >>> Yeah, that should do it. >>> >> >> Pushed as 2832af7b4ea256b18ef4dbf2ff97a50765f0609a, thanks. I'll drop >> another pointer to the port in UPDATING when it comes time to remove it. >> >> Thanks, >> >> Kyle Evans > > As an FYI, I'll patch shar with a couple of patches from NetBSD. They will > also be applied to the upstream (my github) repo for the port as well. I'll > probably push these sometime next week. > Sounds good, thanks. I don't have immediate plans for a timeline on removal beyond "probably before 15", but it would certainly be after packages are published for a version of the port that you're happy with to provide a smooth transition. Thanks, Kyle Evans