From nobody Thu Jan 02 03:21:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YNsRn1vZ7z5jttL; Thu, 02 Jan 2025 03:21:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YNsRn194mz4S5S; Thu, 2 Jan 2025 03:21:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735788069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lO+P6rYXPbVAjMAoUH+SYg98M5dZgFazRweC+T6vUA=; b=CTfwQdul8NiC0TjYEWVd0TCsL6ORdHHOcefIm5bSzyHHdRZo9saYHEB+5WumSRJx8dNlC7 oYP60dEqpnvEygfubSNimZclK4XiBg9At7/vi56JoC5s3HmMJYODxDEkrp4eNYDutjS5HI OureqgMOhCPjJRVv+aiYbR/mHzWUUoniwCGTuH63Xx9KuFeICuC/xbdVySJ+MAMyXdU6Xt vA+HzArmbGU7FPnyPbvFlCHGxl+MbF/ZKtUD5RnKXS+MonjQJzmU0JK3WfUoK6nWUCPjLS vZwsxzhXALURYTuGHXUpRPIkyfuq7I/a5GvMV0beFmpq1C+otXiDp//OAKlnVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735788069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lO+P6rYXPbVAjMAoUH+SYg98M5dZgFazRweC+T6vUA=; b=QQhwLucf7ZfXPogw0IzZ6MWClYCDg5PWeRXsbc+Y+DjrnW0D+MEdG5GRC2X1G0SLpEoOXy 9NNBNv1n1w4GU97Y/X57X8FzoCO8eqpAmySEZHxyuigJ0ABXngRoQl+hrau/IX8TXsHiy1 qCw3NlwQichUr6qEFzsRphFRg/d/b7BGVi6ZXSPWEqwQ0MQNEYGJmeobvklCD4Om+SYcS/ V8ukhqUYi3bDU+8Uf7oiVEzouqyRbN8ygXiNM5wapzFgAaH+NJCIddTMV9jCsheoY9ILzn jVUNqooMJ8ihOCV6sI4sBznqTKGAeN8a7iD5GlApaN3phprNOwd74JZlLyEHzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735788069; a=rsa-sha256; cv=none; b=H8Li35cO4rdF67vv4MPUIQ5xnUVcYduvqPbBixwOkZnTDSOWuu50FomV4IU6PCvyeErhO0 W31tfpHlRVjr9xKgzAFX4sfxV2v5Ya+iNHvwurRSQOVT1uz7d1Yt/ydFXUc4jA5Qxf+PHa YLDW/NfNqFvdV4RIHihjtNRUK7rzrMruP9G+9yN6aS/v0yn1W3QiQH42/qUxCkWt2sIVTl d40HxwWNQpXsuVAseLpP7mBur7pyqFAS4eHp0CWWWq+NDVOjY6UZTfGjhCKmMT6wk6ifLL yItfM9uXiq1/vQeDt4HVTvuGdlYFL5SZNCpb2yxPy1K5bNKDNiSbkt3iKPxwOQ== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YNsRm5GVqzb91; Thu, 2 Jan 2025 03:21:08 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <9156305a-c929-48cf-9619-e23bec6f6897@FreeBSD.org> Date: Wed, 1 Jan 2025 21:21:07 -0600 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f68ee0e7a1e8 - main - shar: add a deprecation notice To: Cy Schubert Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202501020215.5022FeQP042716@gitrepo.freebsd.org> <20250102025400.0235658A@slippy.cwsent.com> <20250102031452.A7E2B455@slippy.cwsent.com> Content-Language: en-US From: Kyle Evans In-Reply-To: <20250102031452.A7E2B455@slippy.cwsent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/1/25 21:14, Cy Schubert wrote: > In message , Kyle Evans > write > s: >> On 1/1/25 20:53, Cy Schubert wrote: >>> In message <202501020215.5022FeQP042716@gitrepo.freebsd.org>, Kyle Evans >>> writes >>> : >>>> The branch main has been updated by kevans: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=f68ee0e7a1e8732f725cad4ac708e >> c49 >>>> 093782d4 >>>> >>>> commit f68ee0e7a1e8732f725cad4ac708ec49093782d4 >>>> Author: Kyle Evans >>>> AuthorDate: 2025-01-02 02:15:36 +0000 >>>> Commit: Kyle Evans >>>> CommitDate: 2025-01-02 02:15:36 +0000 >>>> >>>> shar: add a deprecation notice >>>> >>>> The shar(1) program is simple, but the fundamental idea of a sh archi >> ve >>>> is risky at best and one that we probably shouldn't be promoting as >>>> prominently as a program in $PATH and a manpage. Let's deprecate and >>>> remove it, since the same functionality can easily be found in >>>> tar(1) instead. >>>> >>>> Reviewed by: emaste, philip >>>> Reviewed by: allanjude, brooks, delphij, des, imp, rpokala (previo >> us) >>>> MFC after: 3 days >>>> Differential Revision: https://reviews.freebsd.org/D48130 >>>> --- >>>> usr.bin/shar/shar.1 | 14 +++++++++++++- >>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 >>>> index 903f937491dc..df97021b1bba 100644 >>>> --- a/usr.bin/shar/shar.1 >>>> +++ b/usr.bin/shar/shar.1 >>>> @@ -25,12 +25,24 @@ >>>> .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY >> OF >>>> .\" SUCH DAMAGE. >>>> .\" >>>> -.Dd January 31, 2019 >>>> +.Dd January 1, 2025 >>>> .Dt SHAR 1 >>>> .Os >>>> .Sh NAME >>>> .Nm shar >>>> .Nd create a shell archive of files >>>> +.Sh DEPRECATION NOTICE >>>> +.Nm >>>> +is obsolete and may not be present in >>>> +.Fx 15 >>>> +and later. >>>> +Because shell archives are simultaneously data and code and are typically >>>> +interpreted by >>>> +.Xr sh 1 , >>>> +they can easily be trojan-horsed and pose a significant security risk to >> use >>>> rs. >>>> +The >>>> +.Xr tar 1 >>>> +utility can still produce shar encodings of files if needed. >>>> .Sh SYNOPSIS >>>> .Nm >>>> .Ar >>>> >>> >>> We should probably point to the new port or the GNU variant in ports. >>> >> >> Oh, sorry, I didn't realize you had gone ahead with the port. I >> wouldn't normally recommend a GNU variant, would you be OK with >> something like: >> >> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 >> index df97021b1bba..6beb1e84ceab 100644 >> --- a/usr.bin/shar/shar.1 >> +++ b/usr.bin/shar/shar.1 >> @@ -43,6 +43,11 @@ they can easily be trojan-horsed and pose a >> significant security risk to users. >> The >> .Xr tar 1 >> utility can still produce shar encodings of files if needed. >> +The >> +.Pa sysutils/freebsd-shar >> +port has been created to maintain this version of >> +.Nm >> +past its deprecation in base. >> .Sh SYNOPSIS >> .Nm >> .Ar >> >> ? > > Yeah, that should do it. > Pushed as 2832af7b4ea256b18ef4dbf2ff97a50765f0609a, thanks. I'll drop another pointer to the port in UPDATING when it comes time to remove it. Thanks, Kyle Evans