From nobody Thu Jan 02 03:14:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YNsJb49f6z5jtPb; Thu, 02 Jan 2025 03:14:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YNsJb30G9z4RDc; Thu, 2 Jan 2025 03:14:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTPS id T57rtLHOVyLQGTBfityrEV; Thu, 02 Jan 2025 03:14:54 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id TBfhtBwVxGvSVTBfitw4ch; Thu, 02 Jan 2025 03:14:54 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=FpSm/Hrq c=1 sm=1 tr=0 ts=677604ae a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=VdSt8ZQiCzkA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=v1B8Uev-rr01I4T1Y6oA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id B0AB3B22; Wed, 01 Jan 2025 19:14:52 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A7E2B455; Wed, 01 Jan 2025 19:14:52 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Kyle Evans cc: Cy Schubert , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: f68ee0e7a1e8 - main - shar: add a deprecation notice In-reply-to: References: <202501020215.5022FeQP042716@gitrepo.freebsd.org> <20250102025400.0235658A@slippy.cwsent.com> Comments: In-reply-to Kyle Evans message dated "Wed, 01 Jan 2025 21:12:21 -0600." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 01 Jan 2025 19:14:52 -0800 Message-Id: <20250102031452.A7E2B455@slippy.cwsent.com> X-CMAE-Envelope: MS4xfF19jVjmGv01ThJx3KnHLUbzlaNmtpZsDlUDGvTKpI/3Yod1Q/85IQhv5eA74nR4B6yX190cUtmuB/TRlw+xhD1B+embRUMNpR8gBX5Toshjio7C4SUp 4N8ua2Icga2yvSNQuzSyHpRtfYjEoiyX7CWEd1S2CYTdxcwpomELT1AuRKflnVse85kdtnrAtQEmoy1YTBf+Num06MlAlqNjLGuOntNBcwfOfZzQlZzbbeqb oGC7Z0EgOlfFpMmFlcextS5gEo/+VnTXmfwplRsMR1d+N81pXxSBpxwhlkJZKHhV2c/oegjfslZ5S64a49nTIQDb0kicdvnEm3MRQrYPql4= X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4YNsJb30G9z4RDc X-Spamd-Bar: ---- In message , Kyle Evans write s: > On 1/1/25 20:53, Cy Schubert wrote: > > In message <202501020215.5022FeQP042716@gitrepo.freebsd.org>, Kyle Evans > > writes > > : > >> The branch main has been updated by kevans: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=f68ee0e7a1e8732f725cad4ac708e > c49 > >> 093782d4 > >> > >> commit f68ee0e7a1e8732f725cad4ac708ec49093782d4 > >> Author: Kyle Evans > >> AuthorDate: 2025-01-02 02:15:36 +0000 > >> Commit: Kyle Evans > >> CommitDate: 2025-01-02 02:15:36 +0000 > >> > >> shar: add a deprecation notice > >> > >> The shar(1) program is simple, but the fundamental idea of a sh archi > ve > >> is risky at best and one that we probably shouldn't be promoting as > >> prominently as a program in $PATH and a manpage. Let's deprecate and > >> remove it, since the same functionality can easily be found in > >> tar(1) instead. > >> > >> Reviewed by: emaste, philip > >> Reviewed by: allanjude, brooks, delphij, des, imp, rpokala (previo > us) > >> MFC after: 3 days > >> Differential Revision: https://reviews.freebsd.org/D48130 > >> --- > >> usr.bin/shar/shar.1 | 14 +++++++++++++- > >> 1 file changed, 13 insertions(+), 1 deletion(-) > >> > >> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 > >> index 903f937491dc..df97021b1bba 100644 > >> --- a/usr.bin/shar/shar.1 > >> +++ b/usr.bin/shar/shar.1 > >> @@ -25,12 +25,24 @@ > >> .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY > OF > >> .\" SUCH DAMAGE. > >> .\" > >> -.Dd January 31, 2019 > >> +.Dd January 1, 2025 > >> .Dt SHAR 1 > >> .Os > >> .Sh NAME > >> .Nm shar > >> .Nd create a shell archive of files > >> +.Sh DEPRECATION NOTICE > >> +.Nm > >> +is obsolete and may not be present in > >> +.Fx 15 > >> +and later. > >> +Because shell archives are simultaneously data and code and are typically > >> +interpreted by > >> +.Xr sh 1 , > >> +they can easily be trojan-horsed and pose a significant security risk to > use > >> rs. > >> +The > >> +.Xr tar 1 > >> +utility can still produce shar encodings of files if needed. > >> .Sh SYNOPSIS > >> .Nm > >> .Ar > >> > > > > We should probably point to the new port or the GNU variant in ports. > > > > Oh, sorry, I didn't realize you had gone ahead with the port. I > wouldn't normally recommend a GNU variant, would you be OK with > something like: > > diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 > index df97021b1bba..6beb1e84ceab 100644 > --- a/usr.bin/shar/shar.1 > +++ b/usr.bin/shar/shar.1 > @@ -43,6 +43,11 @@ they can easily be trojan-horsed and pose a > significant security risk to users. > The > .Xr tar 1 > utility can still produce shar encodings of files if needed. > +The > +.Pa sysutils/freebsd-shar > +port has been created to maintain this version of > +.Nm > +past its deprecation in base. > .Sh SYNOPSIS > .Nm > .Ar > > ? Yeah, that should do it. > > Thanks, > > Kyle Evans -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0