From nobody Thu Jan 02 03:12:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YNsFf52zxz5jtLZ; Thu, 02 Jan 2025 03:12:22 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YNsFf4cVNz4Qnj; Thu, 2 Jan 2025 03:12:22 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735787542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KgHL6xEe8D93ljBnG5RTEd7N3bkB1cr+8cs9jzwKsA=; b=D9Q/NhYT0NW/09lPYcrq5QPUUR0Vesu9EBpg1il2FIpzT8NFs22HVeNVwsQTHY9w0U5FZ5 WWVlpybmRspvaTPs0+9Vv2TmFuQolzMpCAxLqDTOCv9zf/4az7rxT3bx+cimOj5143OT3a 0QPkahtsySNra/DXG467dpp5xvROQU9BcQZp6EnnqIT/zM1NGObEQ6zXziZR4v2ZUltTM3 eG/ujqxIK/jjfBE/AjIvCmMadWefOJZI7o9XJyd4ijT4WCDCrksJNBOVkDii5Otm0Zl1ws 3sukTM0DQ+TDLmxc4rOoXngKa46vQKk9RH5KE7vEXTWXy8PON8Ns2JqWZrJIjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735787542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KgHL6xEe8D93ljBnG5RTEd7N3bkB1cr+8cs9jzwKsA=; b=btU8TBesNY/gv5V4ni/qqKWKqjZJ76lv8xC0mtlEQJXZBTsF8FWakCIwWcjnxceYuZR/tc yvVsJJFDh2oVW9yKZVoDfPlx9CnyWTpw7Ic5IG3d8hV/1YycSVRBfNhfg6OaH2dKYxgN4v fHABnkYujD/9+8nY3aGFBpL9adR5FmWAVeNpKSE23xQDBINJ6U9tQo/zfhh1Kt18QOXtXA oM3IjCT1J4vmioXz68/oZEf6xM04Yzj1yZ2eozPIVFY7HA7iLjkNf5MVrXMhATSsjue1xD 7pLNJ5YEkhbh4cWdK77t1M/F7vS2F4dYWpKRhcyoOwuv5kNiG1Zr4NzRfAn4fQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735787542; a=rsa-sha256; cv=none; b=s2tWE/p7NYCoNQwrnwD/jtrhQmqFHw+47wYhsnq2QXHjBvAaEWbLZrZfTOzaq8rV6mlBfm K+FuIOlSeIsDR9ARYN9rT6V0Rtd/ohuX1X2ugszB76bLn9IItztpSouacji7hEhhOX71bq SghKfHAjR41iNDemU8zwKxsNb+JpE+uG+dsoTOVxf/uvWTdeBI0coW7fBXn43JlUHpFmGF RfOPPmOkL71J49weijfhLQ3VNgzOQQD850jpyuqD18wbwlUHD3khhbAdo90h/TUgPjX3Sr e/ovODYoLdyqLzAEMz6ZOH4oimlwTpdNSLe7cSUwpSApiYD7mwcR1+AF9v4dVw== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YNsFf1g5gzcsL; Thu, 2 Jan 2025 03:12:22 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Wed, 1 Jan 2025 21:12:21 -0600 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f68ee0e7a1e8 - main - shar: add a deprecation notice To: Cy Schubert Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202501020215.5022FeQP042716@gitrepo.freebsd.org> <20250102025400.0235658A@slippy.cwsent.com> Content-Language: en-US From: Kyle Evans In-Reply-To: <20250102025400.0235658A@slippy.cwsent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/1/25 20:53, Cy Schubert wrote: > In message <202501020215.5022FeQP042716@gitrepo.freebsd.org>, Kyle Evans > writes > : >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=f68ee0e7a1e8732f725cad4ac708ec49 >> 093782d4 >> >> commit f68ee0e7a1e8732f725cad4ac708ec49093782d4 >> Author: Kyle Evans >> AuthorDate: 2025-01-02 02:15:36 +0000 >> Commit: Kyle Evans >> CommitDate: 2025-01-02 02:15:36 +0000 >> >> shar: add a deprecation notice >> >> The shar(1) program is simple, but the fundamental idea of a sh archive >> is risky at best and one that we probably shouldn't be promoting as >> prominently as a program in $PATH and a manpage. Let's deprecate and >> remove it, since the same functionality can easily be found in >> tar(1) instead. >> >> Reviewed by: emaste, philip >> Reviewed by: allanjude, brooks, delphij, des, imp, rpokala (previous) >> MFC after: 3 days >> Differential Revision: https://reviews.freebsd.org/D48130 >> --- >> usr.bin/shar/shar.1 | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 >> index 903f937491dc..df97021b1bba 100644 >> --- a/usr.bin/shar/shar.1 >> +++ b/usr.bin/shar/shar.1 >> @@ -25,12 +25,24 @@ >> .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >> .\" SUCH DAMAGE. >> .\" >> -.Dd January 31, 2019 >> +.Dd January 1, 2025 >> .Dt SHAR 1 >> .Os >> .Sh NAME >> .Nm shar >> .Nd create a shell archive of files >> +.Sh DEPRECATION NOTICE >> +.Nm >> +is obsolete and may not be present in >> +.Fx 15 >> +and later. >> +Because shell archives are simultaneously data and code and are typically >> +interpreted by >> +.Xr sh 1 , >> +they can easily be trojan-horsed and pose a significant security risk to use >> rs. >> +The >> +.Xr tar 1 >> +utility can still produce shar encodings of files if needed. >> .Sh SYNOPSIS >> .Nm >> .Ar >> > > We should probably point to the new port or the GNU variant in ports. > Oh, sorry, I didn't realize you had gone ahead with the port. I wouldn't normally recommend a GNU variant, would you be OK with something like: diff --git a/usr.bin/shar/shar.1 b/usr.bin/shar/shar.1 index df97021b1bba..6beb1e84ceab 100644 --- a/usr.bin/shar/shar.1 +++ b/usr.bin/shar/shar.1 @@ -43,6 +43,11 @@ they can easily be trojan-horsed and pose a significant security risk to users. The .Xr tar 1 utility can still produce shar encodings of files if needed. +The +.Pa sysutils/freebsd-shar +port has been created to maintain this version of +.Nm +past its deprecation in base. .Sh SYNOPSIS .Nm .Ar ? Thanks, Kyle Evans