git: 381956e26756 - main - ntp: ntpd does not connect to NTP server with link local IPv6 address

From: Cy Schubert <cy_at_FreeBSD.org>
Date: Tue, 18 Feb 2025 17:12:02 UTC
The branch main has been updated by cy:

URL: https://cgit.FreeBSD.org/src/commit/?id=381956e267569031883a516e10446c29490ee41d

commit 381956e267569031883a516e10446c29490ee41d
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2025-01-31 22:25:14 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2025-02-18 17:11:45 +0000

    ntp: ntpd does not connect to NTP server with link local IPv6 address
    
    Upstream bug 3943 (https://bugs.ntp.org/show_bug.cgi?id=3943) discusses:
    
    Starting with 4.2.8p18 ntp does not synchronize or even connect to the
    configured NTP server any more. ntp stays in .INIT. state indefinitely
    and checking the network traffic shows that ntp does not attempt to
    contact the NTP server.
    
    This is regression introduced by the fix for upstream bug 3913. This
    is a similar bug I reported upstream (ntp bug 3841).
    
    MFC after:      1 month
---
 contrib/ntp/ntpd/ntp_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c
index 9d79fe493d9b..0df543c5af04 100644
--- a/contrib/ntp/ntpd/ntp_io.c
+++ b/contrib/ntp/ntpd/ntp_io.c
@@ -3205,7 +3205,7 @@ sendpkt(
 	}
 
 	do {
-		if (INT_LL_OF_GLOB & src->flags) {
+		if (ismcast && INT_LL_OF_GLOB & src->flags) {
 			/* avoid duplicate multicasts on same IPv6 net */
 			goto loop;
 		}