Re: git: 1ac6ea8a0251 - main - kerberos5, libcom_err, others: append to LDFLAGS instead of replacing

From: Chuck Silvers <chuq_at_chuq.com>
Date: Sun, 06 Apr 2025 01:37:57 UTC
On Sat, Apr 05, 2025 at 06:27:31PM -0700, Cy Schubert wrote:
> In message <202504052120.535LKCpL016160@gitrepo.freebsd.org>, Chuck Silvers 
> wri
> tes:
> > The branch main has been updated by chs:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=1ac6ea8a0251243d34f0ede2315b8f2b
> > 4393080d
> >
> > commit 1ac6ea8a0251243d34f0ede2315b8f2b4393080d
> > Author:     Chuck Silvers <chs@FreeBSD.org>
> > AuthorDate: 2025-04-05 21:18:35 +0000
> > Commit:     Chuck Silvers <chs@FreeBSD.org>
> > CommitDate: 2025-04-05 21:19:57 +0000
> >
> >     kerberos5, libcom_err, others: append to LDFLAGS instead of replacing
> >     
> >     Reviewed by:    imp, emaste
> >     Differential Revision:  https://reviews.freebsd.org/D49548
> > ---
> >  kerberos5/lib/libasn1/Makefile            | 2 +-
> >  kerberos5/lib/libgssapi_krb5/Makefile     | 2 +-
> >  kerberos5/lib/libgssapi_ntlm/Makefile     | 2 +-
> >  kerberos5/lib/libgssapi_spnego/Makefile   | 2 +-
> >  kerberos5/lib/libhdb/Makefile             | 2 +-
> >  kerberos5/lib/libheimbase/Makefile        | 2 +-
> >  kerberos5/lib/libheimntlm/Makefile        | 2 +-
> >  kerberos5/lib/libhx509/Makefile           | 2 +-
> >  kerberos5/lib/libkadm5clnt/Makefile       | 2 +-
> >  kerberos5/lib/libkadm5srv/Makefile        | 2 +-
> >  kerberos5/lib/libkafs5/Makefile           | 2 +-
> >  kerberos5/lib/libkdc/Makefile             | 2 +-
> >  kerberos5/lib/libkrb5/Makefile            | 2 +-
> >  kerberos5/lib/libwind/Makefile            | 2 +-
> >  kerberos5/libexec/digest-service/Makefile | 2 +-
> >  kerberos5/libexec/hprop/Makefile          | 2 +-
> >  kerberos5/libexec/hpropd/Makefile         | 2 +-
> >  kerberos5/libexec/ipropd-master/Makefile  | 2 +-
> >  kerberos5/libexec/ipropd-slave/Makefile   | 2 +-
> >  kerberos5/libexec/kadmind/Makefile        | 2 +-
> >  kerberos5/libexec/kcm/Makefile            | 2 +-
> >  kerberos5/libexec/kdc/Makefile            | 2 +-
> >  kerberos5/libexec/kpasswdd/Makefile       | 2 +-
> >  kerberos5/usr.bin/kadmin/Makefile         | 2 +-
> >  kerberos5/usr.bin/kpasswd/Makefile        | 2 +-
> >  kerberos5/usr.sbin/iprop-log/Makefile     | 2 +-
> >  kerberos5/usr.sbin/kstash/Makefile        | 2 +-
> >  lib/libcom_err/Makefile                   | 2 +-
> >  tools/regression/tls/ttls3/Makefile       | 2 +-
> >  tools/tools/net80211/w00t/Makefile.inc    | 2 +-
> >  30 files changed, 30 insertions(+), 30 deletions(-)
> >
> 
> What was the reason for this?


this is so that things added to LDFLAGS by eg. /etc/make.conf or /etc/src.conf
are not lost just because an individual makefile wants to add something to
LDFLAGS as well.

-Chuck