Re: git: 74a6f2a76b32 - main - iwx: Shorten log code field

On Fri, Apr 04, 2025 at 09:41:27PM +0100, Tom Jones wrote:
> Sorry for the breakage, something has broken in my mail filters so direct mails to me aren’t landing in my inbox when also sent to src-commits (just the folder for commits). 
> 
> I’ll look at this as soon as I can (probably not until Monday).  If you want to remove iwx from the build (or just i386 in the meantime) please do. 

I removed iwx from the i386 build yesterday:
https://cgit.freebsd.org/src/commit/?id=296b60793df6ae855ba414fbf4823467e9615b2f

> 
> On Thu, Apr 3, 2025, at 18:38, Colin Percival wrote:
> > On 4/3/25 00:07, Tom Jones wrote:
> >> commit 74a6f2a76b32e01d05c4ad71897bd3a6831e703e
> >>      
> >>      This fixes the build on i386.
> >
> > You sure about that?
> >
> > /usr/src/sys/dev/iwx/if_iwx.c:5762:22: error: shift count >= width of type 
> > [-Werror,-Wshift-count-overflow]
> >   5762 |         if (data->cmd_paddr >> 32 != (data->cmd_paddr + 
> > le32toh(desc->tbs[0].tb_len)) >> 32)
> >        |                             ^  ~~
> > /usr/src/sys/dev/iwx/if_iwx.c:5762:80: error: shift count >= width of type 
> > [-Werror,-Wshift-count-overflow]
> >   5762 |         if (data->cmd_paddr >> 32 != (data->cmd_paddr + 
> > le32toh(desc->tbs[0].tb_len)) >> 32)
> >        | 
> >                  ^  ~~
> > /usr/src/sys/dev/iwx/if_iwx.c:5769:22: error: shift count >= width of type 
> > [-Werror,-Wshift-count-overflow]
> >   5769 |         if (data->cmd_paddr >> 32 != (data->cmd_paddr + 
> > le32toh(desc->tbs[1].tb_len)) >> 32)
> >        |                             ^  ~~
> > /usr/src/sys/dev/iwx/if_iwx.c:5769:80: error: shift count >= width of type 
> > [-Werror,-Wshift-count-overflow]
> >   5769 |         if (data->cmd_paddr >> 32 != (data->cmd_paddr + 
> > le32toh(desc->tbs[1].tb_len)) >> 32)
> >        | 
> >                  ^  ~~
> > /usr/src/sys/dev/iwx/if_iwx.c:5778:23: error: shift count >= width of type 
> > [-Werror,-Wshift-count-overflow]
> >   5778 |                 if (data->cmd_paddr >> 32 != (data->cmd_paddr + 
> > le32toh(desc->tbs[i + 2].tb_len)) >> 32)
> >        |                                     ^  ~~
> > /usr/src/sys/dev/iwx/if_iwx.c:5778:85: error: shift count >= width of type 
> > [-Werror,-Wshift-count-overflow]
> >   5778 |                 if (data->cmd_paddr >> 32 != (data->cmd_paddr + 
> > le32toh(desc->tbs[i + 2].tb_len)) >> 32)
> >        | 
> >                              ^  ~~
> > /usr/src/sys/dev/iwx/if_iwx.c:10971:47: error: format specifies type 'unsigned 
> > long' but the argument has type 'uint64_t' (aka 'unsigned long long') 
> > [-Werror,-Wformat]
> >   10971 |         DPRINTF(("%s: k->wk_keytsc=%lu\n", __func__, k->wk_keytsc));
> >         |                                    ~~~               ^~~~~~~~~~~~
> >         |                                    %llu
> >
> > -- 
> > Colin Percival
> > FreeBSD Release Engineering Lead & EC2 platform maintainer
> > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
> 
> -- 
> - Tom
>