git: 61c010f3b35e - main - tests/netinet: enable test against kern/189088

From: Gleb Smirnoff <glebius_at_FreeBSD.org>
Date: Wed, 02 Apr 2025 19:44:26 UTC
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=61c010f3b35e867166a2be5906a71b9cbcedf7db

commit 61c010f3b35e867166a2be5906a71b9cbcedf7db
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2025-04-02 19:44:14 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2025-04-02 19:44:14 +0000

    tests/netinet: enable test against kern/189088
    
    This test was created together with the bug, however after fixing commit
    9fdbf7eef5c0 it was not enabled.  Also, the test has a mistake: the second
    netstat check would fail cause it would see the route remaining from the
    first run.  Workaround that by running the second run in a separate pair
    of fibs to the first one.
---
 tests/sys/netinet/fibs_test.sh | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/sys/netinet/fibs_test.sh b/tests/sys/netinet/fibs_test.sh
index b58a45b26f3e..5fe8f7d87641 100644
--- a/tests/sys/netinet/fibs_test.sh
+++ b/tests/sys/netinet/fibs_test.sh
@@ -352,14 +352,13 @@ same_ip_multiple_ifaces_head()
 }
 same_ip_multiple_ifaces_body()
 {
-	atf_expect_fail "kern/189088 Assigning the same IP to multiple interfaces in different FIBs creates a host route for only one"
 	ADDR="192.0.2.2"
 	MASK0="24"
 	MASK1="32"
 
 	# Unlike most of the tests in this file, this is applicable regardless
 	# of net.add_addr_allfibs
-	get_fibs 2
+	get_fibs 4
 
 	# Setup the interfaces, then remove one alias.  It should not panic.
 	setup_tap ${FIB0} inet ${ADDR} ${MASK0}
@@ -371,13 +370,13 @@ same_ip_multiple_ifaces_body()
 		setfib ${FIB1} netstat -rn -f inet
 
 	# Do it again, in the opposite order.  It should not panic.
-	setup_tap ${FIB0} inet ${ADDR} ${MASK0}
+	setup_tap ${FIB2} inet ${ADDR} ${MASK0}
 	TAP0=${TAP}
-	setup_tap ${FIB1} inet ${ADDR} ${MASK1}
+	setup_tap ${FIB3} inet ${ADDR} ${MASK1}
 	TAP1=${TAP}
 	ifconfig ${TAP0} -alias ${ADDR}
 	atf_check -o not-match:"^${ADDR}[[:space:]]" \
-		setfib ${FIB0} netstat -rn -f inet
+		setfib ${FIB2} netstat -rn -f inet
 }
 same_ip_multiple_ifaces_cleanup()
 {