From nobody Mon Sep 30 23:37:23 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XHctX4lvpz5Xqpm; Mon, 30 Sep 2024 23:37:24 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XHctX3wBRz4fDn; Mon, 30 Sep 2024 23:37:24 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727739444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PCWTXA8r26Zg3msSfBDFQKZsrzpEG5vKRhLUwgSY7YU=; b=r2vFf+uYdRXFyoRfalWrrJDzZLfJPtYfPPVx77V08zgU0pZLZfKjGS99ke9x01BSA83Nd3 wDDXiGVdXl+GCXaJiFFxdPwbdiKPZEv8q743sDK2iJwucNg33V8Paid/gK33i1KwPNIXWg IOhT1YzS3wnkRNV6SfM03z2axK8q8ON2KTK20reopzq094WS3HLg5cvbcVBOVR0fReaaJW jbCCJlToc43aq3VQcis/UyjNczRC3+XdzfX4IBrKeO0Yh/akYFxIlaj6vRmuCbwoHXn0nP o3AGxuldws/Y7948QEbh+vbS3gGSas/025K7Qb3Q1jxDujkcq9eak8bahiT26w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727739444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PCWTXA8r26Zg3msSfBDFQKZsrzpEG5vKRhLUwgSY7YU=; b=vBAUSPVU6dPcUTEXMwQor7+RZxUWCzGzzO3q/RrpfV8Ko8TVAcbDLmhZ3Xk1Xza6zqMPf8 5/YRzKWOSaSxleqOlDqped40xN22FVJzl7YYjoXKRUeupo3hL5j1kyVLoaqOSi3udWQD/3 rN10j7hZlNFg+WWYLzBtje+s6OOIi8k62A/rifX3lPRczaKX1XNiSgmKSuOoH9pQJIIMJG /sa9Bgqw8FD91ax3kyWC0zJDOh9JyNvgMlDoUizuqk5yx+5Np7x48qn5B+dL3Pc/GO/Wd4 ieAMeVbrlp5R3kSV1n9WrAcA5aEcpS0SXyLIT7HHZ8z//diU8gnfilMK9OSKPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727739444; a=rsa-sha256; cv=none; b=WUaYL8LjHTukLo/69IWVsp6sQRyKByBumAWNCR2ucxheczT8O+bGmEk1xjKtjYNdZ4RDMd FFmh4HPgrHs1ICnGFqBGQToagnNpG1FR6JJo0w5KozsfVyEA8MVaZ/kYPovPrnvTWjh+9Q wVqrNGmcDMoy7t4G/fdo6hvupQ5Y172254Eh4Hp/jfFy19zqCl9iGtmuDEFG6dqBxJtTAq d0WQJgSzWESZCTWZzwmTs5hpToIGsmS8ZBXIGITb3VreV7QHQQHWIvNqpexi3QbuKyIXdx e4kMdUl0Rj51FTm10C4aylkuXiiyp/0lmUXP8Ie0LMmPXU53lIk+wjvZnEH+CQ== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XHctX3FnNzXjp; Mon, 30 Sep 2024 23:37:24 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 008D93C019B; Mon, 30 Sep 2024 23:37:23 +0000 (UTC) Date: Mon, 30 Sep 2024 23:37:23 +0000 From: Brooks Davis To: Antoine Brodin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1235d276b78a - main - lib{c,sys}: stop exposing errno symbol Message-ID: References: <202409271933.48RJX0dH066668@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Sep 30, 2024 at 03:53:01PM +0000, Brooks Davis wrote: > On Mon, Sep 30, 2024 at 08:33:18AM +0200, Antoine Brodin wrote: > > On Fri, Sep 27, 2024 at 9:33???PM Brooks Davis wrote: > > > > > > The branch main has been updated by brooks: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1235d276b78a769bded01d51c9bf3cdc480db9fb > > > > > > commit 1235d276b78a769bded01d51c9bf3cdc480db9fb > > > Author: Brooks Davis > > > AuthorDate: 2024-09-27 19:27:46 +0000 > > > Commit: Brooks Davis > > > CommitDate: 2024-09-27 19:27:46 +0000 > > > > > > lib{c,sys}: stop exposing errno symbol > > > > > > Officially since C11 (and in reality FreeBSD since 3.0 with commit > > > 1b46cb523df3) errno has been defined to be a macro. Rename the symbol > > > to __libsys_errno and move it to FBSDprivate_1.0 and confine it entierly > > > to libsys for use by libthr. Add a FBSD_1.0 compat symbol for existing > > > binaries that were incorrectly linked to the errno symbol during > > > libc.so.7's lifetime. > > > > > > This deliberately breaks linking software that directly links to errno. > > > Such software is broken and will fail in surprising ways if it becomes > > > threaded (e.g., if it triggers loading of a pam or nss module that > > > uses threads.) > > > > > > Reviewed by: kib > > > Differential Revision: https://reviews.freebsd.org/D46780 > > > --- > > > lib/libsys/Makefile | 2 ++ > > > lib/libsys/Symbol.map | 1 + > > > lib/libsys/Symbol.sys.map | 1 - > > > lib/libsys/__error.c | 10 +++++----- > > > lib/libthr/sys/thr_error.c | 5 ++--- > > > lib/libthr/thread/thr_rtld.c | 7 +++---- > > > 6 files changed, 13 insertions(+), 13 deletions(-) > > > > Hello, > > > > This breaks some ports: > > Thank you for the list (that's more than I expected). I'll work on > updates. The fix is to replace I've updated all the maintainer-less ports. The majority were djbware. I was quite tempted to set deprecation notices as most produce many warnings with a modern compiler. These warning are easy to fix, but it's clear no one cares. For ports with maintainers I've filed bugs with fixes and pushed them all to https://github.com/brooksdavis/freebsd-ports/tree/errno-fixes -- Brooks