From nobody Wed Sep 25 20:32:00 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XDT1B4dBMz5Xgm3 for ; Wed, 25 Sep 2024 20:32:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XDT195LYtz55MN for ; Wed, 25 Sep 2024 20:32:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=bHyFDkJu; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::102c) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2db89fb53f9so232668a91.3 for ; Wed, 25 Sep 2024 13:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1727296332; x=1727901132; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qVkFRTJmV+iAZaxCJrOU9ZNx+wHe6P7z4v1yLX93zV0=; b=bHyFDkJu62duRGATSpYzQ1TeLrTj62W+SKWQSyUPgGUs1tUkXYImdK8/XiBCJogSqd y9d5vWqeW0qsf8ym3Zi59x4Q7Aq3tt20Q6aPzpE8UJFzGWO/RxOi0bnDE4zvY8l7+paj eCiMYLRFFQ5et9cJe8x5Zi742Dth5hpVpgrfUp0mfklpJKeslT88ERVtYJGQ8ndpEG4D ABYAoCY0r6hf8zt3ekJUouOz0twpV115mn5UYSZFjIgWnLWKA4puQn8i4Goo37Ex2syo X0bGnaKiUyFZNvfKz6ZtKk7vSNc+PUapwSJTro8BWexfx8bsT7HdUUZAbJLFCIy+3PCX qC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727296332; x=1727901132; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qVkFRTJmV+iAZaxCJrOU9ZNx+wHe6P7z4v1yLX93zV0=; b=sKLK+b9ftaIv4lgpOpxrN6Rv6YEH3Wz8cmnjJ9T5eRX4aD0XdKMBJkjZU4IyPPIxDP yjwHk0UxconG7RZwJcfiGHkap1L/2Xd1IANr47ViLYvX1wCa+/yE5IlsqZtJO5xGHmYx SntOlRnYKFDiBOYQU7+M+lIZoPhIsosYW5aJw8HeAkCuUyhxf9nR1RcSi4CPgEA2bFlb 4zHMfeHzb8x6fk6Uk/XLwoeqiaRIaOxyGdLuYbym25wuC8dJJuqZ8JIEWZmB1ez5AUPP 8rdHE1Vhg7Ei7rMywO3IRbHCb/j6SqLGQh8HsjDRMpDgUPG9nAF8HVc2kPhjm7gOq716 JrOA== X-Forwarded-Encrypted: i=1; AJvYcCUrOq/38rFeWgU+dTnUMsvwQsoM3MN+87X6YuVr5BhdPHZySGgWQ+UGAeAQ8IkvgilSX5FqNcDNprx5BbsfZfGjuzyh1g==@freebsd.org X-Gm-Message-State: AOJu0YzycsjkQ+PZlb4o1ye7jY7PH+biuiy4PAxYxlhcUWk/oJTLaZ9y 2eFFcfiKSHtcEte9vqNMgwXjXV8HJ9Ii4bEVEquLAI/d1UE6sZQKVpIJHtChB5I7m34TXU+AzQI zCm36OBjf+syLMJocIVTPf9XPwbLrYqPR0Pce8hUBmqTYR+RK X-Google-Smtp-Source: AGHT+IEYNnSyu8bCiZxE1z8EtaHQPnEfRIuNpkGtJai56/eHX1jvcDFYIOK4Sc3w+iHGA89uyj3pFfaS4V3z6JTjVjw= X-Received: by 2002:a17:90b:890:b0:2e0:77aa:fecf with SMTP id 98e67ed59e1d1-2e077aaffa5mr2598602a91.41.1727296332359; Wed, 25 Sep 2024 13:32:12 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <1B971CC2-DD1F-488B-A80B-98EF29256D50.ref@yahoo.com> <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com> In-Reply-To: From: Warner Losh Date: Wed, 25 Sep 2024 14:32:00 -0600 Message-ID: Subject: Re: git: 85918beb387f - main - intrng: Add support for multiple interrupt roots To: Ayrton Munoz Cc: Mark Millard , "" Content-Type: multipart/alternative; boundary="0000000000005008030622f7845b" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+]; TO_DN_ALL(0.00)[]; FREEMAIL_CC(0.00)[yahoo.com,freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102c:from] X-Rspamd-Queue-Id: 4XDT195LYtz55MN X-Spamd-Bar: -- --0000000000005008030622f7845b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable If there are any tweaks, we can do those. It will be way easier than the initial push. But if not, that's fine too. Warner On Wed, Sep 25, 2024, 2:28=E2=80=AFPM Ayrton Munoz = wrote: > Warner and mmel just got to the PR before I got a chance to address a > few tiny nits but what got committed is fine with me. Thanks for > double checking Mark! > > > On Sun, Sep 22, 2024 at 2:19=E2=80=AFPM Warner Losh wrot= e: > > > > > > > > On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard = wrote: > >> > >> From: Warner Losh wrote on > >> Date: Sun, 22 Sep 2024 13:19:21 UTC : > >> > >> > The branch main has been updated by imp: > >> > > >> > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a6c613801fb= 9761ff1e2 > >> > > >> > commit 85918beb387f179abc93a6c613801fb9761ff1e2 > >> > Author: Ayrton Munoz > >> > AuthorDate: 2024-07-21 18:10:20 +0000 > >> > Commit: Warner Losh > >> > CommitDate: 2024-09-22 13:18:34 +0000 > >> > > >> > intrng: Add support for multiple interrupt roots > >> > > >> > Different types of interrupts may require using different exception > >> > vectors so this commit adds support multiple interrupt roots to hand= le > >> > these cases. Archs may opt-in to multiple interrupt roots by definin= g > >> > INTR_ROOT_NUM as the number of roots in their intr.h. Based off > >> > https://reviews.freebsd.org/D40161. > >> > > >> > Signed-off-by: Ayrton Munoz > >> > Co-authored-by: Kyle Evans > >> > Co-authored-by: Andrew Turner > >> > Reviewed-by: imp,mmel,mhorne > >> > Pull-Request: https://github.com/freebsd/freebsd-src/pull/1363 > >> . . . > >> > +/* > >> > + * Archs may define multiple roots with INTR_ROOT_NUM to support > different kinds > >> > + * of interrupts (e.g. arm64 FIQs which use a different exception > vector than > >> > + * IRQs). > >> > + */ > >> > +#if !defined(INTR_ROOT_NUM) > >> > +#define INTR_ROOT_NUM 1 > >> > +#endif > >> > + > >> > >> . . . > >> > >> When I was reading the: > >> > >> https://github.com/freebsd/freebsd-src/pull/1363 > >> > >> conversation I saw: > >> > >> -#define INTR_ROOT_NUM 2 > >> +#define INTR_ROOT_COUNT 2 > >> > >> and related discussion with 2 thumbs up, including one by ayrtonm. > >> > >> A similar point goes for: > >> > >> -void *arg, uint32_t rootnum) > >> +void *arg, uint32_t roottype) > >> > >> with another ayrtonm thumbs up at the end. (I've not checked > >> if there are more distinctions.) > >> > >> Such leaves me wondering if what was committed was actually > >> the final intended code: Is it? > > > > > > I thought it was... If we need a fllowup, i can do that... > > > > Warner > > > >> =3D=3D=3D > >> Mark Millard > >> marklmi at yahoo.com > >> > --0000000000005008030622f7845b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If there are any tweaks, we can do those. It will be way = easier than the initial push. But if not, that's=C2=A0fine too.

Warner=C2=A0

On Wed, Sep 25, 202= 4, 2:28=E2=80=AFPM Ayrton Munoz <a.munoz3327@gmail.com> wrote:
Warner and mmel just got to the PR before I got a chance to address a few tiny nits but what got committed is fine with me. Thanks for
double checking Mark!


On Sun, Sep 22, 2024 at 2:19=E2=80=AFPM Warner Losh <imp@bsdimp.com> = wrote:
>
>
>
> On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard <marklmi@yahoo.co= m> wrote:
>>
>> From: Warner Losh <imp_at_FreeBSD.org> wrote on
>> Date: Sun, 22 Sep 2024 13:19:21 UTC :
>>
>> > The branch main has been updated by imp:
>> >
>> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a= 6c613801fb9761ff1e2
>> >
>> > commit 85918beb387f179abc93a6c613801fb9761ff1e2
>> > Author: Ayrton Munoz <a.munoz3327@gmail.com>
>> > AuthorDate: 2024-07-21 18:10:20 +0000
>> > Commit: Warner Losh <imp@FreeBSD.org>
>> > CommitDate: 2024-09-22 13:18:34 +0000
>> >
>> > intrng: Add support for multiple interrupt roots
>> >
>> > Different types of interrupts may require using different exc= eption
>> > vectors so this commit adds support multiple interrupt roots = to handle
>> > these cases. Archs may opt-in to multiple interrupt roots by = defining
>> > INTR_ROOT_NUM as the number of roots in their intr.h. Based o= ff
>> > https://reviews.freebsd.org/D40161. >> >
>> > Signed-off-by: Ayrton Munoz <a.munoz3327@gmail.com&= gt;
>> > Co-authored-by: Kyle Evans <kevans@FreeBSD.org>
>> > Co-authored-by: Andrew Turner <andrew@FreeBSD.org>
>> > Reviewed-by: imp,mmel,mhorne
>> > Pull-Request: https://githu= b.com/freebsd/freebsd-src/pull/1363
>> . . .
>> > +/*
>> > + * Archs may define multiple roots with INTR_ROOT_NUM to sup= port different kinds
>> > + * of interrupts (e.g. arm64 FIQs which use a different exce= ption vector than
>> > + * IRQs).
>> > + */
>> > +#if !defined(INTR_ROOT_NUM)
>> > +#define INTR_ROOT_NUM 1
>> > +#endif
>> > +
>>
>> . . .
>>
>> When I was reading the:
>>
>> https://github.com/freebsd/fre= ebsd-src/pull/1363
>>
>> conversation I saw:
>>
>> -#define INTR_ROOT_NUM 2
>> +#define INTR_ROOT_COUNT 2
>>
>> and related discussion with 2 thumbs up, including one by ayrtonm.=
>>
>> A similar point goes for:
>>
>> -void *arg, uint32_t rootnum)
>> +void *arg, uint32_t roottype)
>>
>> with another ayrtonm thumbs up at the end. (I've not checked >> if there are more distinctions.)
>>
>> Such leaves me wondering if what was committed was actually
>> the final intended code: Is it?
>
>
> I thought it was... If we need a fllowup, i can do that...
>
> Warner
>
>> =3D=3D=3D
>> Mark Millard
>> marklmi at yahoo.com
>>
--0000000000005008030622f7845b--