From nobody Wed Sep 25 20:34:58 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XDSxP4dM5z5XgFC for ; Wed, 25 Sep 2024 20:28:57 +0000 (UTC) (envelope-from a.munoz3327@gmail.com) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XDSxN3KzKz54X7 for ; Wed, 25 Sep 2024 20:28:56 +0000 (UTC) (envelope-from a.munoz3327@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vq1oNKxg; spf=pass (mx1.freebsd.org: domain of a.munoz3327@gmail.com designates 2a00:1450:4864:20::62d as permitted sender) smtp.mailfrom=a.munoz3327@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a8d2daa2262so29191766b.1 for ; Wed, 25 Sep 2024 13:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727296135; x=1727900935; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YMyY/nK1z9b/96HL9Na1B/2RZetlvykHGWV7m0XVa0c=; b=Vq1oNKxgR2VbvtkuSiF1N+W+xhdAcF+oir7895sTFCbkNZzjX/NFEgUZbd/RI/1l4t pXjCKMsgtVdu9sinddWUdApMs4yRWV2k++TJ4p0UIEOhbJv/RtfrXmCtAUG6cMYYCo5b m8tehLpEjvkkQ9SP294fMXmJMxd++Hg2wgyaUr1YibblAHi6gmNb0CIHgyKz/4VC37HO LLnm+NFzqG9Q4U8YH5ff87w+nZ8w/uYsbef5R+sR7NxI+C3wCRQzngw9aRzrmNYN2SaK Qv0FtxCyCuQ9rGizFZTVwweVf35RJ94ytUZUd9S8bqkB2bzVm6x5l+gQYSerkJwfPK85 zn+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727296135; x=1727900935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YMyY/nK1z9b/96HL9Na1B/2RZetlvykHGWV7m0XVa0c=; b=kBdF2XuaC8vrhp3VAdI54Rfj8QqwSY4Fl/Nz1vm+FDPmlY713SZ2bf5Ka4/vzzT5wj CX1dvHPJjyXPshFXDE5+7yNFExw3rwmDwjdMf5AmR9nDGHa4Q9QbDXSLT7g6ZCLHNpuz haHpVYopE21YwS3iU2NikCfyc/PSTYd2QRwrWELekTjvsUFJOx404ua0u3caTIp16gic 6ehISdWGWZL/eFCF6/y9JZpAED71OXKbTB8TJqlmoNXCEql21i5pF0wtLMYD/VoIXrZc 5jqt/P5rlLfID8o1c7Mo9pOnGglC5Akf1GdwWsFV4e2irvtnjngVL+DveW9To/wWBHdB s5eA== X-Forwarded-Encrypted: i=1; AJvYcCWRwt0iYP/YzYyAtbDpvkOpuAe3NqmMGK9sZJ0d8jFLV+ruVsnp/Y8dHhDRlftVIjDIDNTaRMAj4SCRiRaqxcIiLWpzMg==@freebsd.org X-Gm-Message-State: AOJu0YzjBqgdLOe7Xq4TphE7xA/O3ObNHxHEWzYvLCxc/JfJqnd6sAYd WJZctXozR6LzohRlLzrPdBrIxmLhtXegeKxRRUQRaf7a3IhPtmUFMMCEfDs9R1o7QyAuR8dd/wd 4T8t/4C8CGVAqBoEsEJ6c/BW9IOc= X-Google-Smtp-Source: AGHT+IHPOrvj8FF5Ii2TzBRjsKiyUDSJCqhVlLzJkMU/HufEZpkQc1hF23EP2ySqPAkOQZW7DLairv9igo2GgiZTNto= X-Received: by 2002:a17:907:d587:b0:a8d:439d:5c3c with SMTP id a640c23a62f3a-a93a0320878mr384420466b.8.1727296135246; Wed, 25 Sep 2024 13:28:55 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <1B971CC2-DD1F-488B-A80B-98EF29256D50.ref@yahoo.com> <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com> In-Reply-To: From: Ayrton Munoz Date: Wed, 25 Sep 2024 16:34:58 -0400 Message-ID: Subject: Re: git: 85918beb387f - main - intrng: Add support for multiple interrupt roots To: Warner Losh Cc: Mark Millard , "" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.77 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.77)[-0.774]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; TO_DN_ALL(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_FROM(0.00)[gmail.com]; FREEMAIL_CC(0.00)[yahoo.com,freebsd.org]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62d:from]; RCVD_COUNT_ONE(0.00)[1]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4XDSxN3KzKz54X7 X-Spamd-Bar: --- Warner and mmel just got to the PR before I got a chance to address a few tiny nits but what got committed is fine with me. Thanks for double checking Mark! On Sun, Sep 22, 2024 at 2:19=E2=80=AFPM Warner Losh wrote: > > > > On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard wr= ote: >> >> From: Warner Losh wrote on >> Date: Sun, 22 Sep 2024 13:19:21 UTC : >> >> > The branch main has been updated by imp: >> > >> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a6c= 613801fb9761ff1e2 >> > >> > commit 85918beb387f179abc93a6c613801fb9761ff1e2 >> > Author: Ayrton Munoz >> > AuthorDate: 2024-07-21 18:10:20 +0000 >> > Commit: Warner Losh >> > CommitDate: 2024-09-22 13:18:34 +0000 >> > >> > intrng: Add support for multiple interrupt roots >> > >> > Different types of interrupts may require using different exception >> > vectors so this commit adds support multiple interrupt roots to handle >> > these cases. Archs may opt-in to multiple interrupt roots by defining >> > INTR_ROOT_NUM as the number of roots in their intr.h. Based off >> > https://reviews.freebsd.org/D40161. >> > >> > Signed-off-by: Ayrton Munoz >> > Co-authored-by: Kyle Evans >> > Co-authored-by: Andrew Turner >> > Reviewed-by: imp,mmel,mhorne >> > Pull-Request: https://github.com/freebsd/freebsd-src/pull/1363 >> . . . >> > +/* >> > + * Archs may define multiple roots with INTR_ROOT_NUM to support diff= erent kinds >> > + * of interrupts (e.g. arm64 FIQs which use a different exception vec= tor than >> > + * IRQs). >> > + */ >> > +#if !defined(INTR_ROOT_NUM) >> > +#define INTR_ROOT_NUM 1 >> > +#endif >> > + >> >> . . . >> >> When I was reading the: >> >> https://github.com/freebsd/freebsd-src/pull/1363 >> >> conversation I saw: >> >> -#define INTR_ROOT_NUM 2 >> +#define INTR_ROOT_COUNT 2 >> >> and related discussion with 2 thumbs up, including one by ayrtonm. >> >> A similar point goes for: >> >> -void *arg, uint32_t rootnum) >> +void *arg, uint32_t roottype) >> >> with another ayrtonm thumbs up at the end. (I've not checked >> if there are more distinctions.) >> >> Such leaves me wondering if what was committed was actually >> the final intended code: Is it? > > > I thought it was... If we need a fllowup, i can do that... > > Warner > >> =3D=3D=3D >> Mark Millard >> marklmi at yahoo.com >>