From nobody Sun Sep 22 18:19:16 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XBZCQ2KXHz5X7dN for ; Sun, 22 Sep 2024 18:19:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XBZCP73JCz4XpY for ; Sun, 22 Sep 2024 18:19:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2d86f713557so2342925a91.2 for ; Sun, 22 Sep 2024 11:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1727029168; x=1727633968; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vBoNZlxorobku0FBwrRSND/ZiAON7CzKTT7Q5uarUF8=; b=GtQET6hryHMjzjnlXT8E69mMDWKf1x4O6Vr1YC0t5+k/RspJmVGOXAZJCWbqJ8O3h8 jlIoQ8SL/IlsUlJCKhikSgrfbJg1tSuk4ngXLXVxj3UKheSfdRPUvsNt1uEBZTy3naoY s9jQU7OwikR/L8O6Qm34GaYbiY6qs+RVIiyK6yDTyEBvkkGlcq/fp7y3WJNeYE/Q5dYd TGg9BWqKb/lwRFEFoykvFRvbNwsQMLkiCt4qLhDox5kSYB1N2p8VAyAvtGd759s8NpDq kaYliWel+da8Pi7vCujrHiON7Ru0J6OMb6pq0W4PFxEkc4GHDZbGs2FXONXYm/G+1EN1 y+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727029168; x=1727633968; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vBoNZlxorobku0FBwrRSND/ZiAON7CzKTT7Q5uarUF8=; b=ARqcMgFMGdi9PXOwSt5rzCun3CIJW04rXF0pumxeYQqf2KRP7EoE4vNLHdzvTxQ2LT LLssTfS4rv3DKHNlcvkAt7PuQcRDBp1T9ZEtnPNIz8Ca9edF2mLT86kbJ4UXumBKAdrP UmZwRzKPmSeQxTGFDeZcTEEJjAkL640FoPG0zRS1vHnASFYycjmUkYipvL6oTWCnCZfe Ft3Y4K7GT5uWnqMUwG9MpNtFwpKHVlVGCG6tMDv7lWIgUNT+s/8LdRdCc5ePESk6de4i VJ3uCIMqjqP/CO5CaKAgQ7I4YoXVUFnnTLdYoze5J4Oc2uIv9gOfsyvmwxtyqP1PTMku r5OA== X-Gm-Message-State: AOJu0Yy5glXW5S6MCyTdvZy232hJw46Sfi0XJyc+buAjEDNeueZ6dJGi eU/mDMIfJyrG4XU1D+mY49PcXtRbTq8bWtItUAdmyJH/R243F92gbViLxVWuME8B8XVCND4woUP e6mq8DbVgBSolTOGlNaUF0vWGi3illSlAeGN1gw== X-Google-Smtp-Source: AGHT+IELpd+wPV1F0G7P5TAOk7UlI/7Zbe/pZiAwFOmpuvvNjyOM/dWPAMsDfReHmF+KUaaBOZNmjtGjAXeytsKD5o0= X-Received: by 2002:a17:90b:4a8a:b0:2d8:8eee:ccab with SMTP id 98e67ed59e1d1-2dd80c4eea6mr10075630a91.22.1727029168360; Sun, 22 Sep 2024 11:19:28 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <1B971CC2-DD1F-488B-A80B-98EF29256D50.ref@yahoo.com> <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com> In-Reply-To: <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com> From: Warner Losh Date: Sun, 22 Sep 2024 19:19:16 +0100 Message-ID: Subject: Re: git: 85918beb387f - main - intrng: Add support for multiple interrupt roots To: Mark Millard Cc: "" , a.munoz3327@gmail.com Content-Type: multipart/alternative; boundary="00000000000018f0650622b9506e" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XBZCP73JCz4XpY X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --00000000000018f0650622b9506e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard wrot= e: > From: Warner Losh wrote on > Date: Sun, 22 Sep 2024 13:19:21 UTC : > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a6c613801fb= 9761ff1e2 > > > > commit 85918beb387f179abc93a6c613801fb9761ff1e2 > > Author: Ayrton Munoz > > AuthorDate: 2024-07-21 18:10:20 +0000 > > Commit: Warner Losh > > CommitDate: 2024-09-22 13:18:34 +0000 > > > > intrng: Add support for multiple interrupt roots > > > > Different types of interrupts may require using different exception > > vectors so this commit adds support multiple interrupt roots to handle > > these cases. Archs may opt-in to multiple interrupt roots by defining > > INTR_ROOT_NUM as the number of roots in their intr.h. Based off > > https://reviews.freebsd.org/D40161. > > > > Signed-off-by: Ayrton Munoz > > Co-authored-by: Kyle Evans > > Co-authored-by: Andrew Turner > > Reviewed-by: imp,mmel,mhorne > > Pull-Request: https://github.com/freebsd/freebsd-src/pull/1363 > . . . > > +/* > > + * Archs may define multiple roots with INTR_ROOT_NUM to support > different kinds > > + * of interrupts (e.g. arm64 FIQs which use a different exception > vector than > > + * IRQs). > > + */ > > +#if !defined(INTR_ROOT_NUM) > > +#define INTR_ROOT_NUM 1 > > +#endif > > + > > . . . > > When I was reading the: > > https://github.com/freebsd/freebsd-src/pull/1363 > > conversation I saw: > > -#define INTR_ROOT_NUM 2 > +#define INTR_ROOT_COUNT 2 > > and related discussion with 2 thumbs up, including one by ayrtonm. > > A similar point goes for: > > -void *arg, uint32_t rootnum) > +void *arg, uint32_t roottype) > > with another ayrtonm thumbs up at the end. (I've not checked > if there are more distinctions.) > > Such leaves me wondering if what was committed was actually > the final intended code: Is it? > I thought it was... If we need a fllowup, i can do that... Warner =3D=3D=3D > Mark Millard > marklmi at yahoo.com > > --00000000000018f0650622b9506e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard <= ;marklmi@yahoo.com> wrote:
<= /div>
From: Warner Losh <imp_at_FreeBSD.or= g> wrote on
Date: Sun, 22 Sep 2024 13:19:21 UTC :

> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a6c613801f= b9761ff1e2
>
> commit 85918beb387f179abc93a6c613801fb9761ff1e2
> Author: Ayrton Munoz <a.munoz3327@gmail.com>
> AuthorDate: 2024-07-21 18:10:20 +0000
> Commit: Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-09-22 13:18:34 +0000
>
> intrng: Add support for multiple interrupt roots
>
> Different types of interrupts may require using different exception > vectors so this commit adds support multiple interrupt roots to handle=
> these cases. Archs may opt-in to multiple interrupt roots by defining<= br> > INTR_ROOT_NUM as the number of roots in their intr.h. Based off
> https://reviews.freebsd.org/D40161.
>
> Signed-off-by: Ayrton Munoz <a.munoz3327@gmail.com>
> Co-authored-by: Kyle Evans <kevans@FreeBSD.org>
> Co-authored-by: Andrew Turner <andrew@FreeBSD.org>
> Reviewed-by: imp,mmel,mhorne
> Pull-Request: https://github.com/fre= ebsd/freebsd-src/pull/1363
. . .
> +/*
> + * Archs may define multiple roots with INTR_ROOT_NUM to support diff= erent kinds
> + * of interrupts (e.g. arm64 FIQs which use a different exception vec= tor than
> + * IRQs).
> + */
> +#if !defined(INTR_ROOT_NUM)
> +#define INTR_ROOT_NUM 1
> +#endif
> +

. . .

When I was reading the:

https://github.com/freebsd/freebsd-src/pu= ll/1363

conversation I saw:

-#define INTR_ROOT_NUM 2
+#define INTR_ROOT_COUNT 2

and related discussion with 2 thumbs up, including one by ayrtonm.

A similar point goes for:

-void *arg, uint32_t rootnum)
+void *arg, uint32_t roottype)

with another ayrtonm thumbs up at the end. (I've not checked
if there are more distinctions.)

Such leaves me wondering if what was committed was actually
the final intended code: Is it?

I thought it was... If we need a fllowup, i = can do that...

Warner

=3D=3D=3D
Mark Millard
marklmi at yahoo.com

--00000000000018f0650622b9506e--