Re: git: 10746040820e - main - ixgbe: rename VF message type macros

On Thu, Sep 19, 2024 at 11:49 PM Doug Moore <unkadoug@gmail.com> wrote:
>
> https://reviews.freebsd.org/D46708

Your fix is logically correct, thank you Doug.  I committed it with
your authorship as I would otherwise make the same change to fix the
tree now.

Pondering aloud, I am uncertain why this did not affect a modular
build, I see if_sriov.c in the ix makefile.

>
> fixes compilation, if you want to copy it.
>
> On 9/20/24 01:47, Yasuhiro Kimura wrote:
> > From: Charlie Li <vishwin@freebsd.org>
> > Subject: Re: git: 10746040820e - main - ixgbe: rename VF message type macros
> > Date: Thu, 19 Sep 2024 23:59:47 -0400
> >
> >> Build fails:
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:103:16: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    103 |         sc->hw.mbx.ops.write(&sc->hw, &msg, 1, vf->pool);
> >>        |         ~~~~~~~~~~~~~~^~~~~~
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:377:13: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    377 | hw->mbx.ops.write(hw, resp, IXGBE_VF_PERMADDR_MSG_LEN,
> >>    vf->pool);
> >>        |         ~~~~~~~~~~~^~~~~~
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:568:13: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    568 | hw->mbx.ops.write(hw, resp, IXGBE_VF_GET_QUEUES_RESP_LEN,
> >>    vf->pool);
> >>        |         ~~~~~~~~~~~^~~~~~
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:585:21: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    585 | error = hw->mbx.ops.read(hw, msg, IXGBE_VFMAILBOX_SIZE,
> >>    vf->pool);
> >>        |                 ~~~~~~~~~~~^~~~~
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:646:19: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    646 | if (hw->mbx.ops.check_for_rst(hw, vf->pool) == 0)
> >>        |                             ~~~~~~~~~~~^~~~~~~~~~~~~~
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:649:19: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    649 | if (hw->mbx.ops.check_for_msg(hw, vf->pool) == 0)
> >>        |                             ~~~~~~~~~~~^~~~~~~~~~~~~~
> >> /usr/src/sys/dev/ixgbe/if_sriov.c:652:19: error: member reference base
> >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union
> >>    652 | if (hw->mbx.ops.check_for_ack(hw, vf->pool) == 0)
> >>        |                             ~~~~~~~~~~~^~~~~~~~~~~~~~
> >> 7 errors generated.
> >> *** [if_sriov.o] Error code 1
> > Same here with:
> >
> > * Commit 420c9844702
> > * amd64
> > * Clean build from scratch
> >
> > ---
> > Yasuhiro Kimura