From nobody Thu Sep 19 02:15:50 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8Jyw4pVwz5VkJq; Thu, 19 Sep 2024 02:15:52 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8Jyw2s6mz4PQW; Thu, 19 Sep 2024 02:15:52 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726712152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYMVQNPZqfjPD41KRFPewJwgHaTix+cg3OgIvpjwbMY=; b=mmsKMlBjURKZzOvG1h6H2OrQRASjAaoDlOZV3SPYMAtyjSzm+8vryCdRa/NyVsGkDSxgkM f/RjZM7EBPAynCQKmAftimCPKZGbjXEpaypp6JZ2IO28aHXRky5ye+z/sFE5RK9q62C1nB mRTuWlCaalnkQThUhgSAfY+HbFPxqQ7XaHm6Izhpa0bJSf+eqb134u2EICFrPh32c7I50u JdRCaTIEELKu1wDDcsri6bxw1VqPXRMXuFPKIy/C/bFsTwZPp79AoyYVtYIiTSTMrehESE H77Jz663qAZ13s2F3pzAPCp2UmiPweurq4zZsLZU29fGWftCrGPCRZdvIlYw9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726712152; a=rsa-sha256; cv=none; b=XhFFF6rn1WrVtrc/8iBwdVWNaAjsmIBjd2JDAoSICAW+XGx/YYp/K4hOjcSZAXVDguT5Kw rCgOmtGhq6mBkdgOrMtC34FRHBe+AZC06vLFXr8gm1/8j/YCz66S+7rYEyyAqfxY6Gc3rk M4M8kVVT+krpXeE7ET2CLjWlWrfzIBfhcitMWAsBqzWrlDBIyNW6TXjBZvLLZyoO6QKg4y WdvJ2P3xABlFqeuMF1QFztK87hplCcTE5D+1ijhKjf0ScpFgdbPJoVg9sfSZAva5YO1iRV iV4nnd3MH6pPj/OKcJQDUGSf78whOI9MPA73CNo8K12CnkBr3aViLh1qgHJY7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726712152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYMVQNPZqfjPD41KRFPewJwgHaTix+cg3OgIvpjwbMY=; b=u9DYUmNNR5Li2jwYl59EJ01sQJkkxZvIHrDnC507kTTFSXFC5Xf0/hLjZQN7wwPOBiEhNd wcVAYjqzcmT6K/ulN4NUgjFM71haVve+10ppsTH9+RxRaBqEYngBH5h4N5AGbJw4qF6qVJ nCOzW/saUzp5xxcbR2h3K7GX9yilHj3FNhGzC6byZ1pD3/HZEXFZsDfj7y47n4Xr4MjNOt HTe2hwIndRyIG4b5QXXzHY444TYcCEd1lyoxV5RQVGC1mkA2F13odgPTzfqeKMoZ61YayC 17pVVmbfTLsUoaE1IwQOiJkyoO8qn1YfGBfX6tEa0Y5vBz7hsdD5eVBt+DKKVQ== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4X8Jyv6hlczTS6; Thu, 19 Sep 2024 02:15:51 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Wed, 18 Sep 2024 21:15:50 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: ce9c3abf69c2 - main - config: Search include paths for files to be read (options, files) To: "Stephen J. Kiernan" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202409181954.48IJsBgL047458@gitrepo.freebsd.org> <20240918205408.TbriDa0K@steffen%sdaoden.eu> Content-Language: en-US From: Kyle Evans In-Reply-To: <20240918205408.TbriDa0K@steffen%sdaoden.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/18/24 15:54, Steffen Nurpmeso wrote: > Hello. > > Stephen J. Kiernan wrote in > <202409181954.48IJsBgL047458@gitrepo.freebsd.org>: > ... > |URL: https://cgit.FreeBSD.org/src/commit/?id=ce9c3abf69c2044c1aab0aa62e4\ > |a73f8eb13d787 > | > |commit ce9c3abf69c2044c1aab0aa62e4a73f8eb13d787 > |Author: Stephen J. Kiernan > |AuthorDate: 2024-09-18 19:49:46 +0000 > |Commit: Stephen J. Kiernan > |CommitDate: 2024-09-18 19:49:46 +0000 > | > | config: Search include paths for files to be read (options, files) > | > | This is useful for downstream consumers to add their own kernel config > | files in another directory other than the default ones. > | > | Obtained from: Juniper Networks, Inc. > | Differential Revision: https://reviews.freebsd.org/D44538 > ... > [... snip ...] > |+ free(fnamebuf); > |+ } > |+ } > |+ } > | if (fp == NULL) > | err(1, "%s", fname); > > Having said that. Why is that file marked .cc aka C++? > This is so pure basic C Mr. Somers surely gets goose pimples, and > then comes back complaining that a memory safe language would not > have had this problem. File pointer, asprintf (horrors!), lots of > char pointers, SLIST_FOREACH() not some object encapsulating > possible difficulties, and what not. > In short -- this changeset is surely meant to buy Rust some > buffalo nickels, and whereas some maybe smile, the Rust gets > armored steel .. and in the end we have to use this merde (imho). > Because it uses a C++ feature. Notably, I had no interest in implementing the equivalent of std::unordered_map when I can quickly convert it to .cc and expect it to work. Thanks, Kyle Evans