From nobody Tue Sep 10 17:56:55 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X3BGv4Y2bz5WKQN; Tue, 10 Sep 2024 17:56:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X3BGv433pz4Gd4; Tue, 10 Sep 2024 17:56:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725991015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dHMm81bMzX8adLVn92XGcol/y2BwNkcKvmEUf5FZmvE=; b=FBKD1pE2nYy3hzRZaaA4Owuyqbgrd2ISXh6hJIENvSQxC458n1zQfi3QOj5lEBvEz5zlMp KbUvOGkzvhzejb5PHazoSr0zID0GHY1vADz8OJtWRgcl9DRQqVyLXXMDWjTV7QvQGX92H1 qAH3Z7L727qyFKu8awSUmWPwVeEI05oAgZtXb8NMuS5MVBAtnTtWF3DiK9JoZG1zIA6yVS 8Slh4RgvFT5pGAzRhi7/Us/3c5AZJgJx58xsiNHcmmiMwPeFUMDjMyZI4MIwnGDwn191Q8 weRQnZ8Jb28sf4fb2HFJmNXFs5jnWep6eGXkaGHono1sxBs6snAJVIz9jEyhSg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725991015; a=rsa-sha256; cv=none; b=mo4aYfbmma2dSkHUvuRLsHNiugslMCseCzkmKPItbvHTFvmihazmv471TXoaVAdaMr6LaZ rGmbtb25K4ALO/f0D1AFAw13Fx8ha+TKVQAl4xtDguCoyDfqkrZjUS7tRWY3LDaEXBVCr7 IUg0OOsWX4mbM9DUDFEWNA78NQqFFUvhrTwOiP83M6s9FnQdms9emqZQORcU2uXW4qrU8y dDfAvbKaaFXxf52ZgbKQ6L5leiU7kUQlo3m2ZL3lly0K6jIK3Sf28ifG2gmDnWX9Y16C/N 772qyfvcLFMGqaFe9bJpRcck5z1zE1gTEyhh5ihdUIZfivRospV4nz5zThPkNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725991015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dHMm81bMzX8adLVn92XGcol/y2BwNkcKvmEUf5FZmvE=; b=G8dO72hDalAAJL8fwGAxGKTGRVDQYzvlAmoW19jdykPMge0UKgg2HOGzFjgCgdmMEQ1uSo 9it7qiu+EsG5Swdq25ngnLMZhbKZ+8Cf576GD7VWthRkppKqsFmJAwaQaGBxWjjoSWGtQ0 3JvMTWoy6osnGMuoMlbi5x6qKHE2E8KZ0TnHY4UfdznsDFEFpMw4sqMvzgXRvo8zAIoHGK oPE4D2ehwfbAPacNCbM6pCRJHNsQWSYv40IhYLoYCXAnme7tTTgSSnqaSl7Licd7mKhbpz FojqQnlIgOoQ8wyf6z/n/roJXfea/skqf/fwrSpOQT9FXAZYgtXFT9nfVq4fUQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X3BGv3cSrzxDY; Tue, 10 Sep 2024 17:56:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48AHut5i087084; Tue, 10 Sep 2024 17:56:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48AHutVX087081; Tue, 10 Sep 2024 17:56:55 GMT (envelope-from git) Date: Tue, 10 Sep 2024 17:56:55 GMT Message-Id: <202409101756.48AHutVX087081@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jessica Clarke Subject: git: 05996f453de2 - main - kldxref: Don't warn and skip file if no relocations are found List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 05996f453de2f2c7a03437a492d9d53831fccb2e Auto-Submitted: auto-generated The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=05996f453de2f2c7a03437a492d9d53831fccb2e commit 05996f453de2f2c7a03437a492d9d53831fccb2e Author: Jessica Clarke AuthorDate: 2024-09-10 17:56:22 +0000 Commit: Jessica Clarke CommitDate: 2024-09-10 17:56:22 +0000 kldxref: Don't warn and skip file if no relocations are found This case is hit for the kernel itself on riscv64, and did not used to be checked. Since the code here can already handle missing Elf_Rel and/or Elf_Rela just delete the check. Reviewed by: jhb, imp Fixes: 0299afdff145 ("kldxref: Make use of libelf to be a portable cross tool") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46517 --- usr.sbin/kldxref/ef.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/usr.sbin/kldxref/ef.c b/usr.sbin/kldxref/ef.c index 77ddada946f2..975626e46046 100644 --- a/usr.sbin/kldxref/ef.c +++ b/usr.sbin/kldxref/ef.c @@ -364,11 +364,6 @@ ef_parse_dynamic(elf_file_t ef, const GElf_Phdr *phdyn) error = EFTYPE; goto out; } - if (rel_off == 0 && rela_off == 0) { - warnx("%s: no ELF relocation table found\n", ef->ef_name); - error = EFTYPE; - goto out; - } nsym = 0; for (i = 0; i < nshdr; i++) {