From nobody Fri Sep 06 20:53:41 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X0pNr53qSz5Vy1b; Fri, 06 Sep 2024 20:53:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4X0pNr32b8z43vb; Fri, 6 Sep 2024 20:53:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 486KrfSp014035; Fri, 6 Sep 2024 23:53:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 486KrfSp014035 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 486KrfOI014034; Fri, 6 Sep 2024 23:53:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 6 Sep 2024 23:53:41 +0300 From: Konstantin Belousov To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 07d90ee0a621 - main - kvprintf(): Fix '+' conversion handling Message-ID: References: <202409061835.486IZ9Fd010541@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202409061835.486IZ9Fd010541@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4X0pNr32b8z43vb On Fri, Sep 06, 2024 at 06:35:09PM +0000, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=07d90ee0a62110e5161bb0b8a3a0b1b9d2beabad > > commit 07d90ee0a62110e5161bb0b8a3a0b1b9d2beabad > Author: Sebastian Huber > AuthorDate: 2024-06-14 07:30:28 +0000 > Commit: Warner Losh > CommitDate: 2024-09-06 18:34:30 +0000 > > kvprintf(): Fix '+' conversion handling > > For example, printf("%+i", 1) prints "+1". However, kvprintf() did > print just "1" for this example. According to PRINTF(3): > > A sign must always be placed before a number produced by a signed > conversion. > > For "%+r" radix conversions, keep the "+" handling as it is, since this > is a non-standard conversion. For "%+p" pointer conversions, continue > to ignore the sign modifier to be in line with libc. > > This change allows to support the ' conversion modifier in the future. > > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1310 > --- > sys/kern/subr_prf.c | 27 +++++++++++++-------------- > 1 file changed, 13 insertions(+), 14 deletions(-) Again, isn't rtld_printf needs the same change?