From nobody Fri Sep 06 18:05:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X0kfR2d86z5VNKb; Fri, 06 Sep 2024 18:05:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X0kfR1q9Vz4KFN; Fri, 6 Sep 2024 18:05:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725645919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kgoXlyZJxZN4oCUaviBbFO4E3JjI+ewWxKfeG/makM8=; b=IwcTSjwlLMiLRWAdMH9SVWk5IsK+6FeYdsCVrEzifIXbhTXQigD5oTL3yo/MB/95UKIlkA JTEPglp3s05cY/Y8RMo73W5XQ7TCLyjPkYh2HMaC5+pX5BkUYaUR6mzCYflaAL2xgVjxJy 6QY9RlP7SBPfVChcsCRB9ztdzyzneCzliTFAdjQtKzKwaey33B8BgSvx7nGBYMiSBTQd3q bfg64ifp26P5vEdwGK+slLWgH+LjI1N+3bSmRZAaL3KOjMeIxJWMRMRzgCOJETJXeEk7F/ DFg1pwo7QYEuABaU2q7ZU8/RS83Wl3+Y/meQCNZoPPpS3Os7dItltR3faPVdyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725645919; a=rsa-sha256; cv=none; b=glxo9lgK/VRquO0HgK625sbj+4QNmdlmVk3bskU0aOVJ0Ldds3DJd6iB6clP5Ex+vQoZdB mugU9qEAJ9j2TutrMEc6Eionq/k267wXGBXfWcaF9YI5UGt4G7YkWcdS6PIMe6O+CDAa49 NwWvA5VRTZlhNdkCleA9oqVSLm1paDhA9COjV9FT0gipUIp7L9Rp6/57FiBa4kRpEYjkOV qzSL04WLbOGt5bXmLScJrRjeJT+DIEzkWMnJqSm9bnsJkEvPYT4u+wURrPG0nEJox1b1pK k8E0JlFBKW8xPv+7owrO7nX2qwSeDpFun5BOBrp5EYZUSTodl3ar6nKfwCj6AA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725645919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kgoXlyZJxZN4oCUaviBbFO4E3JjI+ewWxKfeG/makM8=; b=cPqAJqYjxkzUlNt2JxYULBi8ySA0GCXChevfLdFzOE6aeQGnXS8V6ZQDNAFmkU3H8rC9vJ LitJBd5TZ+CUB17SQo/bBYPdvivZUtBJ6fInJDxWCDFBru0NF/MRrwqSAXm7naApQ3Fj9t /1ZmyGMnlj9myaShNQ3JptwFAtrlfZreq1B5vRf2xct0ka9zKOoLa8/bvlcqfZf+D7p14q QdF44DKRk16r7OIXOkUWtqh/zn2p7SeZi0AYpsP1KTSM2zfZAzaf/Lt43ZTXi8ftt7Aqy+ oGQXHXxOY61OomnvOM+k7pvIDmCOxXjVT1DZfsPufQpTljcBae8OqsqWIKBZkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X0kfR1QhGz12Xb; Fri, 6 Sep 2024 18:05:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 486I5Jqa059698; Fri, 6 Sep 2024 18:05:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 486I5J8Z059695; Fri, 6 Sep 2024 18:05:19 GMT (envelope-from git) Date: Fri, 6 Sep 2024 18:05:19 GMT Message-Id: <202409061805.486I5J8Z059695@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mikhail Pchelin Subject: git: f5a58c2da239 - main - linux80211: fix default deflink.rx_nss List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: misha X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f5a58c2da23930ee4870f2eb54788f4669b9aa33 Auto-Submitted: auto-generated The branch main has been updated by misha: URL: https://cgit.FreeBSD.org/src/commit/?id=f5a58c2da23930ee4870f2eb54788f4669b9aa33 commit f5a58c2da23930ee4870f2eb54788f4669b9aa33 Author: Mikhail Pchelin AuthorDate: 2024-09-06 18:04:52 +0000 Commit: Mikhail Pchelin CommitDate: 2024-09-06 18:04:52 +0000 linux80211: fix default deflink.rx_nss Native Linux implementation sets this as a maximum between 1 and ht/vht/eht rx SS'es, FreeBSD does the same, but uses 0 as a minimum, which leads setting it to 0 if we're not in ht/vht case. This 0 was breaking rtw89 driver, when it was trying to determine SS number by subtracting 1 from rx_nss and passing the value to the hardware. After this patch rtw89 association and simple ping work reliably, but more work is needed to make the driver robust with heavy traffic (iperf3) and being long idle. Reviewed by: bz Approved by: bz Sponsored by: Future Crew LLC Differential Revision: https://reviews.freebsd.org/D46528 --- sys/compat/linuxkpi/common/src/linux_80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index a2791d20a727..ae765cda5781 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -347,7 +347,7 @@ lkpi_lsta_alloc(struct ieee80211vap *vap, const uint8_t mac[IEEE80211_ADDR_LEN], sta->deflink.smps_mode = IEEE80211_SMPS_OFF; sta->deflink.bandwidth = IEEE80211_STA_RX_BW_20; - sta->deflink.rx_nss = 0; + sta->deflink.rx_nss = 1; ht_rx_nss = 0; #if defined(LKPI_80211_HT)