From nobody Fri Sep 06 15:12:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X0fqP1QL5z5VJ1Q; Fri, 06 Sep 2024 15:12:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X0fqN2wCgz4hrc; Fri, 6 Sep 2024 15:12:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-7a8130906faso142766985a.0; Fri, 06 Sep 2024 08:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725635567; x=1726240367; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DXkjWK+M3EPZbadBK2bxnwETRVFmR4n4/ybsGNia/5c=; b=jkL1kcP31y3+jZWWz2C54bNAsh2Bm+ttHpIFPoMzu9a2o9NTCbxv0wMti1hacxyj6J Ha5NexAPa5DpN4m7Md7Ll0rZ/Ffu/UPTuBypgD5SMemQKJVd5VCxeR/L1hwCkJaxsTkB 41idb7GExH78xY6QiJ5/cgodBDgTSJfVhGLwcyE5OILW8rshhr1KizikcybjjqHsw5X6 /DQXKaMXX2UK5h+bg9LhvGNx+BLlls7cm6BbL4Wt5E889rnm266PCM7xxC1+llacGgFm asnKiaJmLKtLlrtBJZZfQxE4jDACe3zjYPRTVpDpKdBuh/eA4GesgU9wWN+CG1eJZAmS Cp8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725635567; x=1726240367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXkjWK+M3EPZbadBK2bxnwETRVFmR4n4/ybsGNia/5c=; b=dIEsG1pX85vkoXxS+JQcZme1fReEERaFsOB3d5+eD+KW1QXHKlin/iYEJ3FcS/VoEC IZtCh20WjAPmDhXNZBgzhQQf0cA2kz+HC0c5We57VpxSIlPOFXeggRK6rprOcviu7yER Q6LyqSW0vwdpQnGZSQCt63rkgDwUyFcwTF75kwo7yQHfz6jEpqQa6R02j7KDWaOKgoAa 5Opng9psf2zyX9aEirCCvm2dA3nAOPQGgxEdQD2weK0PRB/gCxGtrVcIs3Niq/aCArZg jOclGD3tpGKoJjoDV9LAAt/0uYV9clSve9Hjqn+7Jpgh0sh/VbuvCf1Tf88diPnZvi+B yymg== X-Forwarded-Encrypted: i=1; AJvYcCUQXwEmSCI9tySz0TYy9nkHuau4Ucz1mbbPYAf4+7VIUF51lR0vdXs/RqP0+iRS45Sndpq1yIyW1NcxKGPitSo=@freebsd.org, AJvYcCVtkYR/rcShsiLpAVR+Rlx09nI+NcrHIbd2XQ8IHH+U44yTDMPDSH0HhbRoTy0fnGubMsT03J6pfSb3Ax05/S8OraXN@freebsd.org, AJvYcCX1M71ituJoTskp2Iedhp/3k49Jqirlss1+U8tRppEna6vL1MO0OG1wTv2EIYKYZvgVvoue3CIIIN7Oz++YDMUs1Vwb8Ho=@freebsd.org X-Gm-Message-State: AOJu0YyiluLvT4Lv5iwFp3bvAijY2OqTFMA5z/97fEzBnGId6+NLLcYI 2DQ2HiB/PANWDzIiARunkgHolJXsoukqGGe9Uormj5WDDllGDnVR6hIvEg== X-Google-Smtp-Source: AGHT+IHgv4pTqWtjeao71Zi5QF90DaQqSyetH0r+P5UFTqYWHhRZwsdo/0qzWbJb2wbfQ8A5tEZacw== X-Received: by 2002:a05:6214:2b9d:b0:6c5:de4:3edb with SMTP id 6a1803df08f44-6c5284f61c9mr31357606d6.29.1725635566509; Fri, 06 Sep 2024 08:12:46 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c5202de4b2sm17372836d6.58.2024.09.06.08.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 08:12:45 -0700 (PDT) Date: Fri, 6 Sep 2024 11:12:43 -0400 From: Mark Johnston To: John Baldwin Cc: Shawn Webb , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e962b37bf0ff - main - bhyve: Do not enable PCI BAR decoding if a boot ROM is present Message-ID: References: <202408191359.47JDxAbK026029@gitrepo.freebsd.org> <7213e551-6be2-44b1-a8b6-55645c593c12@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7213e551-6be2-44b1-a8b6-55645c593c12@FreeBSD.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4X0fqN2wCgz4hrc On Fri, Sep 06, 2024 at 09:37:45AM -0400, John Baldwin wrote: > On 9/5/24 22:10, Shawn Webb wrote: > > Hey Mark, > > > > This commit seems to force me to now pass "-o pci.enable_bars=true" to > > all my VMs on amd64. I wonder if that might be a POLA violation. I > > didn't realize that I needed to set that until I bisected the src > > tree, looking for the commit that broke bhyve for me. > > > > Is changing the default here really worth it for amd64? If so, I'm > > thinking this should be in both RELNOTES and UPDATING. I now have to > > propigate re-enabling this across my entire infrastructure. > > > > Thanks, > > That should only be true if you are using an older UEFI firmware that did > not program BARs. Are you seeing this on stock FreeBSD, and which version > of the UEFI ROM are you using? Indeed, it'd be nice to see which bootcode and guest you're using. I had tested bhyveload, edk2-bhyve and grub2-bhyve with this change without problems, and wasn't planning to MFC. My hope was that this wouldn't have any user-visible impact on amd64, but if that's not the case, the default for pci.enable_bars may have to be flipped on amd64.