From nobody Thu Sep 05 15:39:14 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X03SM2PlYz5WFrd; Thu, 05 Sep 2024 15:39:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X03SM1WSsz4k81; Thu, 5 Sep 2024 15:39:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725550755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=84d6Nze3Uc0ZTF1ri9IpLdTeQ95PyiLmnd2SVsHGVgY=; b=PO4fhEZXK1wk1Azc5jzpW7Aw5kVtXL31o7q+GpldLFtsgKiObahVoTZS1WG1axOmFJpcad SPP6aAAS7Zb3H6Hl5MAXCqC0MYTj6jXelMaY+4MeRwRbMTMLhD7qaa07pX3aMJsix8ZA3q rIm9msjtM5VGGirW/fc8px+XsCJWvE6hRJ2Wvwrm93o/ugaTi0MjslpIcx45+14V6FmNi0 29s87K8WKQDWTBr1JuBKo2C5SjhHZKqGbFTtYnuaxq73otlOII+Zzkr4S76iwBYzrAvdvp syTbgNRtJJDnrQc09je1/oVgtHp/jG/HIdhvnXkz7gSu9O+D5UocapDk9tsppw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725550755; a=rsa-sha256; cv=none; b=AUGRN70NcZi2Hamfl8c0n2vpFgmL6IMPuXA34kt0WpGFtX/ZuS0u+UB7VRflt4KLwT1xdh 0WSS+YmjvOC1dPr6z6+jcxPbo9eTZDPE+1nIW24Ai31zn6DpQC/Y2Tub0VrIx2CdGrzvqw 2ZrvpUHzz+VZCV8pnrRdkQbQ0qAa+o2wCux0Uj5o/S3XVQyBLDmHqiIv2MFS8MuQdOUNTt phpnt7C/o5FN5Zwq22tviOfQ/THsaJ3WOlMX1PVfiIn4D/yk5rnFWhHL2AV6Dp2vLoyV+m eoGjzW3qUkrbfkbTY5uYhaQW+IZbLtTDaVY7VwAVXjNlyujzy9T7PQZjB9G0fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725550755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=84d6Nze3Uc0ZTF1ri9IpLdTeQ95PyiLmnd2SVsHGVgY=; b=V/4GG9oC/xJ1chkc7har3VpnjSUE69eJwCyaHHGY8wx6oJXVJ+Xcf+ZAEGKwdjR2r7WMld 7tk9ufkxbqpGKH/ZqoT/kGZPdkelyTkkeeEzK7HAqGuapOHyjTFLL2MlPFzaZ5MQHlQ1LU UK30KjcActlTHfElY+TLfXWQZQU2/1tIA1PHNvRo+RZy7lVWeje1+qtgY3ZidbkJF8NPZ5 mMD9hI5QRRVl2kYjnA7uwhkvC+yZhdvzoTPKARj6CoivTuLSrh5chT7qV7aZ0hpV3zoNEb nmiXqCbvGdcPGsrVYOqOzOMNg6vadSt5m92mjJrIBelU6X+6if13NYbwgeuhtA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X03SM0nKBzF1B; Thu, 5 Sep 2024 15:39:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 485FdFBV053309; Thu, 5 Sep 2024 15:39:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 485FdEMI053306; Thu, 5 Sep 2024 15:39:14 GMT (envelope-from git) Date: Thu, 5 Sep 2024 15:39:14 GMT Message-Id: <202409051539.485FdEMI053306@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 0b45d36510d8 - main - al_eth: improve TCP LRO List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b45d36510d8c629fcc49805bc64e5893f4ba63c Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0b45d36510d8c629fcc49805bc64e5893f4ba63c commit 0b45d36510d8c629fcc49805bc64e5893f4ba63c Author: Michael Tuexen AuthorDate: 2024-09-05 15:35:40 +0000 Commit: Michael Tuexen CommitDate: 2024-09-05 15:35:40 +0000 al_eth: improve TCP LRO Use the appropriate function to flush correctly all entries. The old code does not remove the element from the hash table, only from the active queue. Reviewed by: Peter Lei, rscheff MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46434 --- sys/dev/al_eth/al_eth.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sys/dev/al_eth/al_eth.c b/sys/dev/al_eth/al_eth.c index e12c8dfcc281..f4fec7c6aa94 100644 --- a/sys/dev/al_eth/al_eth.c +++ b/sys/dev/al_eth/al_eth.c @@ -1580,7 +1580,6 @@ al_eth_rx_recv_work(void *arg, int pending) { struct al_eth_ring *rx_ring = arg; struct mbuf *mbuf; - struct lro_entry *queued; unsigned int qid = rx_ring->ring_id; struct al_eth_pkt *hal_pkt = &rx_ring->hal_pkt; uint16_t next_to_clean = rx_ring->next_to_clean; @@ -1671,10 +1670,7 @@ al_eth_rx_recv_work(void *arg, int pending) "%s: not filling rx queue %d\n", __func__, qid); } - while (((queued = LIST_FIRST(&rx_ring->lro.lro_active)) != NULL)) { - LIST_REMOVE(queued, next); - tcp_lro_flush(&rx_ring->lro, queued); - } + tcp_lro_flush_all(&rx_ring->lro); if (napi != 0) { rx_ring->enqueue_is_running = 0;