From nobody Wed Sep 04 21:50:55 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wzblh41yhz5VS5L; Wed, 04 Sep 2024 21:50:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wzblh1KxNz4hH4; Wed, 4 Sep 2024 21:50:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725486656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jU4UkNvf6WD1I9tKBSQ2HatqkU4nc2C3pFwI8QyDli8=; b=Cw3s9zuQEih7tJ87mUe0iG2gtYizQeYVTmO/IDMpQ/UiqgGj5DU/ckEg1lws5F6qX7UR0v 9lXvmSih03gULQw+/v5Qr3sFt4d7v+HIMmqLaoWSFkApuzs3M8KkN53I3OjiHnU/qnwlZ8 16cFdW7gPIGPe+xNPWMu62WSuNwlIBmRTdP2MPesxbV/bJSinwBE1D9cnaPPaDvA2TauXn zx4Q0EdRfeaBNHQ2sVQhwB9hLTC5zhVDk+MWhGkYmrByFUtpO3HeR0SrSFLZ6LKDG7hJgL pgspCuyTKlp9rlJNLETMpCQw+yPjWJMx1rdIYc+WaeQmxFol4djtST8nU5UYJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725486656; a=rsa-sha256; cv=none; b=Cb2ViJwhIbahT8/4Yfir8/ha6RQ0Hrr6l1zfpRkkgHIstt8lq/sFfr/wBHurlcMMYcPHbO Yy//6AczdWr3FjZT60FLDWSNMLdmlw4n1yLhHESlR1S5fsd8jp11R+q/UcSlZ92/FYt1MP qhfmMIreo6+mP4QvJ8/ww0RhY7QTGlk7ljpV1BlhZI1TI0Tib/7lfe0k5LpAup7S8L0vMw MEbzC0K8lYqFtRWs5XKt9j+TzXhG8SsUdS3/eRMB1MpY7u37rnjoCElFhCl/yTV7e36soE feJyyukdLFjkGWUA1mEQiq21doaj+eViyhhTH6wLjpOciA5ZyUA0SZ8Jr2MD4w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725486656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jU4UkNvf6WD1I9tKBSQ2HatqkU4nc2C3pFwI8QyDli8=; b=hMfKLGu1wrDuwZgUGNE5eEwwSwSrrhdqGl7Bg2B3hSRvLFuR02Ww07i94MIyeju1zCGvAW OQgmowhxXoVnrS1evxtS90ahCFFF/ZkTDRfrcStZrnIEZYgFKH4yDlVBt3mv9bHG5wdCET yyqc0zXpYNQgkh4LV76ue7a/S+XEfXKB0qVLDYhphgl3pqsQaMNOkDXuM5XWAYdnF92xEw 1Maub1L1t15nfFwZtGDrvkmHJvt0sKHAIHjtCtTy2zvWUL2VmUeCrpN7w/7h7i2bvdGqh1 5M7sz/5P657H+ODVYwg7i5ImuOlLSaZoUWLl+sV/jZrN0c1HeBFWwlQKxz44ng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wzblh0lTTzhbt; Wed, 4 Sep 2024 21:50:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 484Lot4m033160; Wed, 4 Sep 2024 21:50:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 484LotVO033157; Wed, 4 Sep 2024 21:50:55 GMT (envelope-from git) Date: Wed, 4 Sep 2024 21:50:55 GMT Message-Id: <202409042150.484LotVO033157@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 5681ddfd9f80 - main - msi_alloc(): do not leak msi_lock in error case List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5681ddfd9f80c3aa25f900a1bcaa69b36a4e9e27 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=5681ddfd9f80c3aa25f900a1bcaa69b36a4e9e27 commit 5681ddfd9f80c3aa25f900a1bcaa69b36a4e9e27 Author: Konstantin Belousov AuthorDate: 2024-08-27 02:28:10 +0000 Commit: Konstantin Belousov CommitDate: 2024-09-04 21:50:19 +0000 msi_alloc(): do not leak msi_lock in error case Sponsored by: Advanced Micro Devices (AMD) Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/x86/x86/msi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/x86/x86/msi.c b/sys/x86/x86/msi.c index 888635cba3f4..177bd7868ec4 100644 --- a/sys/x86/x86/msi.c +++ b/sys/x86/x86/msi.c @@ -480,6 +480,7 @@ again: if (error != 0) { for (i = 0; i < count; i++) apic_free_vector(cpu, vector + i, irqs[i]); + mtx_unlock(&msi_lock); free(mirqs, M_MSI); return (error); }