From nobody Tue Oct 29 18:09:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XdJF50dckz5bl5k; Tue, 29 Oct 2024 18:09:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XdJF501c7z3wgG; Tue, 29 Oct 2024 18:09:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730225385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtQFPYGWbTL2B5rF50PHnQGsb8TZZ9EnZcwyRw7qENQ=; b=ItfoE5xea1dxoebethmjNt938lYBvut09+ccbZjDPR1xWefJIP2BqhqO3j1IjpCRDdYeNr W0WzDtJun1VvWuE69kNDiDE34KjwtT35MW/4ISX4QM8h26zi4d2Z6kgp4qHj0YeYLkFHpu m93V9V47LdVlpxDt8na5b/LykFCe8sbnQKYVZx8L/owUeeSggxVLPjH1PfSMDsGCdUx87p 7q/UkcXnt6zZk6oyAzTEHftS6Z/VKgs3vfQJ9spkPyXT5p9Vsp2xAOncKLARA2s7I3zIVt dy1kzwRjfSkKbcaWjwu/BNIeBuvHWtu40VVx6umU4mCOfTlfAhwcJVzwq/Qjdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730225385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtQFPYGWbTL2B5rF50PHnQGsb8TZZ9EnZcwyRw7qENQ=; b=JAUGANsQxzRdSODhHYSIXU5XIIaRCD+uN21hWCtvuvv0obsBrs7nnwdSFXdaGiNADvtMUa 6ZvF3fho7YCswKXbPR9ybP/YrW1dVsnGipAczvXv5khVwcCfORmDiQsOp/avZ8tP/nG8QT OaYoROi4bsMc+1YOlM5u3xVmK5mq8PVJaW2xQDRSDviT/7C1Ii4Ps8nX3l1y/UOkmJs+sO kfeKM4T3r6EAqSEZN7/ZDTwA4zGINsLzVJx0lB3p9zGb/bM6/587nrWKbB8OyNlOi2secE XPt0AQSOnXtuf6lTNTVtuhZ4T/fxipdfhlGvE7bZiYjGA2MVvcRQEk+36ou2VA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730225385; a=rsa-sha256; cv=none; b=YSRRrFXTlTWkSqcyz23xxmLLWl83yiaWNbJkF7RRJpN5xkxqzjReweetawp9YSe0mBWuxn lky4akeR0zVndwwLuRJXfaUXXR0Ko55Ne0gywxKLnx4t+TmugqM/PeqtBIy7vud54nDkzz xdmoGRASQGTiS2+/1dmvGSxI4sdPUn7c5YNx2IQZ2Ae/+M4E/1hB25HJo6PQcDUuPa5/+6 GfQJJD6WcOtK1qOJz1EV2X7GahJG5npbOziG3/1EZQxIhfURJRmjmLCKiuKsF1opR8n8kl N/pA/T6ozuVY091URo0xAX4AD4u8WYPO2zoElatLqzmmJqdRkbm7DXgjlmMuZw== Received: from [IPV6:2601:5c0:4200:b830:41c2:e465:68f5:36e1] (unknown [IPv6:2601:5c0:4200:b830:41c2:e465:68f5:36e1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XdJF45LRdz17qK; Tue, 29 Oct 2024 18:09:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 29 Oct 2024 14:09:43 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: bc9e19dce0ab - main - Fix buildworld with gcc 12 after llvm-19 import Content-Language: en-US To: Dimitry Andric Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202410251608.49PG8pSI044793@gitrepo.freebsd.org> <4af71fad-407d-48f2-aec4-f6c50fa72c1f@FreeBSD.org> <4740E6A9-B104-46C5-AB19-9C5F2BF66AA3@FreeBSD.org> From: John Baldwin In-Reply-To: <4740E6A9-B104-46C5-AB19-9C5F2BF66AA3@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/28/24 16:12, Dimitry Andric wrote: > On 28 Oct 2024, at 20:56, John Baldwin wrote: >> >> On 10/25/24 12:08, Dimitry Andric wrote: >>> The branch main has been updated by dim: >>> URL: https://cgit.FreeBSD.org/src/commit/?id=bc9e19dce0abee80750e6fa04aaf979873bfe0d2 >>> commit bc9e19dce0abee80750e6fa04aaf979873bfe0d2 >>> Author: Dimitry Andric >>> AuthorDate: 2024-10-25 16:07:59 +0000 >>> Commit: Dimitry Andric >>> CommitDate: 2024-10-25 16:08:32 +0000 >>> Fix buildworld with gcc 12 after llvm-19 import >>> Unfortunately gcc 12's is not yet capable of compiling all of libc++ >>> 19's C++23 code, which results in errors similar to: >>> /usr/src/freebsd/src/contrib/llvm-project/libcxx/include/__algorithm/ranges_contains.h:41:3: error: 'static constexpr bool std::__1::ranges::__contains::__fn::operator()(_Iter, _Sent, const _Type&, _Proj)' must be a non-static member function >>> 41 | operator()(_Iter __first, _Sent __last, const _Type& __value, _Proj __proj = {}) { >>> | ^~~~~~~~ >>> /usr/src/freebsd/src/contrib/llvm-project/libcxx/include/__algorithm/ranges_contains.h:48:3: error: 'static constexpr bool std::__1::ranges::__contains::__fn::operator()(_Range&&, const _Type&, _Proj)' must be a non-static member function >>> 48 | operator()(_Range&& __range, const _Type& __value, _Proj __proj = {}) { >>> | ^~~~~~~~ >>> Until we can get rid of gcc 12, work around this by making it compile >>> libc++ in C++20 mode instead. >>> NOTE: The resulting libc++ library will not be C++23 compatible! Please >>> try to avoid shipping it, and use gcc 13 instead, if you must use gcc. >>> PR: 280562 >>> MFC after: 3 days >> >> In this case I think we probably should drop support for GCC 12 for main. Just let me >> know when you are thinking of merging libcxx 19 to stable branches so I can ensure they >> build with GCC 13/14 and get our CI jobs updated before then. > > It depends a bit on how many ports still need to be fixed, and of course when 13.5 and 14.2 are done. After those I will probably do the merges. > > That said, is gcc 13 good for all arches we want to support? In the past we still kept a few old gcc versions alive because they were the only one that could build for $OBSOLETE_ARCH. I am only aware that GCC 12+ can build amd64 world + GENERIC currently. I believe aarch64 is close. i386 is also pretty close (but I care less about it). riscv64 needs a libatomic since GCC doesn't inline atomics as much as clang. I haven't really tried powerpc much. -- John Baldwin