From nobody Sat Oct 26 19:36:00 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XbVJG3Rs3z5b6fJ for ; Sat, 26 Oct 2024 19:36:14 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XbVJF6NQZz40yM for ; Sat, 26 Oct 2024 19:36:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so28432125e9.0 for ; Sat, 26 Oct 2024 12:36:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729971372; x=1730576172; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7xbpph6T6x3wXrYk/20KVdquVWfmpnaNW0ub4gFdTc=; b=VlSRanTCKFsRa6YdFNLS/pVh82Yt7IbzAW2EwteWstRTBkVAesOwpDHqzCRq7Ajbfh LyqaKkLPWsRpn3J0+3gBkjRGrE3KNJSZOw2IRdIriAPBJLyiorip8rK9M3iQprDMWMuY wV+CmBsEISLmeT/NDdrj0bwzOHtYxa+YJO7BaJRJnaUqHRbKQOkVoXz5iBv5iKf4AL/W KriNMjS0iWhkPxJedT9JE6BK+tulWCowkA2A9w+5IbPaUmYbec0r5QzyFiYumItywaeW AObHKHBm5RWOoYk0cPIzrA51IESthlG4Z9LOmz86ssQVq0toKv8f+Y90U6ZN6ZlHY9lF 7ZtA== X-Forwarded-Encrypted: i=1; AJvYcCU0jK6OH6+wG5ZAGwvmmcieTZ2y5XS73wtt6hFWkStegBPg3HjK7Wc71Ywtbgez3tIjxY6gKR8T5TfOQQroyY+kas44lw==@freebsd.org X-Gm-Message-State: AOJu0YwgSyFoYGjF/GCF23puwSUVdM0Z1dAUFQYP1xOHiOmTTnhhNhv3 rJi4xzJ2sPCbIcqJ94U6oLI+a8dZRuNzaZDQ5xVI9kzyxyHycMeKTcNUaXFhx2M= X-Google-Smtp-Source: AGHT+IEmcXPI0RCIzYES4+u2XfWbaRgi3taW+PjPfV5b4lR6Jbcc3ooY162sCR/qEKHJBjw32n4VRg== X-Received: by 2002:a05:600c:4e8b:b0:42c:b037:5f9d with SMTP id 5b1f17b1804b1-4319ac74268mr29689195e9.3.1729971372501; Sat, 26 Oct 2024 12:36:12 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4318b58b6bdsm85821035e9.45.2024.10.26.12.36.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Oct 2024 12:36:11 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: git: 152382e6613d - main - rc.d/kld: Print the kernel modules being loaded From: Jessica Clarke In-Reply-To: Date: Sat, 26 Oct 2024 20:36:00 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <58A8DE4A-150D-45A8-8177-86534DB64025@freebsd.org> References: <202410261900.49QJ0cLo037733@gitrepo.freebsd.org> <08AA3DE1-0618-44A0-AE8C-7BDECD2BE933@freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4XbVJF6NQZz40yM X-Spamd-Bar: ---- On 26 Oct 2024, at 20:09, Mark Johnston wrote: >=20 > On Sat, Oct 26, 2024 at 08:02:27PM +0100, Jessica Clarke wrote: >> On 26 Oct 2024, at 20:00, Mark Johnston wrote: >>>=20 >>> The branch main has been updated by markj: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D152382e6613d7998fe6f5233767df54d= 3fdec329 >>>=20 >>> commit 152382e6613d7998fe6f5233767df54d3fdec329 >>> Author: Mark Felder >>> AuthorDate: 2024-10-26 18:43:46 +0000 >>> Commit: Mark Johnston >>> CommitDate: 2024-10-26 18:43:46 +0000 >>>=20 >>> rc.d/kld: Print the kernel modules being loaded >>>=20 >>> PR: 282269 >>> MFC after: 2 weeks >>> --- >>> libexec/rc/rc.d/kld | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>=20 >>> diff --git a/libexec/rc/rc.d/kld b/libexec/rc/rc.d/kld >>> index d9c45a05f7a6..729416323d6e 100755 >>> --- a/libexec/rc/rc.d/kld >>> +++ b/libexec/rc/rc.d/kld >>> @@ -44,10 +44,12 @@ kld_start() >>>=20 >>> local _kld >>>=20 >>> - echo 'Loading kernel modules:' >>> + echo -n 'Loading kernel modules: ' >>> for _kld in $kld_list ; do >>> load_kld -e ${_kld}.ko $_kld >>> + echo -n "${_kld} " >>=20 >> This always prints a trailing space, whether the list is empty or = not. >=20 > If the list is empty, we won't get this far. Yes, but the echo above does the same. By =E2=80=9Cthis=E2=80=9D I meant = the combined effect, I just put the comment here as it was the last relevant line. >> Why not drop the space from the first echo and put it as a prefix in >> the second instead? >=20 > That's a better way to handle it, thanks. Thanks for the follow-up. Jess