From nobody Sat Oct 26 02:41:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xb3nT02lMz5bQrM for ; Sat, 26 Oct 2024 02:41:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xb3nS5Gkyz4T0L for ; Sat, 26 Oct 2024 02:41:32 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4316f3d3c21so24797765e9.3 for ; Fri, 25 Oct 2024 19:41:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729910491; x=1730515291; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=822lAoZ6IEMBcZbK2gJGcKyFuD1zNbg/E7ZXuTPfI/A=; b=fxxx4OiysN5J0g4p99XmZBPrx1hKJRSGCtzl6Hy6giXxUCXT5tDiXAkPQFqZKaUC5V H1FJp51YqURf7fmTmh2DBuBzu7wHunhg/SgASsJTtwtDYVEnC0uR8HUCwJH0yCXIGz2a UdwCxUjseJ53uHgbe4JDur3GwZbN84x2Ay0C2lf2Etj5hDR7ADz14I0oTLZPGF1BXoTr Ltp6LvjxIS/cIgA9j3MFTfdyChbp974BDRmZ6xtq4qLmelheJ4YN6z5tAB8UiR5V2JAE wn8l2Z6tBEPvnr5dZmzGdOqFrYeAKenxrcJROKmfZZqXGV4JuH/TxaXe4GBtUEJE0iuV 1mCQ== X-Forwarded-Encrypted: i=1; AJvYcCWY1YEH1cQpxU9kav7pnL9Ni3c5aAdavPtMnqkya/98h1duz9jdHJs+CPw5YQF/kkVKEumLe93Aursrl2/+X0oqXH0Maw==@freebsd.org X-Gm-Message-State: AOJu0YxUegeyyw/SpuwfQu0jZCUQ00iKml0KlOmlMA6WMn6XWm/0KUv+ IlSLieIgNubgbJHsmqXf3fnHlCec3JFgrP0PyZgoFRUs5pi4qzJvJ1lqNUBaVcU= X-Google-Smtp-Source: AGHT+IFX0GXXYlVIKWvlKsHR8Z5iVTIhRGQtDPQbvoeoxMlHq95mTQyJGXOjzXSuHdqPyRadtHljDw== X-Received: by 2002:a05:600c:19d3:b0:431:6060:8b22 with SMTP id 5b1f17b1804b1-4319ac9a6bemr9288115e9.10.1729910491113; Fri, 25 Oct 2024 19:41:31 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4317ddec611sm64671605e9.1.2024.10.25.19.41.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2024 19:41:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: git: 2f3f867ac6dd - main - ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 From: Jessica Clarke In-Reply-To: <202410260235.49Q2ZA9j007514@gitrepo.freebsd.org> Date: Sat, 26 Oct 2024 03:41:19 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202410260235.49Q2ZA9j007514@gitrepo.freebsd.org> To: Colin Percival X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4Xb3nS5Gkyz4T0L X-Spamd-Bar: ---- On 26 Oct 2024, at 03:35, Colin Percival wrote: >=20 > The branch main has been updated by cperciva: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D2f3f867ac6dd7ff3769366b828b79c44= b38828e1 >=20 > commit 2f3f867ac6dd7ff3769366b828b79c44b38828e1 > Author: Colin Percival > AuthorDate: 2024-10-22 14:47:30 +0000 > Commit: Colin Percival > CommitDate: 2024-10-26 02:34:56 +0000 >=20 > ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 >=20 > AWS Graviton [1234] systems have a bug in their ACPI where they = mark > the PL061's GPIO pins as needing to be configured in PullUp mode = (in > fact the PL061 has no pullup/pulldown resistors); this flag needs = to > be removed in order for _AEI objects to be handled on these = systems. >=20 > Reviewed by: Ali Saidi > MFC after: 1 week > Sponsored by: Amazon > Differential Revision: https://reviews.freebsd.org/D47239 > --- > release/tools/ec2.conf | 5 +++++ > sys/dev/acpica/acpivar.h | 3 +++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/release/tools/ec2.conf b/release/tools/ec2.conf > index 54eb0b0b8060..ea61c2fa6db9 100644 > --- a/release/tools/ec2.conf > +++ b/release/tools/ec2.conf > @@ -70,6 +70,11 @@ ec2_common() { > # nodes, but apply the workaround just in case. > echo 'hw.broken_txfifo=3D"1"' >> ${DESTDIR}/boot/loader.conf >=20 > + # Graviton 1 through Graviton 4 have a bug in their ACPI where they > + # mark the PL061's pins as needing to be configured in PullUp mode > + # (in fact the PL061 has no pullup/pulldown resistors). > + echo 'debug.acpi.quirks=3D"8"' >> ${DESTDIR}/boot/loader.conf Should this not be restricted to arm64 in case it affects something on amd64? Also, is there no way to be able to dynamically set this at run time based on some _HID or similar? Requiring quirks in loader.conf in order to get a working system is less than ideal, especially if anyone=E2=80=99s trying to produce their own image, or updating an = existing system (whether via freebsd-update, pkg or make). Jess