From nobody Sat Oct 26 02:35:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xb3f6726Kz5bQqM; Sat, 26 Oct 2024 02:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xb3f66X5kz4RvT; Sat, 26 Oct 2024 02:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729910110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XZgFGDXDbFONjeEa7g9u6fVMFRwNBbI0h06ZToJvHWo=; b=tQD2aV6YDzorV4Nenm8p15via75Kn603lPPDnZBHporMoHlOA5lDRkXQ1Ti+1Q13St9+He UnuGebBqTqzI4otFAOxSvciKcoXdpUjsMtGB46f6EAinxgNZiarWGP4Qjx3k7p8xgXHgAR PaxEQadA4kYn6SU6KC2Ic70HS0Mywjo4PWgp0zEb8q/EeUwgNnGF2RfTRLfGHWlrRZW1MP RXMhKpxsMgmD3gZmV9QDSPcc8q369CLg6+rGnzS+a1Jv2IWDsuQW1LiHuR78/IXTu95/Eq hKqPgoOoMDaXsbqxpwqxdLFKX/3vl5YaN2zZTiOMCXTQ7VhkRgWheSUd+V2Sww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729910110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XZgFGDXDbFONjeEa7g9u6fVMFRwNBbI0h06ZToJvHWo=; b=UorYiYR004YqfHq7ny8xgKyCf8UTZbeE2nb8vCErv1P67kfGCwIJqWgKSPLige8rhCCJU2 aoB3Q5US0P/T4l9dDdXbmUL2u3EFTkGTF3ttnbBiLc+kiJR8dNCQal1t3SI4aUeW9iTB0o 1cl6TDdq9fbK+gaw7QYaPiurSP9NJOGKXkePNC4Vsi+fHw4arh2+h1FKTZXJQ8UXWvRHNn ne4yQyGOLFrIdFEZCxlnOEPuyNcw8YgUwLP5zCtUXhU2dm325dgb3bSljFXIbgWFc0QH2j LdV7tRHwj0pu5xueVDGlVqe3Wb8+pACEztPUoujQ4JuQ3jaVodO6Qgym55+8gg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729910110; a=rsa-sha256; cv=none; b=X+44J6FhjrSNIQ+zliKxdt6I0V0vyWQtsXCRWqEvNY6dnwRCPjBFvbTGC2b94nyaTkl8Cf H3zRhhGLqlXGuGFcnZBpwywWNMgD+BK6UgnHaZrGpDCXHfhf9EpX0/brUvfG3+KfeoMxAd Y7ag4yMvxt2iF9v8mBjLuJBhXdSNzlZ/rKxEvZm/H1mY27is6OxtAdziJrBCzjmDErTMzX xNxJ8/8OGHCrXl+94cDX9TXUBNOj1IusbY5K+XHwKMOYM+DvY7DWaVFMuC2FwrfbWJws/2 TLWg96qNoNtbc9yflJMcBwJEhrDCWVQzx7B16B+3sejXzgQreP8OqQ3aqiSZJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xb3f666TPzrsf; Sat, 26 Oct 2024 02:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49Q2ZA1E007517; Sat, 26 Oct 2024 02:35:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49Q2ZA9j007514; Sat, 26 Oct 2024 02:35:10 GMT (envelope-from git) Date: Sat, 26 Oct 2024 02:35:10 GMT Message-Id: <202410260235.49Q2ZA9j007514@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 2f3f867ac6dd - main - ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2f3f867ac6dd7ff3769366b828b79c44b38828e1 Auto-Submitted: auto-generated The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=2f3f867ac6dd7ff3769366b828b79c44b38828e1 commit 2f3f867ac6dd7ff3769366b828b79c44b38828e1 Author: Colin Percival AuthorDate: 2024-10-22 14:47:30 +0000 Commit: Colin Percival CommitDate: 2024-10-26 02:34:56 +0000 ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 AWS Graviton [1234] systems have a bug in their ACPI where they mark the PL061's GPIO pins as needing to be configured in PullUp mode (in fact the PL061 has no pullup/pulldown resistors); this flag needs to be removed in order for _AEI objects to be handled on these systems. Reviewed by: Ali Saidi MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47239 --- release/tools/ec2.conf | 5 +++++ sys/dev/acpica/acpivar.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/release/tools/ec2.conf b/release/tools/ec2.conf index 54eb0b0b8060..ea61c2fa6db9 100644 --- a/release/tools/ec2.conf +++ b/release/tools/ec2.conf @@ -70,6 +70,11 @@ ec2_common() { # nodes, but apply the workaround just in case. echo 'hw.broken_txfifo="1"' >> ${DESTDIR}/boot/loader.conf + # Graviton 1 through Graviton 4 have a bug in their ACPI where they + # mark the PL061's pins as needing to be configured in PullUp mode + # (in fact the PL061 has no pullup/pulldown resistors). + echo 'debug.acpi.quirks="8"' >> ${DESTDIR}/boot/loader.conf + # Load the kernel module for the Amazon "Elastic Network Adapter" echo 'if_ena_load="YES"' >> ${DESTDIR}/boot/loader.conf diff --git a/sys/dev/acpica/acpivar.h b/sys/dev/acpica/acpivar.h index a71eb9b47eb7..ea32c58b1371 100644 --- a/sys/dev/acpica/acpivar.h +++ b/sys/dev/acpica/acpivar.h @@ -227,12 +227,15 @@ extern struct mtx acpi_mutex; * ACPI_Q_MADT_IRQ0: Specifies that ISA IRQ 0 is wired up to pin 0 of the * first APIC and that the MADT should force that by ignoring the PC-AT * compatible flag and ignoring overrides that redirect IRQ 0 to pin 2. + * ACPI_Q_AEI_NOPULL: Specifies that _AEI objects incorrectly designate pins + * as "PullUp" and they should be treated as "NoPull" instead. */ extern int acpi_quirks; #define ACPI_Q_OK 0 #define ACPI_Q_BROKEN (1 << 0) #define ACPI_Q_TIMER (1 << 1) #define ACPI_Q_MADT_IRQ0 (1 << 2) +#define ACPI_Q_AEI_NOPULL (1 << 3) #if defined(__amd64__) || defined(__i386__) /*